repo stringclasses 200
values | pull_number int64 13 143k | instance_id stringlengths 12 47 | issue_numbers listlengths 1 7 | base_commit stringlengths 40 40 | patch stringlengths 354 98.3k | test_patch stringlengths 137 8.74M | problem_statement stringlengths 142 63.8k | hints_text stringlengths 2 70.5k | all_hints_text stringlengths 2 70.5k | commit_urls listlengths 1 119 | created_at timestamp[s]date 2015-04-16 11:31:38 2025-12-17 10:26:03 | version stringclasses 196
values | language stringclasses 10
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Shopify/ruby-lsp | 572 | Shopify__ruby-lsp-572 | [
568
] | 5ceef5f80d0f7453d224880a1d8c58dc132eaa00 | diff --git a/lib/ruby_lsp/requests/inlay_hints.rb b/lib/ruby_lsp/requests/inlay_hints.rb
index b45b21ba31..c317a98ad9 100644
--- a/lib/ruby_lsp/requests/inlay_hints.rb
+++ b/lib/ruby_lsp/requests/inlay_hints.rb
@@ -37,7 +37,7 @@ def run
sig { override.params(node: SyntaxTree::Rescue).void }
def visit_re... | diff --git a/test/expectations/inlay_hints/def_rescue.exp.json b/test/expectations/inlay_hints/def_rescue.exp.json
new file mode 100644
index 0000000000..dcf0cbf1ae
--- /dev/null
+++ b/test/expectations/inlay_hints/def_rescue.exp.json
@@ -0,0 +1,13 @@
+{
+ "result": [
+ {
+ "position": {
+ ... | Rescue inlay hints do not appear when capturing a variable
This works
```ruby
begin
rescue # <- Shows StandardError inlay hint
end
```
This doesn't (but it should work the same)
```ruby
begin
rescue => e # <- This should also show a StandardError inlay hint right before the rocket operator
end
```
| [
"https://github.com/Shopify/ruby-lsp/commit/63c958dc77e4d785d7fe4dc92daf83fc5be98412"
] | 2023-03-23T14:57:58 | 0.2 | Ruby | ||
Shopify/ruby-lsp | 517 | Shopify__ruby-lsp-517 | [
515
] | c12dd2ace11288e7f5985e4c412b2a75e1695152 | diff --git a/lib/ruby_lsp/requests/folding_ranges.rb b/lib/ruby_lsp/requests/folding_ranges.rb
index f5b4022ac7..8ac9c16d92 100644
--- a/lib/ruby_lsp/requests/folding_ranges.rb
+++ b/lib/ruby_lsp/requests/folding_ranges.rb
@@ -115,7 +115,7 @@ def visit(node)
end
# This is to prevent duplicate ranges
- ... | diff --git a/test/expectations/folding_ranges/block_with_class_no_parens.exp.json b/test/expectations/folding_ranges/block_with_class_no_parens.exp.json
new file mode 100644
index 0000000000..b95bb529d0
--- /dev/null
+++ b/test/expectations/folding_ranges/block_with_class_no_parens.exp.json
@@ -0,0 +1,15 @@
+{
+ "re... | Spec blocks in RSpec files are not foldable
```
RSpec.describe SomeObject do
describe "#some_method" do
...
end
describe "#some_other_method" do
...
end
end
```
In the above code, only the main `RSpec.describe` block is foldable. The two nested `describe` blocks are not.
| Hi @amiratak88
I'm unable to reproduce this problem. I can fold the outer and inner `describe` blocks, as indicated by the markers here:
<img width="359" alt="Screenshot 2023-02-23 at 4 09 26 PM" src="https://user-images.githubusercontent.com/13400/221030880-2444231c-aa72-4d90-9430-5994bad01f5f.png">
Are you ... | Hi @amiratak88
I'm unable to reproduce this problem. I can fold the outer and inner `describe` blocks, as indicated by the markers here:
<img width="359" alt="Screenshot 2023-02-23 at 4 09 26 PM" src="https://user-images.githubusercontent.com/13400/221030880-2444231c-aa72-4d90-9430-5994bad01f5f.png">
Are you ... | [
"https://github.com/Shopify/ruby-lsp/commit/1818068cf8a57c2def592948d91cea4cd70e2b3c"
] | 2023-02-23T21:53:16 | 0.1 | Ruby |
Shopify/ruby-lsp | 1,285 | Shopify__ruby-lsp-1285 | [
1284
] | b492ae00b593b8a3ac26404bdbf5372bf6d06609 | diff --git a/lib/ruby_lsp/executor.rb b/lib/ruby_lsp/executor.rb
index ac112c9aa7..a598524984 100644
--- a/lib/ruby_lsp/executor.rb
+++ b/lib/ruby_lsp/executor.rb
@@ -247,11 +247,11 @@ def perform_initial_indexing
params(
uri: URI::Generic,
position: T::Hash[Symbol, T.untyped],
- context... | diff --git a/test/requests/signature_help_test.rb b/test/requests/signature_help_test.rb
index ec7c2637d5..9d779019aa 100644
--- a/test/requests/signature_help_test.rb
+++ b/test/requests/signature_help_test.rb
@@ -219,6 +219,37 @@ def baz
assert_equal(1, result.active_parameter)
end
+ def test_requests_miss... | Signature Help handler - context param can be nil
### Ruby version
3.2.2,3.3.0
### Code snippet
_No response_
### Description
Currently using https://github.com/ray-x/lsp_signature.nvim neovim plugin to show signature help, and it seems that ruby-lsp expects a context param (https://github.com/Shopify/ru... | 😍 so fast! Thanks @vinistock
| [
"https://github.com/Shopify/ruby-lsp/commit/4ba97820d75b723de17d567dcdcb13dce07e797b"
] | 2024-01-08T13:52:16 | 0.5 | Ruby | |
Shopify/ruby-lsp | 3,271 | Shopify__ruby-lsp-3271 | [
3172
] | 6f93d7bdbb2293031031e32c6c38ec18d3fd9f17 | diff --git a/lib/ruby_lsp/addon.rb b/lib/ruby_lsp/addon.rb
index 88e43fd2ab..537c277a0c 100644
--- a/lib/ruby_lsp/addon.rb
+++ b/lib/ruby_lsp/addon.rb
@@ -233,5 +233,10 @@ def create_definition_listener(response_builder, uri, node_context, dispatcher);
# @overridable
#: (ResponseBuilders::CollectionResponseBu... | diff --git a/lib/ruby_lsp/requests/discover_tests.rb b/lib/ruby_lsp/requests/discover_tests.rb
index 698cbb00bd..cbd4eeabe5 100644
--- a/lib/ruby_lsp/requests/discover_tests.rb
+++ b/lib/ruby_lsp/requests/discover_tests.rb
@@ -38,6 +38,11 @@ def perform
if @index.entries_for(uri.to_s)
Listeners::Tes... | Allow add-ons to enhance the new custom request
Add all of the necessary bits to allow add-ons to enhance the custom request added in #3171 to discovery test items.
For example, the Rails and RSpec add-ons should be able to enhance our functionality and discover their own groups and examples with full control over the... | [
"https://github.com/Shopify/ruby-lsp/commit/20510638b69e282157b09a31b0a2c9e2a154213f"
] | 2025-03-05T01:53:59 | 0.6 | Ruby | ||
Shopify/ruby-lsp | 1,003 | Shopify__ruby-lsp-1003 | [
1673
] | 74da159fad6a1ba4fd14b3f7bd9867e2b26b6ab8 | diff --git a/lib/ruby_indexer/lib/ruby_indexer/index.rb b/lib/ruby_indexer/lib/ruby_indexer/index.rb
index f467b197ff..cf26b89a48 100644
--- a/lib/ruby_indexer/lib/ruby_indexer/index.rb
+++ b/lib/ruby_indexer/lib/ruby_indexer/index.rb
@@ -167,12 +167,16 @@ class Entry
sig { returns(T::Array[String]) }
att... | diff --git a/lib/ruby_indexer/test/classes_and_modules_test.rb b/lib/ruby_indexer/test/classes_and_modules_test.rb
index e3e3458baa..6079ebb426 100644
--- a/lib/ruby_indexer/test/classes_and_modules_test.rb
+++ b/lib/ruby_indexer/test/classes_and_modules_test.rb
@@ -216,5 +216,28 @@ class Bar; end
second_foo_ent... | Changelog on VSCode Marketplace include pre-release versions
### Operating System
macOS
### Ruby version
3.2.3
### Project has a bundle
- [ ] Has bundle
### Ruby version manager being used
asdf
### Description
The changelog shown in the extension detail page in VSCode contains the pre-release versions.
For ... | Thank you for the report, we'll look into fixing this.
Hello @andyw8, we could add a filter here:
https://github.com/Shopify/vscode-ruby-lsp/blob/92d0d621de7cd0affd712b926e752ce0039a4a9a/.github/workflows/publish.yml#L36-L38
Following [API documentation](https://docs.github.com/en/rest/releases/releases?apiVersi... | [
"https://github.com/Shopify/ruby-lsp/commit/eae8b7befa8b0eb25a047261747127a4ce41c10e"
] | 2023-09-14T12:52:51 | 0.4 | Ruby | |
basecamp/kamal | 476 | basecamp__kamal-476 | [
430
] | 6b0f93a564eec900e836de654865944ce4377f12 | diff --git a/lib/kamal/cli/app.rb b/lib/kamal/cli/app.rb
index 6ba8908ae..601d485e6 100644
--- a/lib/kamal/cli/app.rb
+++ b/lib/kamal/cli/app.rb
@@ -115,14 +115,16 @@ def exec(cmd)
say "Get current version of running container...", :magenta unless options[:version]
using_version(options[:version] || curre... | diff --git a/test/cli/app_test.rb b/test/cli/app_test.rb
index ba58d6074..c70b8ed49 100644
--- a/test/cli/app_test.rb
+++ b/test/cli/app_test.rb
@@ -170,6 +170,25 @@ class CliAppTest < CliTestCase
end
end
+ test "exec interactive" do
+ SSHKit::Backend::Abstract.any_instance.expects(:exec)
+ .with("ss... | kamal app exec -r "job" leads to "No such container"
Hey,
I discovered that the wrong container is executed when running `kamal app exec` on the container with the `job` role (as opposed to the `app` role) with or without the `--reuse` parameter. Specifically, the container with the `-web-` part in its name is run in... | [
"https://github.com/basecamp/kamal/commit/0861730e0e5bd59df9b871b9be3b421c3798e5dc"
] | 2023-09-18T11:01:56 | 1.0 | Ruby | ||
basecamp/kamal | 779 | basecamp__kamal-779 | [
777
] | d475e88dbee72dd97bd6217578976339b8402d58 | diff --git a/lib/kamal/commands/base.rb b/lib/kamal/commands/base.rb
index 8c289ae0b..824047839 100644
--- a/lib/kamal/commands/base.rb
+++ b/lib/kamal/commands/base.rb
@@ -18,7 +18,7 @@ def run_over_ssh(*command, host:)
elsif config.ssh.proxy && config.ssh.proxy.is_a?(Net::SSH::Proxy::Command)
cmd ... | diff --git a/test/cli/app_test.rb b/test/cli/app_test.rb
index ab0eff51f..dabd2ccda 100644
--- a/test/cli/app_test.rb
+++ b/test/cli/app_test.rb
@@ -218,9 +218,9 @@ class CliAppTest < CliTestCase
test "logs with follow" do
SSHKit::Backend::Abstract.any_instance.stubs(:exec)
- .with("ssh -t root@1.1.1.1 -... | App logs with follow option does not work after upgrade to 1.5
Having the command:
`bin/kamal app logs -r web -f`
It worked fine on kamal 1.4.0, thus giving output:
```
INFO Following logs on i-0d1a6eb781c5d3ad2...
INFO ssh -o ProxyCommand='aws ssm start-session --target %h --document-name AWS-StartSSHSession ... | Thanks @morgoth - looks like it was generally broken and nothing to do with your specific config. Fixed in https://github.com/basecamp/kamal/pull/779
I've released v1.5.1, could you confirm that it's fixed for you now @morgoth?
It works. Thank you
| Thanks @morgoth - looks like it was generally broken and nothing to do with your specific config. Fixed in https://github.com/basecamp/kamal/pull/779
I've released v1.5.1, could you confirm that it's fixed for you now @morgoth?
It works. Thank you
| [
"https://github.com/basecamp/kamal/commit/1f5b936fa2133db174bc8bdd9c9e1b56c79c55ab"
] | 2024-04-26T13:17:08 | 1.5 | Ruby |
basecamp/kamal | 1,308 | basecamp__kamal-1308 | [
1307
] | 1547089da044159a934f1ef90006ae10e599d687 | diff --git a/lib/kamal/cli/main.rb b/lib/kamal/cli/main.rb
index 5fdb5469a..b06a34477 100644
--- a/lib/kamal/cli/main.rb
+++ b/lib/kamal/cli/main.rb
@@ -9,6 +9,9 @@ def setup
say "Ensure Docker is installed...", :magenta
invoke "kamal:cli:server:bootstrap", [], invoke_options
+ say "Ensure ka... | diff --git a/test/cli/main_test.rb b/test/cli/main_test.rb
index cd0efe1f8..8a439c49d 100644
--- a/test/cli/main_test.rb
+++ b/test/cli/main_test.rb
@@ -8,6 +8,7 @@ class CliMainTest < CliTestCase
invoke_options = { "config_file" => "test/fixtures/deploy_simple.yml", "version" => "999", "skip_hooks" => false }
... | [2.4.0] First time `kamal setup` fails when an accessory has `proxy:` section
Setting up kamal with `kamal setup` on a brand new Ubuntu VM (hetzner), fails with `No such container: kamal-proxy`
It looks like `setup` command is not running `kamal:cli:proxy:boot` before booting accessories. should that now be executed... | [
"https://github.com/basecamp/kamal/commit/c56edba4a94a82dc38d238b0cfa6117486acab76"
] | 2024-12-18T10:50:19 | 2.4 | Ruby | ||
basecamp/kamal | 1,020 | basecamp__kamal-1020 | [
1006
] | 7b48648bf2a380bfb44f89d357cf5ec975c7b18b | diff --git a/lib/kamal/commands/accessory.rb b/lib/kamal/commands/accessory.rb
index 0c1b9009c..9abb6dfc0 100644
--- a/lib/kamal/commands/accessory.rb
+++ b/lib/kamal/commands/accessory.rb
@@ -1,7 +1,7 @@
class Kamal::Commands::Accessory < Kamal::Commands::Base
attr_reader :accessory_config
delegate :service_nam... | diff --git a/test/commands/accessory_test.rb b/test/commands/accessory_test.rb
index f3d71ffd3..1befd9e64 100644
--- a/test/commands/accessory_test.rb
+++ b/test/commands/accessory_test.rb
@@ -71,6 +71,14 @@ class CommandsAccessoryTest < ActiveSupport::TestCase
new_command(:busybox).run.join(" ")
end
+ tes... | Allow overriding custom `kamal` network
hey 👋🏻
I'm running a couple of accessories that require host network mode and since v2, Kamnal forces the usage of custom `kamal` network.
Is there any chance to make this option configurable? These containers do not run behind a proxy anyway so there's no need for them ... | According to the upgrade guide, the recommendation for customizing the network is to use the `docker-setup` hook. https://kamal-deploy.org/docs/upgrading/network-changes/
then I would need to create a network called “kamal” with host access, which is far from ideal. i dont want all containers with host access, nor have... | According to the upgrade guide, the recommendation for customizing the network is to use the `docker-setup` hook. https://kamal-deploy.org/docs/upgrading/network-changes/
then I would need to create a network called “kamal” with host access, which is far from ideal. i dont want all containers with host access, nor have... | [
"https://github.com/basecamp/kamal/commit/f04cae529abfdf5b4a1930b804eced4a84db34ed",
"https://github.com/basecamp/kamal/commit/c917dd82cf93c123c2e6afe78651bfe5df9bfd08",
"https://github.com/basecamp/kamal/commit/b6a10df56aaff503edf5acb9389138ea39f60efe",
"https://github.com/basecamp/kamal/commit/08dacd2745836... | 2024-10-01T16:31:47 | 2.2 | Ruby |
basecamp/kamal | 507 | basecamp__kamal-507 | [
453
] | 8f53104d00eae6132760428dde1a03c3e22595ea | diff --git a/lib/kamal/configuration/accessory.rb b/lib/kamal/configuration/accessory.rb
index 50592b316..8fdcd2276 100644
--- a/lib/kamal/configuration/accessory.rb
+++ b/lib/kamal/configuration/accessory.rb
@@ -70,8 +70,8 @@ def files
def directories
specifics["directories"]&.to_h do |host_to_container_mapp... | diff --git a/test/configuration/accessory_test.rb b/test/configuration/accessory_test.rb
index 6a250b176..522dc6311 100644
--- a/test/configuration/accessory_test.rb
+++ b/test/configuration/accessory_test.rb
@@ -149,10 +149,16 @@ class ConfigurationAccessoryTest < ActiveSupport::TestCase
assert_match "%", @config... | Accessory Data: Directories vs Volumes
I would like to store my accessories data in a dedicated `/var/` directory.
The are two options to mount accessories data: [Volumes](https://kamal-deploy.org/docs/configuration#using-volumes) and [Directories](https://kamal-deploy.org/docs/configuration#using-directories). The ... | I'd be happy to see a patch where directories declared with a leading / don't add PWD but still create the directory 👍
| I'd be happy to see a patch where directories declared with a leading / don't add PWD but still create the directory 👍
I think we should implement the same absolute directory path to [Copying Files](https://kamal-deploy.org/docs/configuration/accessories/#copying-files).
| [
"https://github.com/basecamp/kamal/commit/f3396266670af5db45952fa20ec4e6ab36ee3baf"
] | 2023-10-01T12:57:10 | 1.1 | Ruby |
ruby/rubygems | 6,471 | ruby__rubygems-6471 | [
6467
] | d57d302cbb265f5164b0bc448191e9beec257c43 | diff --git a/lib/rubygems/gem_runner.rb b/lib/rubygems/gem_runner.rb
index 8335a0ad03fc..4cb924677f83 100644
--- a/lib/rubygems/gem_runner.rb
+++ b/lib/rubygems/gem_runner.rb
@@ -29,6 +29,7 @@ def initialize
# Run the gem command with the following arguments.
def run(args)
+ validate_encoding args
build... | diff --git a/test/rubygems/test_gem_gem_runner.rb b/test/rubygems/test_gem_gem_runner.rb
index c05e74c991e5..4fb205040c33 100644
--- a/test/rubygems/test_gem_gem_runner.rb
+++ b/test/rubygems/test_gem_gem_runner.rb
@@ -54,6 +54,12 @@ def test_do_configuration
assert_equal %w[--commands], Gem::Command.extra_args
... | [Slightly confusing error message] linked to incompatible W���U - /root/.gem/gems/digest-3.1.1/lib/digest.so (LoadError)
So let me first explain the background situation.
I have had some unrelated issues with openssl (on linux) and decided to start anew and recompile
ruby (latest stable ruby always, so ruby 3.2.1).... | @rubyFeedback It sounds like you have some encoding issues in your system. We can add a better message so that RubyGems does not crash like that like I did at #6471, but I suspect you're going to have issues with other programs too until you fix the root cause.
| @rubyFeedback It sounds like you have some encoding issues in your system. We can add a better message so that RubyGems does not crash like that like I did at #6471, but I suspect you're going to have issues with other programs too until you fix the root cause.
| [
"https://github.com/ruby/rubygems/commit/516024869e5072e8a79eca5cab8514115cdee9c9"
] | 2023-03-13T13:21:10 | 1.0 | Ruby |
ruby/rubygems | 8,007 | ruby__rubygems-8007 | [
8004
] | fae9a449713476b92c3bbed04c738b3254808307 | diff --git a/lib/rubygems/commands/fetch_command.rb b/lib/rubygems/commands/fetch_command.rb
index f7f5b62306a5..c524cf792293 100644
--- a/lib/rubygems/commands/fetch_command.rb
+++ b/lib/rubygems/commands/fetch_command.rb
@@ -63,6 +63,17 @@ def check_version # :nodoc:
def execute
check_version
+
+ exit_co... | diff --git a/test/rubygems/test_gem_commands_fetch_command.rb b/test/rubygems/test_gem_commands_fetch_command.rb
index e8710d3cd130..bd8f8aa4f921 100644
--- a/test/rubygems/test_gem_commands_fetch_command.rb
+++ b/test/rubygems/test_gem_commands_fetch_command.rb
@@ -21,11 +21,7 @@ def test_execute
@cmd.options[:... | `gem fetch` always reports success even when it fails
### Describe the problem as clearly as you can
I expect the `gem` CLI to exit with non-zero (i.e. failure) status when it runs a command that fails. This works as expected with some commands like `gem install`:
```
$ gem install this-is-not-a-gem && echo 'suc... | #8007 should fix this. I did not audit other commands though.
| #8007 should fix this. I did not audit other commands though.
| [
"https://github.com/ruby/rubygems/commit/5887e6dfa1b0f505577c0aa8bbac1cd6f4a95fb2"
] | 2024-09-06T09:57:08 | 1.0 | Ruby |
ruby/rubygems | 7,205 | ruby__rubygems-7205 | [
6038
] | 46585225c34676d605daad05604a0dde11623509 | diff --git a/Manifest.txt b/Manifest.txt
index ead5a06ffa3c..a2f76f875c31 100644
--- a/Manifest.txt
+++ b/Manifest.txt
@@ -20,6 +20,7 @@ bundler/lib/bundler/.document
bundler/lib/bundler/build_metadata.rb
bundler/lib/bundler/capistrano.rb
bundler/lib/bundler/checksum.rb
+bundler/lib/bundler/ci_detector.rb
bundler/l... | diff --git a/test/rubygems/test_gem_ci_detector.rb b/test/rubygems/test_gem_ci_detector.rb
new file mode 100644
index 000000000000..3caefce97d72
--- /dev/null
+++ b/test/rubygems/test_gem_ci_detector.rb
@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require_relative "helper"
+require "rubygems"
+
+class TestCiDetec... | Consolidate ENV list for CI detection
We currently have two different list of environment variables for CI detection. One used by Bundler to include the CI where it's running with request headers, so that we can later on extract metrics. Another one introduced in RubyGems to be able to avoid needless call for updates m... | Some of this data is pretty out of date too. BuildKite deprecated their BUILDBOX envs a year ago, and Snap CI went under in 2017. I'll document the provenance of each of the envs while I'm in here.
| Some of this data is pretty out of date too. BuildKite deprecated their BUILDBOX envs a year ago, and Snap CI went under in 2017. I'll document the provenance of each of the envs while I'm in here.
| [
"https://github.com/ruby/rubygems/commit/60652b942f71a08f8116033bbeb7437dfc75120b",
"https://github.com/ruby/rubygems/commit/e5b045834263a2924c19bded0e2b796c954aa824",
"https://github.com/ruby/rubygems/commit/abc67f0da105198ed100e1f5f87136e996281e24",
"https://github.com/ruby/rubygems/commit/3fb445a5a1d78607f... | 2023-11-29T03:01:38 | 1.0 | Ruby |
ruby/rubygems | 8,083 | ruby__rubygems-8083 | [
8082
] | 6ea020eecdaf8a302c3dc191c5d30390db98a08f | diff --git a/lib/rubygems/spec_fetcher.rb b/lib/rubygems/spec_fetcher.rb
index 610edf25c921..9c0399f19653 100644
--- a/lib/rubygems/spec_fetcher.rb
+++ b/lib/rubygems/spec_fetcher.rb
@@ -176,19 +176,12 @@ def suggest_gems_from_name(gem_name, type = :latest, num_results = 5)
matches = names.map do |n|
next... | diff --git a/test/rubygems/test_gem_commands_exec_command.rb b/test/rubygems/test_gem_commands_exec_command.rb
index fd48ce73ca33..c632ce62b2d5 100644
--- a/test/rubygems/test_gem_commands_exec_command.rb
+++ b/test/rubygems/test_gem_commands_exec_command.rb
@@ -493,7 +493,6 @@ def test_version_mismatch
assert_e... | Nonsense results from `gem install <nonexistent gem>` in some cases
<!--
Thank you for contributing to the
[rubygems](https://github.com/rubygems/rubygems) repository, and specifically to
[RubyGems](https://guides.rubygems.org/).
-->
### Describe the problem as clearly as you can
<!--
Replace this with... | [
"https://github.com/ruby/rubygems/commit/09ec67ffdf2cc4d67c4dcf14b099b74702305597",
"https://github.com/ruby/rubygems/commit/e7d6b92e318da2bc07e4ee120bd6ccb7e943da01",
"https://github.com/ruby/rubygems/commit/6e0456583b27d781d2becf336bf2d6364f387709"
] | 2024-09-28T01:22:43 | 1.0 | Ruby | ||
ruby/rubygems | 8,006 | ruby__rubygems-8006 | [
6821
] | b7ac56c5d2d73c4ebaae3171df281a3c210330af | diff --git a/lib/rubygems/commands/install_command.rb b/lib/rubygems/commands/install_command.rb
index 2091634a2912..2888b6c55a83 100644
--- a/lib/rubygems/commands/install_command.rb
+++ b/lib/rubygems/commands/install_command.rb
@@ -224,10 +224,6 @@ def install_gems # :nodoc:
rescue Gem::InstallError => e
... | diff --git a/test/rubygems/test_gem_resolver_best_set.rb b/test/rubygems/test_gem_resolver_best_set.rb
index 8a750cdf8fd6..02f542efc079 100644
--- a/test/rubygems/test_gem_resolver_best_set.rb
+++ b/test/rubygems/test_gem_resolver_best_set.rb
@@ -9,33 +9,17 @@ def test_initialize
assert_empty set.sets
end
- ... | `gem install <gem-that-does-not-exist>` is very slow
### Describe the problem as clearly as you can
Not a huge issue but `gem install <gem-that-does-not-exist>` is very slow, unnecessarily.
### Did you try upgrading RubyGems?
Yes.
### Post steps to reproduce the problem
```
$ time sudo gem install --deb... | It's not _as bad_ on my system, but it's 20-23 seconds for a nonexistent gem vs ~1s for an existent gem (in my case, I went with `time gem install --debug --verbose boop` since it has no dependencies).
---
Times for running `time gem install --debug --verbose pony-gem` on my FreeBSD 13.1 system, with different Ru... | It's not _as bad_ on my system, but it's 20-23 seconds for a nonexistent gem vs ~1s for an existent gem (in my case, I went with `time gem install --debug --verbose boop` since it has no dependencies).
---
Times for running `time gem install --debug --verbose pony-gem` on my FreeBSD 13.1 system, with different Ru... | [
"https://github.com/ruby/rubygems/commit/3b824ca7a61dbdf3eb677bc81e2867fbf6e4c977",
"https://github.com/ruby/rubygems/commit/a6271a0b2169f2293ff084c5d9db0534f27bf2a0",
"https://github.com/ruby/rubygems/commit/282dbb3d62b11cd085195f175598168ceb7be2bf",
"https://github.com/ruby/rubygems/commit/c0d6b9eea79147b5b... | 2024-09-06T09:16:58 | 1.0 | Ruby |
puma/puma | 3,209 | puma__puma-3209 | [
2580
] | 2563396f730adef54a9369dbae996fda3bba5f6e | diff --git a/lib/puma/cli.rb b/lib/puma/cli.rb
index 55ac41a143..ba423b4d9d 100644
--- a/lib/puma/cli.rb
+++ b/lib/puma/cli.rb
@@ -144,6 +144,10 @@ def setup_options
$LOAD_PATH.unshift(*arg.split(':'))
end
+ o.on "--idle-timeout SECONDS", "Number of seconds until the next request befo... | diff --git a/test/test_integration_single.rb b/test/test_integration_single.rb
index ab0f2024b8..bff32aa4bb 100644
--- a/test/test_integration_single.rb
+++ b/test/test_integration_single.rb
@@ -254,4 +254,28 @@ def test_puma_debug_loaded_exts
cli_pumactl 'stop'
end
+
+ def test_pre_existing_unix_after_idle_... | Support for shutdown on idle
**Is your feature request related to a problem? Please describe.**
In order to reduce resource consumption, infrequently utilised Rails/Rack apps should not occupy memory when they are not actively used. Socket activation, which Puma already supports, solves part of this; applications can ... | This sounds interesting but it's not clear to me yet in what configuration/platform where this would make sense. I'd love to learn about examples of where/when to use this.
@dfuentes77 Take a look at [fly.io's docs](https://fly.io/docs/apps/autostart-stop/#stop-a-machine-by-terminating-its-main-process) on "stopping a... | [
"https://github.com/puma/puma/commit/4f25af5add50ec5ba30002cf54fa2f49ac7a5db8",
"https://github.com/puma/puma/commit/272f2c6b2b1c55cc8a000309f58eedf94ac86430",
"https://github.com/puma/puma/commit/3e5d42ffdb1810c65a188000af7ddcfad9178e78",
"https://github.com/puma/puma/commit/23fc9b2d1c49a64ebdd9f36dcd8c9c22d... | 2023-08-12T11:19:50 | 0.0 | Ruby | |
puma/puma | 3,225 | puma__puma-3225 | [
2786
] | c4e08688fe30ae3568d4db1513a80eb638bd59bc | diff --git a/lib/puma/cluster.rb b/lib/puma/cluster.rb
index 39078b848d..c5edc3e90c 100644
--- a/lib/puma/cluster.rb
+++ b/lib/puma/cluster.rb
@@ -85,9 +85,7 @@ def spawn_workers
@workers << WorkerHandle.new(idx, pid, @phase, @options)
end
- if @options[:fork_worker] &&
- @workers.all? {|x... | diff --git a/test/helper.rb b/test/helper.rb
index 00715028d0..43a4a7a361 100644
--- a/test/helper.rb
+++ b/test/helper.rb
@@ -78,7 +78,7 @@ def self.call(host = '127.0.0.1')
require "timeout"
module TimeoutEveryTestCase
- # our own subclass so we never confused different timeouts
+ # our own subclass so we never... | `fork_worker` worker termination during phased-restart
**Describe the bug**
During `phased-restart`, while running with `fork_worker` option, worker 0 stops to receive **ping** message. While the puma process is running, constantly we are doing `timeout_workers`, which checks if workers are responding. Because worke... | Sounds like https://github.com/puma/puma/issues/2470
See https://github.com/puma/puma/issues/2470#issuecomment-724951500 for a workaround
Yes, it might be related. But `workaround` in this case might just hide other problems.
Do you have an idea, why we trigger server restart for the base worker (Worker 0) only... | Sounds like https://github.com/puma/puma/issues/2470
See https://github.com/puma/puma/issues/2470#issuecomment-724951500 for a workaround
Yes, it might be related. But `workaround` in this case might just hide other problems.
Do you have an idea, why we trigger server restart for the base worker (Worker 0) only... | [
"https://github.com/puma/puma/commit/8409db3a8c5e7ecd019874977464758275ce393f",
"https://github.com/puma/puma/commit/ad1c2e51d1fe949bcd2adef9545ab5379e5087c4",
"https://github.com/puma/puma/commit/ef467fd2bf88e30f639151f60861e56ada51c77a",
"https://github.com/puma/puma/commit/783dcde7292daa210293a9500e3d13954... | 2023-09-15T00:23:46 | 0.0 | Ruby |
puma/puma | 3,174 | puma__puma-3174 | [
3172
] | 188f5da1920ff99a8689b3e9b46f2f26b7c62d66 | diff --git a/examples/puma/chain_cert/ca.crt b/examples/puma/chain_cert/ca.crt
new file mode 100644
index 0000000000..a5ae2d7b45
--- /dev/null
+++ b/examples/puma/chain_cert/ca.crt
@@ -0,0 +1,19 @@
+-----BEGIN CERTIFICATE-----
+MIIDKDCCAhCgAwIBAgIBATANBgkqhkiG9w0BAQ0FADAcMRowGAYDVQQDDBFjYS5w
+dW1hLmxvY2FsaG9zdDAeFw0yMz... | diff --git a/examples/puma/chain_cert/generate_chain_test.rb b/examples/puma/chain_cert/generate_chain_test.rb
new file mode 100644
index 0000000000..31c215e6b0
--- /dev/null
+++ b/examples/puma/chain_cert/generate_chain_test.rb
@@ -0,0 +1,129 @@
+# frozen_string_literal: true
+
+=begin
+regenerates ca.pem, ca_keypair.... | Inconsistency between cert: and cert_pem: parameters to ssl_bind
## Describe the bug
When using `ssl_bind` the documentation seems to indicate that the following are equivalent:
**File based certs/keys**
https://github.com/puma/puma/blob/763d1a1a971d9bb17fc1478859d626a539c29970/lib/puma/dsl.rb#L513-L520
**St... | If I recall, there has never been parity between 'file based' and 'string based' functions.
Or, as you've mentioned, there are two 'file based' functions that will process multiple certs, but there are not equivalent string functions. I.think.
So, not sure what to do. The docs could be improved. I can't seriou... | If I recall, there has never been parity between 'file based' and 'string based' functions.
Or, as you've mentioned, there are two 'file based' functions that will process multiple certs, but there are not equivalent string functions. I.think.
So, not sure what to do. The docs could be improved. I can't seriou... | [
"https://github.com/puma/puma/commit/282347652f2c0612b7d97b83f17a38bfb44eeb5c",
"https://github.com/puma/puma/commit/64e2354ab0ee17082f025db553f7fac33ee16c7f",
"https://github.com/puma/puma/commit/16e43ee8d08ddf1ab41fa31c30a1463b3254ab16",
"https://github.com/puma/puma/commit/9210f365fa588ed3ae594f189a86c7756... | 2023-06-03T07:09:49 | 0.0 | Ruby |
puma/puma | 3,094 | puma__puma-3094 | [
2341
] | b2610b3ed75418cd5f7858390f753d9a9f62bd7c | diff --git a/lib/puma/server.rb b/lib/puma/server.rb
index 87da8aa45a..807213a008 100644
--- a/lib/puma/server.rb
+++ b/lib/puma/server.rb
@@ -476,7 +476,7 @@ def process_client(client)
end
true
rescue StandardError => e
- client_error(e, client)
+ client_error(e, client, requests... | diff --git a/test/test_puma_server.rb b/test/test_puma_server.rb
index 297d44ab28..fd6cbc800a 100644
--- a/test/test_puma_server.rb
+++ b/test/test_puma_server.rb
@@ -1695,4 +1695,19 @@ def spawn_cmd(env = {}, cmd)
[out_w, err_w].each(&:close)
[out_r, err_r, pid]
end
+
+ def test_lowlevel_error_handler_re... | Puma sends empty response bodies even when low-level handler is specified
**Describe the bug**
Puma's README [describes the `lowlevel_error_handler` as a way to specify how Puma should react in error conditions outside of the context of your application][0]. Specifically, the docs show that you can return a Rack res... | @cjlarose did you start on this? would be useful to be able to rescue `Puma::HttpParserError`s IMHO and not have Puma log them (the requests are most often abuse)
Haven't started on this myself. I think when I wrote it up originally, my team was actually finding that puma was giving 5xx error responses to some machine ... | @cjlarose did you start on this? would be useful to be able to rescue `Puma::HttpParserError`s IMHO and not have Puma log them (the requests are most often abuse)
Haven't started on this myself. I think when I wrote it up originally, my team was actually finding that puma was giving 5xx error responses to some machine ... | [
"https://github.com/puma/puma/commit/d56e8cb1d7ae6ef26c40d522881e1cb0a5ab32ac"
] | 2023-03-12T16:52:28 | 0.0 | Ruby |
puma/puma | 3,713 | puma__puma-3713 | [
3617
] | 1acac470543a8892fa921c98f61118edfa24cfa0 | diff --git a/lib/puma/error_logger.rb b/lib/puma/error_logger.rb
index 792e14a6ae..ed70204b17 100644
--- a/lib/puma/error_logger.rb
+++ b/lib/puma/error_logger.rb
@@ -78,10 +78,12 @@ def request_dump(req)
def request_title(req)
env = req.env
+ query_string = env[QUERY_STRING]
+
REQUEST_FORMAT ... | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 9322b94680..8014afe653 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -48,12 +48,12 @@ jobs:
include:
- { os: windows-2022 , ruby: ucrt }
- { os: windows-2022 , ruby: mswin ... | Puma::ErrorLogger: missing "?" when logging requests with a query string
```diff
diff --git a/lib/puma/error_logger.rb b/lib/puma/error_logger.rb
index 792e14a6..a12fba67 100644
--- a/lib/puma/error_logger.rb
+++ b/lib/puma/error_logger.rb
@@ -78,13 +78,13 @@ module Puma
def request_title(req)
env = req.env... | [
"https://github.com/puma/puma/commit/d36afcb0a120bb5777f6158436a6e4376e6f6d9a",
"https://github.com/puma/puma/commit/dba0b7178a9dad9134cc37653146c41866af7351",
"https://github.com/puma/puma/commit/c517c85e78946d74e5253472d2c393c19c1d968f",
"https://github.com/puma/puma/commit/1c5fa5139bb46102fa156a24790bdb1f1... | 2025-08-28T17:57:13 | 0.0 | Ruby | ||
rack/rack | 2,324 | rack__rack-2324 | [
2323
] | 4f15e7b814922af79605be4b02c5b7c3044ba206 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c9dc88f3..2e5e0c918 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -39,6 +39,10 @@ All notable changes to this project will be documented in this file. For info on
- Fix the specification for `SERVER_PORT` which was incorrectly documented as required to be an `Integer` ... | diff --git a/test/spec_etag.rb b/test/spec_etag.rb
index e1670dfa5..75eb399cf 100644
--- a/test/spec_etag.rb
+++ b/test/spec_etag.rb
@@ -28,6 +28,16 @@ def sendfile_body
response[1]['etag'].must_equal "W/\"dffd6021bb2bd5b0af676290809ec3a5\""
end
+ it "returns a valid response body when using a linted app" do... | Mounted Grape App -> Rack::Lint::LintError: Response body is already closed
Hi 👋,
I'm working on a feature to add `linting` in [Grape](https://github.com/ruby-grape/grape) by adding `Rack::Lint` in the stack. It works well but I'm encountering a `Rack::Lint::LintError: Response body is already closed` when a Grape AP... | Thanks for your report. Wow, this bug has existed for a long time. Introduced in https://github.com/rack/rack/pull/1887
Looks like we do all the right things except we don't return the right body. Whoops.
| Thanks for your report. Wow, this bug has existed for a long time. Introduced in https://github.com/rack/rack/pull/1887
Looks like we do all the right things except we don't return the right body. Whoops.
| [
"https://github.com/rack/rack/commit/938aaa30d8efe6d2ac1aac89b7eca9f9e4041118"
] | 2025-04-12T22:36:39 | 1.6 | Ruby |
rack/rack | 2,298 | rack__rack-2298 | [
2295
] | 9b21ee83ab8d12322b649804fdc695db3b2ef68f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a3d13440d..2cd91f869 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,7 @@ All notable changes to this project will be documented in this file. For info on
- `Rack::RewindableInput::Middleware` no longer wraps a nil input. ([#2259](https://github.com/rack/rack/pu... | diff --git a/test/spec_lint.rb b/test/spec_lint.rb
index db5cd8991..44855c555 100644
--- a/test/spec_lint.rb
+++ b/test/spec_lint.rb
@@ -191,12 +191,12 @@ def obj.fatal(*) end
lambda {
Rack::Lint.new(valid_app).call(env("SERVER_NAME" => "A Host"))
}.must_raise(Rack::Lint::LintError).
- message.mus... | `Rack::Lint` `SERVER_NAME` and `HTTP_HOST` are insufficiently validated?
When we use `URI.parse("http://#{http_host}/")`, we assume that `http_host` holds a valid, sanitized hostname. However, `URI.parse` is fairly permissive in what it accepts. This can lead to unexpected (and potentially unsafe) behavior if `http_hos... | We can change the check to use `URI#host=`:
```
uri = URI("http://")
uri.host = "user:pass@evil.com" # URI::InvalidComponentError
# same for example.com:8080/path/to/endpoint
# same for example.com?foo=bar#frag
```
What about going direct to the source:
```
> URI::RFC3986_Parser::HOST
=>
/
(?<IP-literal>\[(?:... | We can change the check to use `URI#host=`:
```
uri = URI("http://")
uri.host = "user:pass@evil.com" # URI::InvalidComponentError
# same for example.com:8080/path/to/endpoint
# same for example.com?foo=bar#frag
```
What about going direct to the source:
```
> URI::RFC3986_Parser::HOST
=>
/
(?<IP-literal>\[(?:... | [
"https://github.com/rack/rack/commit/be0299c60a45fe1d2035ab3ff5b5bf52939d3997"
] | 2025-02-25T00:15:49 | 1.6 | Ruby |
rack/rack | 2,077 | rack__rack-2077 | [
2076
] | ab360dd5ba16361c562bdf482af8ab14141807a6 | diff --git a/lib/rack/multipart/parser.rb b/lib/rack/multipart/parser.rb
index cb33292eb..f10d18322 100644
--- a/lib/rack/multipart/parser.rb
+++ b/lib/rack/multipart/parser.rb
@@ -32,28 +32,9 @@ class BoundaryTooLongError < StandardError
EOL = "\r\n"
MULTIPART = %r|\Amultipart/.*boundary=\"?([^\";,]+)\"?|n... | diff --git a/test/spec_multipart.rb b/test/spec_multipart.rb
index d5ebe7170..c36fe50ca 100644
--- a/test/spec_multipart.rb
+++ b/test/spec_multipart.rb
@@ -231,6 +231,86 @@ def rd.rewind; end
Timeout::timeout(10) { Rack::Multipart.parse_multipart(env) }
end
+ content_disposition_parse = lambda do |params|
+... | Parsing uploaded file parameter name from Content-Disposition header fails 2.2.6.3 update
There's a fix for ReDos vulnerability in
https://github.com/rack/rack/commit/ee25ab9a7ee981d7578f559701085b0cf39bde77
which breaks the Content-Disposition parameter name parsing in case header contains extra attributes like m... | [
"https://github.com/rack/rack/commit/645b5b4c96ba98db261a0890117083d6faa9572b"
] | 2023-04-28T20:43:05 | 1.6 | Ruby | ||
rack/rack | 2,203 | rack__rack-2203 | [
2201
] | d40896dc57216a1e39dcc3e39ba1a9d53a8d16ea | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0e6e216a1..7b1973844 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file. For info on
### Fixed
- Fix passing non-strings to `Rack::Utils.escape_html`. ([#2202](https://github.com/rack/rack/pu... | diff --git a/test/spec_mock_response.rb b/test/spec_mock_response.rb
index d1397d5f7..7d30479ee 100644
--- a/test/spec_mock_response.rb
+++ b/test/spec_mock_response.rb
@@ -49,7 +49,7 @@
response.body.must_equal body.join
end
- it "provide access to the HTTP status" do
+ it "provides access to the HTTP stat... | MockRequest can't handle an empty cookie anymore
Executing
```ruby
Rack::MockRequest.new(->(env) { [200, { "Set-Cookie" => "" }, [""]] }).get("")
```
will fail with
> NoMethodError: undefined method `split' for nil
from /Users/foobar/.rbenv/versions/3.3.2/lib/ruby/gems/3.3.0/gems/rack-3.1.0/lib/rack/mock_response... | Are you able to submit a PR? Thanks :)
> Are you able to submit a PR? Thanks :)
Give me a few hours 👍
| Are you able to submit a PR? Thanks :)
> Are you able to submit a PR? Thanks :)
Give me a few hours 👍
| [
"https://github.com/rack/rack/commit/62fe653820edf58869d68c2a48bdb567d5a78316",
"https://github.com/rack/rack/commit/3cb9230079efa662f77537ef54dea8b3e2453157",
"https://github.com/rack/rack/commit/2d8ff3f6b2e55a66260e2a0744836abd01ae4720",
"https://github.com/rack/rack/commit/8085e6627e6c2d5876bcdb5f7f6ea4c54... | 2024-06-11T14:55:45 | 1.6 | Ruby |
rack/rack | 2,318 | rack__rack-2318 | [
2317
] | 1b6851355166923ab18b7ff928251bd7c9ddf12d | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4b17e8ac3..8c9dc88f3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file. For info on
### SPEC Changes
- Request environment keys must now be strings. [#2310](https://github.com/rack/rack/issu... | diff --git a/test/spec_lint.rb b/test/spec_lint.rb
index 41c46495e..f3d878810 100644
--- a/test/spec_lint.rb
+++ b/test/spec_lint.rb
@@ -607,6 +607,17 @@ def body.to_path; __FILE__ end
body.to_path.must_equal __FILE__
end
+ it "handles body.to_path returning nil" do
+ body = Object.new
+ def body.each;... | Rack::Lint warning for invalid to_path might not work
There is supposed to be a check for a body responding to `to_path` but not returning a valid path.
Pipes return `nil` for `to_path` naturally, which can cause servers to crash.
I can't get this check from Rack::Lint triggered though
```
app = Rack::Builder.new do
... | I'm not sure whether to open another issue regarding the `to_path` handling.
The spec states:
> If the Body responds to `to_path`, it must return a `String` path for the local file system whose contents are identical to that produced by calling `each`.
The above example uses an `IO.pipe`, which returns two `IO` obje... | I'm not sure whether to open another issue regarding the `to_path` handling.
The spec states:
> If the Body responds to `to_path`, it must return a `String` path for the local file system whose contents are identical to that produced by calling `each`.
The above example uses an `IO.pipe`, which returns two `IO` obje... | [
"https://github.com/rack/rack/commit/ea3313e7a8df71a4ef48c342a173957a98005552",
"https://github.com/rack/rack/commit/ab289499081443fb1e781452ef2c590e8c78f69a",
"https://github.com/rack/rack/commit/3fb2647b863bf5597087ab2fecaae0d418494868",
"https://github.com/rack/rack/commit/cc52a3074b92328eddb01e23e80c37ab1... | 2025-03-24T23:42:36 | 1.6 | Ruby |
soutaro/steep | 945 | soutaro__steep-945 | [
914
] | d2a95686e2b50762222ea76295a19efdbe1df84f | diff --git a/lib/steep/type_construction.rb b/lib/steep/type_construction.rb
index 6beb063d9..6ddb1ccf4 100644
--- a/lib/steep/type_construction.rb
+++ b/lib/steep/type_construction.rb
@@ -3285,7 +3285,14 @@ def type_send_interface(node, interface:, receiver:, receiver_type:, method_name
if call && constr
... | diff --git a/test/type_check_test.rb b/test/type_check_test.rb
index 69ab29547..c6fd06a08 100644
--- a/test/type_check_test.rb
+++ b/test/type_check_test.rb
@@ -1670,4 +1670,48 @@ def self.foo: () -> void
YAML
)
end
+
+ def test_calls_with_index_writer_methods
+ run_type_check_test(
+ signatures... | `obj.[]=(k, v)` does not (necessarily) return `v` in Ruby
… whereas `obj[k] = v` gives `v` regardless of the implementation.
Discussion is open for whether this is a Ruby bug (inconsistency).
Ruby:
```ruby
def []=(k, v)
-1
end
# Control Subject
p(self[:k] = :v) #: Symbol
# Experimental Subject
p self.... | ```ruby
def k=(v)
-1
end
self.k=(:v) #=> :v
self.__send__(:k=, :v) #=> -1
```
| ```ruby
def k=(v)
-1
end
self.k=(:v) #=> :v
self.__send__(:k=, :v) #=> -1
```
| [
"https://github.com/soutaro/steep/commit/a20b292c3db1876ec4a07fd99a0e4e6967e4dda2"
] | 2023-10-27T06:24:30 | 0.0 | Ruby |
soutaro/steep | 1,165 | soutaro__steep-1165 | [
1162
] | dd75aacc81436b1a2c98cceb94a815a006e6b586 | diff --git a/doc/shape.md b/doc/shape.md
index 03b021e41..6d784964d 100644
--- a/doc/shape.md
+++ b/doc/shape.md
@@ -24,7 +24,9 @@ Shape (_Foo) {
Note that the `self` type in the example is resolved to `_Foo` during shape calculation.
The shape calculation of an object is straightforward. Calculate a `RBS::Definiti... | diff --git a/test/validation_test.rb b/test/validation_test.rb
index 0fc4d8507..b68948e09 100644
--- a/test/validation_test.rb
+++ b/test/validation_test.rb
@@ -1156,4 +1156,27 @@ module Bar = Foo
end
end
end
+
+ def test_validate_type_app__classish_bounded
+ with_checker <<~RBS do |checker|
+ ... | Steep 1.7.0 stuck when running check
After upgrading to 1.7.0 the `check` command will stuck when getting this error message
<details>
```
[Steep 1.7.0] [typecheck:typecheck@0] [background] Unexpected error: #<RuntimeError: self_type cannot include 'instance' type: ::FFI::_DataConverter[::FFI::Pointer, instance,... | Confirmed. I'm working to fix the `self_type cannot include 'instance' type` error (by delaying the validation) but type checking FFI still reports some problems.
```
sig/sig-ffi/ffi/auto_pointer.rbs:15:65: [error] Type application of `::FFI::AutoPointer::Releaser::_Proc` doesn't satisfy the constraints: self <: ::... | Confirmed. I'm working to fix the `self_type cannot include 'instance' type` error (by delaying the validation) but type checking FFI still reports some problems.
```
sig/sig-ffi/ffi/auto_pointer.rbs:15:65: [error] Type application of `::FFI::AutoPointer::Releaser::_Proc` doesn't satisfy the constraints: self <: ::... | [
"https://github.com/soutaro/steep/commit/7b92a8d4a7e4a7d7f7d7bc60124916eb88d4f4c3",
"https://github.com/soutaro/steep/commit/26c72c31b331787e2b0b70487350969555487497",
"https://github.com/soutaro/steep/commit/95937983816eda371bdd1016df64b5639c664a8d",
"https://github.com/soutaro/steep/commit/13b86b9e5a5a84c05... | 2024-06-12T02:26:55 | 0.0 | Ruby |
soutaro/steep | 807 | soutaro__steep-807 | [
666
] | 92b3bf061bda542c38353560ff7fe70b32b39f8c | diff --git a/lib/steep/diagnostic/ruby.rb b/lib/steep/diagnostic/ruby.rb
index b9249a163..980c67a15 100644
--- a/lib/steep/diagnostic/ruby.rb
+++ b/lib/steep/diagnostic/ruby.rb
@@ -908,6 +908,19 @@ def header_line
end
end
+ class ProcHintIgnored < Base
+ attr_reader :hint_type, :block_node... | diff --git a/test/type_construction_test.rb b/test/type_construction_test.rb
index b28a02b3c..58cd87314 100644
--- a/test/type_construction_test.rb
+++ b/test/type_construction_test.rb
@@ -4677,9 +4677,10 @@ def test_lambda2
with_standard_construction(checker, source) do |construction, typing|
construct... | lambda's parameter is marked as untyped with union
Lambda's parameter is marked as untyped unexpectedly when the lambda is assigned to a variable as a union type.
```ruby
# It is ok. `str` is `String`
# @type var x: ^(String) -> void
x = -> (str) { str + 'a' }
# It is not ok. `str` is `untyped`, but I expect... | [
"https://github.com/soutaro/steep/commit/c003a7c1e4a2a09c5b3bd1a280bfe90f62fee109",
"https://github.com/soutaro/steep/commit/ab0fef8d1b5877619c927c1b46805c322226e291",
"https://github.com/soutaro/steep/commit/981acf17a5935b1739fbe65c0ad809b38171ad16"
] | 2023-05-26T08:29:10 | 0.0 | Ruby | ||
soutaro/steep | 944 | soutaro__steep-944 | [
912
] | d2a95686e2b50762222ea76295a19efdbe1df84f | diff --git a/lib/steep/path_helper.rb b/lib/steep/path_helper.rb
index 599f9d8a6..d9cc2de84 100644
--- a/lib/steep/path_helper.rb
+++ b/lib/steep/path_helper.rb
@@ -7,6 +7,7 @@ def to_pathname(uri, dosish: Gem.win_platform?)
if uri.scheme == "file"
path = uri.path or raise
path.sub!(%r{^/([a-zA... | diff --git a/smoke/regression/test_expectations.yml b/smoke/regression/test_expectations.yml
index 3085c399f..9fbe8c672 100644
--- a/smoke/regression/test_expectations.yml
+++ b/smoke/regression/test_expectations.yml
@@ -35,6 +35,18 @@
severity: ERROR
message: 'Cannot find the declaration of class: `Foo`'
... | Space in file path crashes and deadlocks `steep check`
I’m a GUI user (:
```
$ mkdir '/tmp/dump core'
$ cd '/tmp/dump core'
$ touch 'dummy.rb'
$ echo 'target :l do check "." end' > Steepfile
$ steep check
```
<details><summary>Output:</summary>
```
# Type checking files:
#<Thread:0x00007f7e90b57eb0 /usr/... | [
"https://github.com/soutaro/steep/commit/b73808a0d94ffe437a01fe6806171685bf24381d",
"https://github.com/soutaro/steep/commit/9bca96da5bff31809efd7dfda86f074780c91351",
"https://github.com/soutaro/steep/commit/7bd0619b494fe16c21c4e51f7a08fd6cb02b2239"
] | 2023-10-27T06:10:45 | 0.0 | Ruby | ||
soutaro/steep | 785 | soutaro__steep-785 | [
782
] | 9b1db5d965f9de276e8d54051a2f551231db11c1 | diff --git a/lib/steep/type_construction.rb b/lib/steep/type_construction.rb
index 9b626ab8b..c37506c8a 100644
--- a/lib/steep/type_construction.rb
+++ b/lib/steep/type_construction.rb
@@ -1100,12 +1100,9 @@ def synthesize(node, hint: nil, condition: false)
return_value_node = node.children[0]
... | diff --git a/test/type_construction_test.rb b/test/type_construction_test.rb
index f63b36c13..66cc2e10c 100644
--- a/test/type_construction_test.rb
+++ b/test/type_construction_test.rb
@@ -10469,4 +10469,25 @@ def test_opasgn_error_report
end
end
end
+
+ def test_return__mvalue
+ with_checker(<<~RBS)... | Returning multiple value
```ruby
# @type method foo: () -> [Integer, String]
def foo
return 1, "" # => should type check
end
```
| [
"https://github.com/soutaro/steep/commit/32fe454031f5afbb8daa986dcada9c4eadc6ac71"
] | 2023-05-23T02:49:28 | 0.0 | Ruby | ||
hashicorp/vagrant | 13,643 | hashicorp__vagrant-13643 | [
13632
] | e62d18bc1d9615a283f710601f2ae7ecff2da5b2 | diff --git a/plugins/providers/hyperv/cap/configure_disks.rb b/plugins/providers/hyperv/cap/configure_disks.rb
index 28a7a664a0a..3d2ecf4eccd 100644
--- a/plugins/providers/hyperv/cap/configure_disks.rb
+++ b/plugins/providers/hyperv/cap/configure_disks.rb
@@ -51,9 +51,16 @@ def self.get_current_disk(machine, disk, all... | diff --git a/test/unit/plugins/providers/hyperv/cap/configure_disks_test.rb b/test/unit/plugins/providers/hyperv/cap/configure_disks_test.rb
index 46049a5aee0..7ed1d0d9251 100644
--- a/test/unit/plugins/providers/hyperv/cap/configure_disks_test.rb
+++ b/test/unit/plugins/providers/hyperv/cap/configure_disks_test.rb
@@ ... | `get_current_disk': undefined method `[]' for nil when using Hyper-V provider and attempting to resize the Primary Disk
### Debug output
The debug output does not seem to contain the relevant information, which is the ControllerLocation actually discovered. I present this information largely redacted here with support... | [
"https://github.com/hashicorp/vagrant/commit/a8e61a3daf020e4a8dff06f8b89896f9b667ba8d"
] | 2025-04-08T20:29:58 | 2.3 | Ruby | ||
hashicorp/vagrant | 13,043 | hashicorp__vagrant-13043 | [
13028
] | c5887f808c6836a4abd4f16747a4ecbeea70f0d4 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d1b95273967..3f808f538d4 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -20,7 +20,7 @@ jobs:
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
- ruby-version: '2.7'
+ ru... | diff --git a/.github/workflows/go-spectest.yml b/.github/workflows/go-spectest.yml
index 14e2e89abc0..e2188643b5e 100644
--- a/.github/workflows/go-spectest.yml
+++ b/.github/workflows/go-spectest.yml
@@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
go: ['^1.16']
- ruby: ['2.7']
+ ruby: ['3.... | bundle exec rake fails with ruby3.2
With git head ( c5887f808c6836a4abd4f16747a4ecbeea70f0d4 ) , `$ bundle exec rake` fails with upcoming ruby3.2 (e.g. now I've tried https://github.com/ruby/ruby/commit/613fca01486e47dee9364a2fd86b5f5e77fe23c8 ) like:
```
$ ruby --version
ruby 3.2.0dev (2022-12-15 master 613fca01... | Temtative fix is :
```
diff --git a/test/unit/plugins/provisioners/ansible/provisioner_test.rb b/test/unit/plugins/provisioners/ansible/provisioner_test.rb
index f5828f143..15fb3bbdc 100644
--- a/test/unit/plugins/provisioners/ansible/provisioner_test.rb
+++ b/test/unit/plugins/provisioners/ansible/provisioner_t... | Temtative fix is :
```
diff --git a/test/unit/plugins/provisioners/ansible/provisioner_test.rb b/test/unit/plugins/provisioners/ansible/provisioner_test.rb
index f5828f143..15fb3bbdc 100644
--- a/test/unit/plugins/provisioners/ansible/provisioner_test.rb
+++ b/test/unit/plugins/provisioners/ansible/provisioner_t... | [
"https://github.com/hashicorp/vagrant/commit/d69287f8500dd69a7318c608cd63adc9d7922653",
"https://github.com/hashicorp/vagrant/commit/138fbf9a596e701e111a24ac51511536da00e15a",
"https://github.com/hashicorp/vagrant/commit/7661eba89a5786a1b0826dbb2f45f8827d9a5103",
"https://github.com/hashicorp/vagrant/commit/9... | 2023-01-04T00:41:10 | 2.3 | Ruby |
hashicorp/vagrant | 13,054 | hashicorp__vagrant-13054 | [
13010
] | 56d6cbaa8edcf591415f93f977f23c2b54d009bf | diff --git a/plugins/provisioners/ansible/cap/guest/posix/ansible_installed.rb b/plugins/provisioners/ansible/cap/guest/posix/ansible_installed.rb
index 329eab8a917..ab171ee5daa 100644
--- a/plugins/provisioners/ansible/cap/guest/posix/ansible_installed.rb
+++ b/plugins/provisioners/ansible/cap/guest/posix/ansible_inst... | diff --git a/test/unit/plugins/provisioners/ansible/provisioner_test.rb b/test/unit/plugins/provisioners/ansible/provisioner_test.rb
index fdf9aa67eaa..2cb9f7bceee 100644
--- a/test/unit/plugins/provisioners/ansible/provisioner_test.rb
+++ b/test/unit/plugins/provisioners/ansible/provisioner_test.rb
@@ -71,12 +71,14 @@... | ansible_local provisioner unable to install specific version of Ansible with pip install_mode
The `ansible_local` provisioner is able to install a specific version of Ansible using the `version` attribute. You can combine this with the `install_mode` attribute, specifically using `pip` to install and manage Ansible ver... | Instead of using importlib, you can also call `ansible-community --version` to get the version of the "community distribution"
| Instead of using importlib, you can also call `ansible-community --version` to get the version of the "community distribution"
| [
"https://github.com/hashicorp/vagrant/commit/76ef7d3dc83db9587324fb768b79af69e98130e8",
"https://github.com/hashicorp/vagrant/commit/5f82adf122bedb91480a4f86421c2c0161827205",
"https://github.com/hashicorp/vagrant/commit/dfabbbb7fe664975508a2ad5455b7ece325f56f0"
] | 2023-01-10T13:26:36 | 2.3 | Ruby |
hashicorp/vagrant | 13,670 | hashicorp__vagrant-13670 | [
12180
] | ab0a515f3b92e2d834c6b075b3ae5fc7ec321d52 | diff --git a/plugins/providers/hyperv/action/import.rb b/plugins/providers/hyperv/action/import.rb
index f901d1af9f9..716cc51dfec 100644
--- a/plugins/providers/hyperv/action/import.rb
+++ b/plugins/providers/hyperv/action/import.rb
@@ -70,9 +70,11 @@ def call(env)
"LinkedClone" => !!env[:machine].provider... | diff --git a/test/unit/plugins/providers/hyperv/action/import_test.rb b/test/unit/plugins/providers/hyperv/action/import_test.rb
index fddb36bc7bb..0c4d4cdbcf4 100644
--- a/test/unit/plugins/providers/hyperv/action/import_test.rb
+++ b/test/unit/plugins/providers/hyperv/action/import_test.rb
@@ -15,7 +15,10 @@
let(:... | vagrant up with Hyper-V fails when box was packaged from a VM that has more resources than available on current Machine.
When I package a Hyper-V Box on a machine with lots of resources (e.g. 50GB memory, 20 CPUs), I am unable to launch the instance on another machine with fewer resources, even if local resources are s... | [
"https://github.com/hashicorp/vagrant/commit/6a0f87583311282f3bca20eee7f240966ba10b6c"
] | 2025-05-21T01:11:18 | 2.3 | Ruby | ||
hashicorp/vagrant | 13,601 | hashicorp__vagrant-13601 | [
13345
] | ce6ebdfef5187aba8afd2c15fc65223de3b86e1a | diff --git a/lib/vagrant/box.rb b/lib/vagrant/box.rb
index f47a4573835..ea628f26fb7 100644
--- a/lib/vagrant/box.rb
+++ b/lib/vagrant/box.rb
@@ -203,7 +203,8 @@ def has_update?(version=nil, download_options: {})
version += "> #{@version}"
md = self.load_metadata(download_options)
newer = md.... | diff --git a/test/unit/plugins/commands/box/command/outdated_test.rb b/test/unit/plugins/commands/box/command/outdated_test.rb
index 7548bda44bd..48a46699024 100644
--- a/test/unit/plugins/commands/box/command/outdated_test.rb
+++ b/test/unit/plugins/commands/box/command/outdated_test.rb
@@ -138,6 +138,147 @@
... | "vagrant box outdated" and "vagrant box outdated --force" do not show any updates but `vagrant box outdated --global` does
<!--
Please note that the Vagrant issue tracker is reserved for bug reports. For general usage questions, please use
HashiCorp Discuss, https://discuss.hashicorp.com/c/vagrant/.
When you submi... | I noticed the same issue. It applies both for HashiCorps' cloud (tested with `ubuntu/noble64`) and a local Artifactory repository. Applying the `--global` flag results in the expected behaviour for both cases.
*Edit* `vagrant box update` seems to have the same issue, with the exception that there's no `--global` fla... | I noticed the same issue. It applies both for HashiCorps' cloud (tested with `ubuntu/noble64`) and a local Artifactory repository. Applying the `--global` flag results in the expected behaviour for both cases.
*Edit* `vagrant box update` seems to have the same issue, with the exception that there's no `--global` fla... | [
"https://github.com/hashicorp/vagrant/commit/834e84fa6e7e20b449afb211f58a2d3db4c6665c",
"https://github.com/hashicorp/vagrant/commit/1d5abc091f0f41f21b8911d6e07b752db282032f",
"https://github.com/hashicorp/vagrant/commit/5564b8a1fd2ffa292a5f41c47cc79c8863f2613a",
"https://github.com/hashicorp/vagrant/commit/1... | 2025-03-03T19:58:38 | 2.3 | Ruby |
decidim/decidim | 13,392 | decidim__decidim-13392 | [
13383
] | e5dd8a3e7537d6e83466e968facf3f6d90a54c7e | diff --git a/decidim-blogs/spec/system/endorse_posts_spec.rb b/decidim-blogs/spec/system/endorse_posts_spec.rb
index 2f76f2596dce8..cac8b4b67d060 100644
--- a/decidim-blogs/spec/system/endorse_posts_spec.rb
+++ b/decidim-blogs/spec/system/endorse_posts_spec.rb
@@ -6,99 +6,16 @@
include_context "with a component"
... | diff --git a/decidim-blogs/lib/decidim/blogs/test/factories.rb b/decidim-blogs/lib/decidim/blogs/test/factories.rb
index 1554a88e4e510..55b34e1c0d27c 100644
--- a/decidim-blogs/lib/decidim/blogs/test/factories.rb
+++ b/decidim-blogs/lib/decidim/blogs/test/factories.rb
@@ -14,6 +14,22 @@
name { generate_component_n... | Liking a resource prompts for groups even though groups are disabled
### Describe the bug
When i visit any resource, and click "Like", the select identity is being triggered if i have a group associated to me, even though the groups are disabled at organization level.
### To Reproduce
1. Go to admin panel -> Configu... | [
"https://github.com/decidim/decidim/commit/eebd7a5b375a71adfa0cf18e864169c956b94543",
"https://github.com/decidim/decidim/commit/2577e439666d0cc431360a4a8e5e877c93b74bb4",
"https://github.com/decidim/decidim/commit/45a5fe729462e80c4d34683be2b1b45660886cc4",
"https://github.com/decidim/decidim/commit/011a13945... | 2024-09-12T11:07:54 | 0.22 | Ruby | ||
decidim/decidim | 10,551 | decidim__decidim-10551 | [
10548
] | 587d34a850225b8e12b59aaf9090e308094ba9c0 | diff --git a/decidim-proposals/lib/decidim/proposals/component.rb b/decidim-proposals/lib/decidim/proposals/component.rb
index ea2c8aac1e0b2..c6353c66de31b 100644
--- a/decidim-proposals/lib/decidim/proposals/component.rb
+++ b/decidim-proposals/lib/decidim/proposals/component.rb
@@ -28,19 +28,19 @@
component.settin... | diff --git a/decidim-dev/lib/decidim/dev/test/rspec_support/component_context.rb b/decidim-dev/lib/decidim/dev/test/rspec_support/component_context.rb
index a1b6658562f90..0bf11e97262b1 100644
--- a/decidim-dev/lib/decidim/dev/test/rspec_support/component_context.rb
+++ b/decidim-dev/lib/decidim/dev/test/rspec_support/... | Deleting Boolean values from Proposal config will trigger errors
### Describe the bug
While investigating the fix for #10525, i have tried to remove all the integer field values so i could test some edge cases.
### To Reproduce
1. Go to proposals component config
2. Remove all the values from integer fields, pres... | [
"https://github.com/decidim/decidim/commit/3c9fb69c4a1a9e98f55ad7911bbf7c44c8e8c9f2",
"https://github.com/decidim/decidim/commit/1d3b1a0ebf25bc7d85b6e393881ec068da25f0d0"
] | 2023-03-14T11:18:42 | 0.22 | Ruby | ||
decidim/decidim | 11,468 | decidim__decidim-11468 | [
11462
] | fd44a1c5f2942cdf0af3f4fed2f0918da86ca6b6 | diff --git a/decidim-admin/app/jobs/decidim/admin/application_job.rb b/decidim-admin/app/jobs/decidim/admin/application_job.rb
index 5b4ca4e2b7c01..b085320d7d499 100644
--- a/decidim-admin/app/jobs/decidim/admin/application_job.rb
+++ b/decidim-admin/app/jobs/decidim/admin/application_job.rb
@@ -4,7 +4,7 @@ module Deci... | diff --git a/decidim-dev/lib/decidim/dev/test/rspec_support/bullet.rb b/decidim-dev/lib/decidim/dev/test/rspec_support/bullet.rb
index fdea8bbca673a..928f9bb2368dc 100644
--- a/decidim-dev/lib/decidim/dev/test/rspec_support/bullet.rb
+++ b/decidim-dev/lib/decidim/dev/test/rspec_support/bullet.rb
@@ -3,12 +3,7 @@
requi... | Refactor Decidim jobs to inherit from Decidim::ApplicationJob
While working on #11416, i have noticed that not all of the jobs are inherited from the same decidim job (`Decidim::ApplicationJob`). We need to refactor and add the Decidim::ApplicationJob as a single point of inheritance.
_See the comment https://github.... | [
"https://github.com/decidim/decidim/commit/047960612fda3967b832150aeb4ab0a4abda22af"
] | 2023-08-09T15:19:51 | 0.22 | Ruby | ||
decidim/decidim | 15,742 | decidim__decidim-15742 | [
15664
] | 4f8dfde717d902714171e1b9e4c5f3901ad9ec5b | diff --git a/decidim-elections/app/controllers/concerns/decidim/elections/uses_votes_booth.rb b/decidim-elections/app/controllers/concerns/decidim/elections/uses_votes_booth.rb
index 08cf7b7c030c8..6dd6b9f38c4a7 100644
--- a/decidim-elections/app/controllers/concerns/decidim/elections/uses_votes_booth.rb
+++ b/decidim-... | diff --git a/decidim-elections/lib/decidim/elections/test/per_question_vote_examples.rb b/decidim-elections/lib/decidim/elections/test/per_question_vote_examples.rb
index 4972a1da1469c..0245f954ed280 100644
--- a/decidim-elections/lib/decidim/elections/test/per_question_vote_examples.rb
+++ b/decidim-elections/lib/deci... | Allow editing the vote for the last question in a question by question election
### Describe the bug
This is point 5 of #15592
Given a **question by question** election, when the user is voting questions, it can edit the previous ones (if enabled) except the last one.
This is because the last screen presented is the... | [
"https://github.com/decidim/decidim/commit/f6f52950346b4e6eda35d75f7621f7684ce1afd8",
"https://github.com/decidim/decidim/commit/caa64fbeb097d0f22bac1a33526e83de4f6545c2"
] | 2025-12-05T10:24:06 | 0.22 | Ruby | ||
decidim/decidim | 15,362 | decidim__decidim-15362 | [
15347
] | f50135032ad852c948c3fc37423aafa4e7b6c7c9 | diff --git a/decidim-core/app/packs/stylesheets/decidim/_modal_fingerprint.scss b/decidim-core/app/packs/stylesheets/decidim/_modal_fingerprint.scss
index f5487576daab1..b7e3f437e57f2 100644
--- a/decidim-core/app/packs/stylesheets/decidim/_modal_fingerprint.scss
+++ b/decidim-core/app/packs/stylesheets/decidim/_modal_... | diff --git a/decidim-core/lib/decidim/core/test/shared_examples/fingerprint_examples.rb b/decidim-core/lib/decidim/core/test/shared_examples/fingerprint_examples.rb
index b5f13a346fb26..e5fea59acbcdc 100644
--- a/decidim-core/lib/decidim/core/test/shared_examples/fingerprint_examples.rb
+++ b/decidim-core/lib/decidim/c... | Fingerprint calculator inconsistent
### Describe the bug
Let's say you have a proposal with a body text (raw input): "I want more trees in the central park :)" (notice the multiple spaces) and you click on the "Check fingerprint link", it will tell you it's possible to generate the SHA256 by yourself via a third ... | I don't know if GitHub itself is removing the double spacing:
"I want more trees in the central park :)"
"I want more trees in the central park :)"
---
Edit: yes, this is what it looks like when editing
<img width="442" height="104" alt="Image" src="https://github.com/user-attachments/assets/61359cab-eeba-4597-ba... | [
"https://github.com/decidim/decidim/commit/533c2ec4ed56dd2cd40be7926620172089f0e2b2",
"https://github.com/decidim/decidim/commit/b36725adfd3c9cc041aa74f4a690a68865c72877",
"https://github.com/decidim/decidim/commit/ad1df727233041714c180cccc7f59d028c381157"
] | 2025-10-15T12:07:28 | 0.22 | Ruby | |
ViewComponent/view_component | 1,711 | ViewComponent__view_component-1711 | [
1629
] | e4927ec143ef74819fc4ebf2c4e408a566ebb54e | diff --git a/Gemfile.lock b/Gemfile.lock
index 5b3c6c359..46b36e593 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
- view_component (3.0.0.rc6)
+ view_component (3.0.0)
activesupport (>= 5.2.0, < 8.0)
concurrent-ruby (~> 1.0)
method_source (~> 1.0)
d... | diff --git a/test/sandbox/test/rendering_test.rb b/test/sandbox/test/rendering_test.rb
index ef7f78be7..a52814d9b 100644
--- a/test/sandbox/test/rendering_test.rb
+++ b/test/sandbox/test/rendering_test.rb
@@ -348,14 +348,13 @@ def test_that_it_has_a_version_number
assert_kind_of Integer, ::ViewComponent::VERSION::... | 3.0.0 release candidate feedback
👋🏻 Hi folks! We've shipped a release candidate for ViewComponent v3. Please provide feedback in this issue ❤️
| I'm not seeing it https://rubygems.org/gems/view_component, did it get pushed?
@jcoyne It's in progress. I wanted to have this issue open to mention in the changelog. 🐔, 🥚 , etc.
@joelhawksley got it. Thanks.
I tried it. Looks good in general.
However, it would be great to have a solution for the forms-issue (ref.... | I'm not seeing it https://rubygems.org/gems/view_component, did it get pushed?
@jcoyne It's in progress. I wanted to have this issue open to mention in the changelog. 🐔, 🥚 , etc.
@joelhawksley got it. Thanks.
I tried it. Looks good in general.
However, it would be great to have a solution for the forms-issue (ref.... | [
"https://github.com/ViewComponent/view_component/commit/795ad524ce90656217b0b23716055e44c9124486"
] | 2023-04-21T21:04:04 | 2.37 | Ruby |
ViewComponent/view_component | 2,135 | ViewComponent__view_component-2135 | [
2111
] | 117650575c823807b623e048f9d2977ba884b771 | diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 070f16524..2e3ff1d6b 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -10,6 +10,10 @@ nav_order: 5
## main
+* Enable components to use `@request` and `request` methods/ivars.
+
+ *Blake Williams*
+
* Fix bug where implicit locales in component f... | diff --git a/test/sandbox/app/components/request_param_component.rb b/test/sandbox/app/components/request_param_component.rb
new file mode 100644
index 000000000..b1601f0d4
--- /dev/null
+++ b/test/sandbox/app/components/request_param_component.rb
@@ -0,0 +1,9 @@
+class RequestParamComponent < ViewComponent::Base
+ de... | Can not use "request" as argument
### Steps to reproduce
Having `request` as a argument to a component fails, eg
```ruby
class ExampleComponent < ViewComponent::Base
def initialize(request:)
@request = request
end
end
```
Running `render(ExampleComponent.new(request: "My Title"))`
will result in:
`... | @erikaxel Thanks for opening this! Can you share a full backtrace?
Yeah, sorry for not including it in the original bug report. Here is the one from the demo repo:
```
[view_component (3.15.1) lib/view_component/base.rb:112:in `render_in'](http://127.0.0.1:3000/#)
[actionview (7.2.1) lib/action_view/template/rendera... | @erikaxel Thanks for opening this! Can you share a full backtrace?
Yeah, sorry for not including it in the original bug report. Here is the one from the demo repo:
```
[view_component (3.15.1) lib/view_component/base.rb:112:in `render_in'](http://127.0.0.1:3000/#)
[actionview (7.2.1) lib/action_view/template/rendera... | [
"https://github.com/ViewComponent/view_component/commit/53ff46b8c98c8a4f3d8d0acc451d5e201d9914ce",
"https://github.com/ViewComponent/view_component/commit/a24c0c46cf7c2d637c9def32eda4bac4686e8af8",
"https://github.com/ViewComponent/view_component/commit/2a2fecabf1a8d4c272fc3fa7bf74677bc663b258",
"https://gith... | 2024-10-16T14:46:38 | 2.37 | Ruby |
ViewComponent/view_component | 1,650 | ViewComponent__view_component-1650 | [
241,
1099,
1137,
1384,
1485,
1607,
1651
] | 31d95701d4373a3a3f7f33cd314d0d158af5ec3d | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 188c1ddc4..494631f10 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -29,14 +29,34 @@ jobs:
include:
- rails_version: "5.2.6"
ruby_version: "2.7"
+ mode: "capture_patch_enabled"
... | diff --git a/test/sandbox/app/components/form_partial_component.html.erb b/test/sandbox/app/components/form_partial_component.html.erb
new file mode 100644
index 000000000..20e0f0ce7
--- /dev/null
+++ b/test/sandbox/app/components/form_partial_component.html.erb
@@ -0,0 +1,3 @@
+<%= form_for Post.new, url: "/" do |form... | Strange behavior with code blocks using form helpers and Slim
Hi!
I'm playing with this project for use in production but I encountered a possible bug related with passing a Slim/HTML block to Rails helper.
```ruby
# app/components/test_component.rb
class TestComponent < ActionView::Component::Base
def ini... | This looks really similar to the issue I ran into that caused me to open https://github.com/github/actionview-component/pull/240.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Just ran into th... | This looks really similar to the issue I ran into that caused me to open https://github.com/github/actionview-component/pull/240.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Just ran into th... | [
"https://github.com/ViewComponent/view_component/commit/f45c0c8a317e290f912e79f4cb72d04e14b1f906",
"https://github.com/ViewComponent/view_component/commit/a24585a11ea667cd8c2a0d283265379c4ec343c6",
"https://github.com/ViewComponent/view_component/commit/27ea033a8910d9f0400d3894d8379ec71346c206",
"https://gith... | 2023-02-01T18:17:43 | 2.37 | Ruby |
ViewComponent/view_component | 1,765 | ViewComponent__view_component-1765 | [
1764
] | 46ace49afbade91636b5d929ca36c93f23f5ab5a | diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 578c4145e..b54c37412 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -18,6 +18,10 @@ nav_order: 5
*Pasha Kalashnikov*
+* Add URL helpers to previews
+
+ *Reegan Viljoen*
+
## 3.1.0
* Check `defined?(Rails) && Rails.application` before us... | diff --git a/test/sandbox/app/components/url_helper_component.html.erb b/test/sandbox/app/components/url_helper_component.html.erb
new file mode 100644
index 000000000..8395fca03
--- /dev/null
+++ b/test/sandbox/app/components/url_helper_component.html.erb
@@ -0,0 +1,1 @@
+<a href="<%= @url %>" target="_blank">root</a>... | Add Rails url helpers to Previews
## Feature request
Add Rails Url helpers to previews, for instance, if `resources :items` is defined in `routes.rb`, I may want to use `items_path` in the component preview method
### Motivation
I have personally come across the need to use these url helpers inside of the preview ... | [
"https://github.com/ViewComponent/view_component/commit/3ef7a0e5eb38fb0133ab1eced83b4a28ae393846",
"https://github.com/ViewComponent/view_component/commit/2aa36714f0a4bf07ebc13fd235599022feb2c98f",
"https://github.com/ViewComponent/view_component/commit/48a6babf6e265af22d445967942e4d041536fb0f",
"https://gith... | 2023-06-04T19:54:13 | 2.37 | Ruby | ||
ViewComponent/view_component | 1,666 | ViewComponent__view_component-1666 | [
1577
] | 72830c8cf4aa034570fb2cc3167dedbd69cf7f4b | diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index bc003451b..2b18249cc 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -10,6 +10,10 @@ nav_order: 5
## main
+* Raise error if translations are used in initializer.
+
+ *Joel Hawksley*
+
## v3.0.0.rc5
* Fix bug where `mkdir_p` failed due to inc... | diff --git a/test/sandbox/app/components/initializer_translations_component.rb b/test/sandbox/app/components/initializer_translations_component.rb
new file mode 100644
index 000000000..3fad394c1
--- /dev/null
+++ b/test/sandbox/app/components/initializer_translations_component.rb
@@ -0,0 +1,7 @@
+# frozen_string_litera... | Relative translations don't work in initializer
This is similar to #74
If I have an initializer and I use the translation helper, then I get the error:
```
Cannot use t(".link_text") shortcut because path is not available
```
This happens even after calling `super`
If I move the translation into an instance m... | @jcoyne thanks for filing this issue. Might you be up for writing a PR with a failing test? Perhaps @elia could have a look, then.
This is expected, although I agree would be great to have them working in the initializer as well.
The reason it works as an instance method is that the method is most likely called afte... | @jcoyne thanks for filing this issue. Might you be up for writing a PR with a failing test? Perhaps @elia could have a look, then.
This is expected, although I agree would be great to have them working in the initializer as well.
The reason it works as an instance method is that the method is most likely called afte... | [
"https://github.com/ViewComponent/view_component/commit/73daba172cb57e32537d266055b66f29b84e6fec",
"https://github.com/ViewComponent/view_component/commit/e03ba16f2e41ca9dfd5b202962aa12a9317c3c25",
"https://github.com/ViewComponent/view_component/commit/89aac9104d7fd62eaae95904d8b460b378e335ab",
"https://gith... | 2023-02-22T22:11:11 | 2.37 | Ruby |
Shopify/ruby-lsp-rails | 310 | Shopify__ruby-lsp-rails-310 | [
305,
309
] | e21b791e4f8974c9c7bcd141603dba553c83dee9 | diff --git a/lib/ruby_lsp/ruby_lsp_rails/runner_client.rb b/lib/ruby_lsp/ruby_lsp_rails/runner_client.rb
index b8dce414..d5a1f64e 100644
--- a/lib/ruby_lsp/ruby_lsp_rails/runner_client.rb
+++ b/lib/ruby_lsp/ruby_lsp_rails/runner_client.rb
@@ -30,6 +30,9 @@ def create_client
class InitializationError < Standard... | diff --git a/test/ruby_lsp_rails/runner_client_test.rb b/test/ruby_lsp_rails/runner_client_test.rb
index ac582b02..87fd8a11 100644
--- a/test/ruby_lsp_rails/runner_client_test.rb
+++ b/test/ruby_lsp_rails/runner_client_test.rb
@@ -74,6 +74,22 @@ class RunnerClientTest < ActiveSupport::TestCase
ensure
Fi... | Ruby LSP fails to boot due to an error in Runner Client Ruby LSP Rails failed to initialize server: unexpected token at ''
### Description
Unable to get Ruby LSP client start due to an error in boot cycle w/ Runner client Ruby, this then switches to the noop/null client, not allowing cooler functionalities such as pea... | Hi @bhargavrpatel, this should be solved by https://github.com/Shopify/ruby-lsp-rails/pull/310 once released.
Hi @bbouchet-trustpair,
From the logs this doesn't look related to indexing.
If you run `bin/rails console` does it start successfully?
Hey @andyw8 thanks for your reply
Yes rails' console (and server),... | Hi @bhargavrpatel, this should be solved by https://github.com/Shopify/ruby-lsp-rails/pull/310 once released.
Hi @bbouchet-trustpair,
From the logs this doesn't look related to indexing.
If you run `bin/rails console` does it start successfully?
Hey @andyw8 thanks for your reply
Yes rails' console (and server),... | [
"https://github.com/Shopify/ruby-lsp-rails/commit/d1bd9d902f012901ca99e2d34f38884df2e6c5ca"
] | 2024-03-27T15:52:49 | 0.0 | Ruby |
Shopify/ruby-lsp-rails | 104 | Shopify__ruby-lsp-rails-104 | [
103
] | 70f7cc26d53645d8beb8352a7bddf19425a61aee | diff --git a/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb b/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb
index 1ad20443..f051a7c6 100644
--- a/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb
+++ b/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb
@@ -59,16 +59,26 @@ def on_command(node)
return unless message_value == "test" && node.a... | diff --git a/test/ruby_lsp_rails/code_lens_test.rb b/test/ruby_lsp_rails/code_lens_test.rb
index ecf3a7a7..9e9b3709 100644
--- a/test/ruby_lsp_rails/code_lens_test.rb
+++ b/test/ruby_lsp_rails/code_lens_test.rb
@@ -38,6 +38,30 @@ class Test < ActiveSupport::TestCase
assert_match("Debug", response[5].command.ti... | Code lens doesn't handle multiline escaped strings
We're not handling this case, but it shouldn't be hard to support it.
```ruby
test "something" \
"otherthing" do
end
```
| [
"https://github.com/Shopify/ruby-lsp-rails/commit/673adb1a919ca8b37c1f89a0eef19d807623a882"
] | 2023-07-06T19:08:45 | 0.0 | Ruby | ||
Shopify/ruby-lsp-rails | 464 | Shopify__ruby-lsp-rails-464 | [
463
] | d25f7aaf5d26f091ab1fdfecff09408c88ca3878 | diff --git a/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb b/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb
index 51866b2c..3a7371b0 100644
--- a/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb
+++ b/lib/ruby_lsp/ruby_lsp_rails/code_lens.rb
@@ -198,9 +198,13 @@ def add_jump_to_view(node)
.gsub("::", "/")
.downcase
... | diff --git a/test/dummy/app/views/users/index/.keep b/test/dummy/app/views/users/index/.keep
new file mode 100644
index 00000000..e69de29b
diff --git a/test/ruby_lsp_rails/code_lens_test.rb b/test/ruby_lsp_rails/code_lens_test.rb
index 0b6aa358..769dfb53 100644
--- a/test/ruby_lsp_rails/code_lens_test.rb
+++ b/test/rub... | "Jump to view" includes folders as well
### Description
### Ruby LSP Information
### Ruby LSP Information
#### VS Code Version
1.93.1
#### Ruby LSP Extension Version
0.8.1
#### Ruby LSP Server Version
0.18.3
#### Ruby LSP Addons
- Ruby LSP Rails
#### Ruby Version
3.2.5
#### Ruby Version Manager
rbenv
##... | Thanks, https://github.com/Shopify/ruby-lsp-rails/pull/464 should solve this.
| Thanks, https://github.com/Shopify/ruby-lsp-rails/pull/464 should solve this.
| [
"https://github.com/Shopify/ruby-lsp-rails/commit/cbed4d7f702dec26a851e96347c796efb72f79d1",
"https://github.com/Shopify/ruby-lsp-rails/commit/78afc893cbde5759d52be436576630acb5d981d0",
"https://github.com/Shopify/ruby-lsp-rails/commit/1e86f3efed6c31f0e4e6bf89e164608718b84425"
] | 2024-09-25T18:01:55 | 0.0 | Ruby |
Shopify/ruby-lsp-rails | 264 | Shopify__ruby-lsp-rails-264 | [
260
] | f32f92c1bbaccae6889c13706b5de0e651335097 | diff --git a/lib/ruby_lsp/ruby_lsp_rails/server.rb b/lib/ruby_lsp/ruby_lsp_rails/server.rb
index e1d55743..b14351fd 100644
--- a/lib/ruby_lsp/ruby_lsp_rails/server.rb
+++ b/lib/ruby_lsp/ruby_lsp_rails/server.rb
@@ -26,7 +26,7 @@ class Server
extend T::Sig
- sig { params(model_name: String).returns(T.nil... | diff --git a/test/ruby_lsp_rails/runner_client_test.rb b/test/ruby_lsp_rails/runner_client_test.rb
index 555bca51..23885c2e 100644
--- a/test/ruby_lsp_rails/runner_client_test.rb
+++ b/test/ruby_lsp_rails/runner_client_test.rb
@@ -16,6 +16,8 @@ class RunnerClientTest < ActiveSupport::TestCase
assert_predicate ... | Rails 6.x compatibility broken due to `schema_dump_path`
From https://github.com/Shopify/ruby-lsp-rails/pull/250#discussion_r1494018448 the compatibility with Rails 6.x is broken.
The gemspec specify it is compatible with [ActiveRecord 6](https://github.com/Shopify/ruby-lsp-rails/blob/ba16bf3d9c4f150a1e9438c48165f2d... | The method `schema_dump_path` rely on `ActiveRecord.schema_format` and `db_config.schema_dump` that seems to be also available only in Rails 7+.
Thanks for the report, I will look into this.
| The method `schema_dump_path` rely on `ActiveRecord.schema_format` and `db_config.schema_dump` that seems to be also available only in Rails 7+.
Thanks for the report, I will look into this.
@andyw8 Thanks for the fix
| [
"https://github.com/Shopify/ruby-lsp-rails/commit/ed241b3fe915628b277d5df8b765927bac8d017b",
"https://github.com/Shopify/ruby-lsp-rails/commit/2749956c38cac0b9a99ecb7ba1875d45dc03757d",
"https://github.com/Shopify/ruby-lsp-rails/commit/a220eecfc160cf643002e3bee85641c0481385e2",
"https://github.com/Shopify/rub... | 2024-02-20T17:15:11 | 0.0 | Ruby |
Shopify/ruby-lsp-rails | 570 | Shopify__ruby-lsp-rails-570 | [
540
] | 5c59f2f9f2b2a6a7a1416834c53275eee8020dab | diff --git a/lib/ruby_lsp/ruby_lsp_rails/addon.rb b/lib/ruby_lsp/ruby_lsp_rails/addon.rb
index 6f137c6f..0a31d353 100644
--- a/lib/ruby_lsp/ruby_lsp_rails/addon.rb
+++ b/lib/ruby_lsp/ruby_lsp_rails/addon.rb
@@ -32,6 +32,12 @@ def initialize
@rails_runner_client = T.let(NullClient.new, RunnerClient)
@g... | diff --git a/test/ruby_lsp_rails/addon_test.rb b/test/ruby_lsp_rails/addon_test.rb
index 63213552..510cc22b 100644
--- a/test/ruby_lsp_rails/addon_test.rb
+++ b/test/ruby_lsp_rails/addon_test.rb
@@ -92,6 +92,35 @@ class AddonTest < ActiveSupport::TestCase
ensure
T.must(outgoing_queue).close
end
+... | "Migrations are pending" popup is too aggressive
I often am running `bin/rails g migration SomeMigration` to get a blank migration and then writing it my editor instead of the generator. When I do this, the "Migrations are pending" popup immediately displays and asks me to run the (empty) migration.
From my perspectiv... | Hi Matt, thank you for the suggestion. We will consider some options for this.
@swanson We discussed as a team and are considering this approach:
We won't prompt to run the migrations if the most recent migration is empty.
A migration would be considered empty if it has no methods:
```
class CreateFoo < ActiveRecord... | Hi Matt, thank you for the suggestion. We will consider some options for this.
@swanson We discussed as a team and are considering this approach:
We won't prompt to run the migrations if the most recent migration is empty.
A migration would be considered empty if it has no methods:
```
class CreateFoo < ActiveRecord... | [
"https://github.com/Shopify/ruby-lsp-rails/commit/bbde54c732a217c2000c01b680c7f1fe31bd6b1d"
] | 2025-02-03T20:39:22 | 0.0 | Ruby |
jekyll/jekyll | 9,304 | jekyll__jekyll-9304 | [
9234
] | ecf098580d2362540a2627d8f663446458563b16 | diff --git a/lib/jekyll/commands/serve.rb b/lib/jekyll/commands/serve.rb
index 4600130f45c..e54542ff537 100644
--- a/lib/jekyll/commands/serve.rb
+++ b/lib/jekyll/commands/serve.rb
@@ -274,12 +274,19 @@ def launch_browser(server, opts)
def boot_or_detach(server, opts)
if opts["detach"]
... | diff --git a/test/test_commands_serve.rb b/test/test_commands_serve.rb
index fe9d972cd4a..b7828b010b2 100644
--- a/test/test_commands_serve.rb
+++ b/test/test_commands_serve.rb
@@ -313,4 +313,36 @@ def serve(opts)
@merc.execute(:serve, "watch" => false)
end
end
+
+ context "using --detach" do
+ setup... | [Bug]: serve --detach doesn't detach
### Operating System
macOS 12.6.2
### Ruby Version
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-darwin21]
### Jekyll Version
jekyll 4.3.1
### GitHub Pages Version
_No response_
### Expected Behavior
I expected following commands to work after jekyll detaches:
```... | [
"https://github.com/jekyll/jekyll/commit/80e8f451af12d37530a6eaf608d80ffcb823b10e",
"https://github.com/jekyll/jekyll/commit/5fe8800270d1c0f08007693080dafdede10486f1"
] | 2023-02-14T23:07:19 | 3.1 | Ruby | ||
jekyll/jekyll | 9,292 | jekyll__jekyll-9292 | [
9289
] | 66e6b2f2d3fdc52b046ed5ee61f54fd725f80a72 | diff --git a/lib/jekyll/filters.rb b/lib/jekyll/filters.rb
index 5422d52a492..7a79eec9eb6 100644
--- a/lib/jekyll/filters.rb
+++ b/lib/jekyll/filters.rb
@@ -441,6 +441,14 @@ def read_liquid_attribute(liquid_data, property)
property.split(".").reduce(liquid_data) do |data, key|
data.respond_to?(:[]) && d... | diff --git a/test/test_filters.rb b/test/test_filters.rb
index ee9b31af036..8992e76f5be 100644
--- a/test/test_filters.rb
+++ b/test/test_filters.rb
@@ -958,6 +958,18 @@ def to_liquid
results = @filter.where(SelectDummy.new, "obj", "1 == 1")
assert_equal [], results
end
+
+ should "gracefu... | [Bug]: Unexpected crash: filters.rb:442:in `read_liquid_attribute': no implicit conversion of String into Integer
### Operating System
OSX
### Ruby Version
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin21]
### Jekyll Version
jekyll 4.2.1
### GitHub Pages Version
_No response_
### Expected Behavior... | This is technically a bug at your end.
You have total control over `site.data.structuredefinitions` and how you consume it.
All top-level values of `structuredefinitions.json` are Hashes or *objects* except for the last value which is an Array.
Jekyll's `where` filter traverses given object by calling `[]` on each t... | This is technically a bug at your end.
You have total control over `site.data.structuredefinitions` and how you consume it.
All top-level values of `structuredefinitions.json` are Hashes or *objects* except for the last value which is an Array.
Jekyll's `where` filter traverses given object by calling `[]` on each t... | [
"https://github.com/jekyll/jekyll/commit/5c959aed0ca8e5ca42fe1169e0fb6096702ef530",
"https://github.com/jekyll/jekyll/commit/24df38d3852e168efb36e42882b9586ce713466d",
"https://github.com/jekyll/jekyll/commit/e9f5d3f657b81a7d50baeb6f9c8e46bcdad1a0d9",
"https://github.com/jekyll/jekyll/commit/9e680e976228bf1f1... | 2023-02-05T18:48:17 | 3.1 | Ruby |
jekyll/jekyll | 9,659 | jekyll__jekyll-9659 | [
9636
] | 37b4a4bd89e09b47ae42492a1dd2cb74c8a1c95a | diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index a6f9434cb94..3077f286f1c 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -65,8 +65,6 @@
# @jekyll/stability
Gemfile @jekyll/stability
*.gemspec @jekyll/stability
-.travis.yml ... | diff --git a/test/helper.rb b/test/helper.rb
index 37258e46b60..f6b1f925199 100644
--- a/test/helper.rb
+++ b/test/helper.rb
@@ -93,6 +93,37 @@ def temp_dir(*subdirs)
end
end
+module Jekyll
+ #
+ # --- NOTE: ---
+ #
+ # This monkey-patch was introduced because GitHub Actions on Windows acknowledges symlinked ... | [Bug]: CI Appveyor 2.7 builds fail
### Operating System
Windows
### Ruby Version
Environment: RUBY_FOLDER_VER=27, TZINFO_VERSION=~> 1.2, TEST_SUITE=test
### Jekyll Version
jekyll 4.3.3
### GitHub Pages Version
Latest
### Expected Behavior
I expected a green build, perhaps only using non-EOL'd Ruby versions.
#... | Hi,
Since there's a successful test run with Ruby 2.7 via GitHub Actions, we could consider doing away with AppVeyor entirely and add a couple of Windows-based jobs to the existing CI workflow.
(*Subject to approval of active maintainers here*)
> Since there's a successful test run with Ruby 2.7 via GitHub Actions
... | Hi,
Since there's a successful test run with Ruby 2.7 via GitHub Actions, we could consider doing away with AppVeyor entirely and add a couple of Windows-based jobs to the existing CI workflow.
(*Subject to approval of active maintainers here*)
> Since there's a successful test run with Ruby 2.7 via GitHub Actions
... | [
"https://github.com/jekyll/jekyll/commit/896df1bd5253bd27d661fafb5a74bd56caf7d6c5",
"https://github.com/jekyll/jekyll/commit/5f4057674d898bc424ce5620a5c45a2d74cdb223",
"https://github.com/jekyll/jekyll/commit/7aba487a941385a1d17d6bd8c31a97072cfa80ec",
"https://github.com/jekyll/jekyll/commit/5a07d892697e0cff7... | 2024-09-02T16:00:54 | 3.1 | Ruby |
jekyll/jekyll | 9,762 | jekyll__jekyll-9762 | [
9761
] | 33e8a84a0033bf150754a48c4da1ec5eaff89a03 | diff --git a/lib/jekyll/frontmatter_defaults.rb b/lib/jekyll/frontmatter_defaults.rb
index fb024fa9d52..5ad896b287c 100644
--- a/lib/jekyll/frontmatter_defaults.rb
+++ b/lib/jekyll/frontmatter_defaults.rb
@@ -109,7 +109,7 @@ def applies_path?(scope, path)
sanitized_path = sanitize_path(path)
if rel_scop... | diff --git a/test/source/gathering/_staff/admins/backend/gamma.svg b/test/source/gathering/_staff/admins/backend/gamma.svg
deleted file mode 100644
index 861641a7ff3..00000000000
--- a/test/source/gathering/_staff/admins/backend/gamma.svg
+++ /dev/null
@@ -1,1 +0,0 @@
-<svg></svg>
diff --git a/test/source/gathering/_s... | [Bug]: Permalink patterns changed/broken between Jekyll 4.3.4 and 4.4.0
### Operating System
Debian GNU/Linux 12 (bookworm)
### Ruby Version
ruby 3.3.6 (2024-11-05 revision 75015d4c1f) [x86_64-linux]
### Jekyll Version
jekyll 4.4.0
### GitHub Pages Version
Latest
### Expected Behavior
I had expected the permal... | [
"https://github.com/jekyll/jekyll/commit/efa786784bc3bbf239f2f88a092dadd8bc890719"
] | 2025-01-29T12:17:48 | 3.1 | Ruby | ||
jekyll/jekyll | 9,850 | jekyll__jekyll-9850 | [
9848
] | 55024b37aee2afff8004cc01cd0d38b0ec2bf0e3 | diff --git a/lib/jekyll/url.rb b/lib/jekyll/url.rb
index aeb2ac0d867..d57352c4361 100644
--- a/lib/jekyll/url.rb
+++ b/lib/jekyll/url.rb
@@ -144,7 +144,13 @@ def self.escape_path(path)
# pct-encoded = "%" HEXDIG HEXDIG
# sub-delims = "!" / "$" / "&" / "'" / "(" / ")"
# / "*... | diff --git a/test/test_url.rb b/test/test_url.rb
index 859babd4574..430789aa4a2 100644
--- a/test/test_url.rb
+++ b/test/test_url.rb
@@ -80,5 +80,16 @@ class TestURL < JekyllUnitTest
).to_s
end
end
+
+ should "not treat colons in placeholders as uri delimiters" do
+ assert_equal "/foo/foo%2... | [Bug]: Jekyll::URL.escape_path interprets colons as protocol scheme
### Operating System
Alpine 3.13
### Ruby Version
ruby 3.1.5p252 (2024-04-23 revision 1945f8dc0e) [x86_64-linux-musl]
### Jekyll Version
jekyll 4.2.2
### GitHub Pages Version
_No response_
### Expected Behavior
I'm migrating a site and while g... | Hello @fauno
I am onboard with the idea of patching `Jekyll::URL` to use `Addressable::URI::encode_component` instead of `Addressable::URI::encode` since relying only on `:encode` is a deficiency as per this bug report.
| Hello @fauno
I am onboard with the idea of patching `Jekyll::URL` to use `Addressable::URI::encode_component` instead of `Addressable::URI::encode` since relying only on `:encode` is a deficiency as per this bug report.
| [
"https://github.com/jekyll/jekyll/commit/9bfff521324543fcda992405b6d69981079c476e",
"https://github.com/jekyll/jekyll/commit/95cf9efc2ac8b65f62b03c6f8da6ec8f457e0e85",
"https://github.com/jekyll/jekyll/commit/308298c59c205ab101b08481536775abca4a4c8f",
"https://github.com/jekyll/jekyll/commit/667e2be7ce3228dd0... | 2025-07-07T15:55:02 | 3.1 | Ruby |
primer/view_components | 3,740 | primer__view_components-3740 | [
3741
] | c9e70797c8c939a65cb5b3e5a8c6cbbfe909ab87 | diff --git a/.changeset/rotten-banks-speak.md b/.changeset/rotten-banks-speak.md
new file mode 100644
index 0000000000..4e3ab4edc6
--- /dev/null
+++ b/.changeset/rotten-banks-speak.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': minor
+---
+
+Add `disable_expand` param to AvatarStack for React component parity
diff... | diff --git a/test/components/beta/avatar_stack_test.rb b/test/components/beta/avatar_stack_test.rb
index 164dccb78d..39f51b3dc6 100644
--- a/test/components/beta/avatar_stack_test.rb
+++ b/test/components/beta/avatar_stack_test.rb
@@ -109,4 +109,18 @@ def test_renders_three_plus_avatar_stack
end
end
end
... | AvatarStack doesn't have `disable_expand` functionality
AvatarStack doesn't have the `disable_expand` functionality that the matching React component [does](https://github.com/primer/react/blob/main/packages/react/src/AvatarStack/AvatarStack.tsx#L24). It would nice to have parity here for a uniform experience when us... | Hello @sarahkemi ! Unfortunately we won't be able to find engineering capacity to make these changes, but our PVC release conductor for this week @jonrohan is happy to help with any release stuff relating to your linked PR
| [
"https://github.com/primer/view_components/commit/7354d18368565a182b2f7fd1acd9e85f2b6aaad1",
"https://github.com/primer/view_components/commit/cbac8b13b26c95b9d24321d54c65387c259680cf",
"https://github.com/primer/view_components/commit/d351a53704a960aabaef967cf23a0b6f832f47fe",
"https://github.com/primer/view... | 2025-10-17T21:31:36 | 0.0 | Ruby | |
primer/view_components | 2,025 | primer__view_components-2025 | [
1986
] | b47a37811147af663358cb055fe9ac79701caf43 | diff --git a/.changeset/tidy-plums-pay.md b/.changeset/tidy-plums-pay.md
new file mode 100644
index 0000000000..72cbfbbdb7
--- /dev/null
+++ b/.changeset/tidy-plums-pay.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Preserve aria-label when `Primer::Beta::IconButton` `show_tooltip` is false
diff --gi... | diff --git a/test/components/primer/beta/icon_button_test.rb b/test/components/primer/beta/icon_button_test.rb
index 561efad109..371321d2fc 100644
--- a/test/components/primer/beta/icon_button_test.rb
+++ b/test/components/primer/beta/icon_button_test.rb
@@ -32,4 +32,9 @@ def test_allows_hiding_tooltip
refute_sele... | Can't set `aria-label` on `IconButton` if tooltips are disabled
👋 Hello! I noticed an issue with the `IconButton` component in that you can't set an `aria-label` attribute on the button if you also pass in `show_tooltip: false`.
**Steps to reproduce**
In the following example, one would expect to be able to set an ... | 👋 @strackoverflow would you be down to pair with @joelhawksley to upstream a fix for this?
Sure thing! I can coordinate with Joel on this.
| 👋 @strackoverflow would you be down to pair with @joelhawksley to upstream a fix for this?
Sure thing! I can coordinate with Joel on this.
| [
"https://github.com/primer/view_components/commit/9e455ab3a6eafbfc49b8fedb6f1a7ce3277a51ca",
"https://github.com/primer/view_components/commit/77a2d74f2ba2bcb90dfaab53feb17d6836cefb9e",
"https://github.com/primer/view_components/commit/8193ef0483d1f4446bab99aef9df22953f800b8a"
] | 2023-05-22T19:23:21 | 0.0 | Ruby |
primer/view_components | 3,447 | primer__view_components-3447 | [
3446
] | bffaec9ccbd915eb608c6675da97aa73749af1c4 | diff --git a/.changeset/hip-cherries-glow.md b/.changeset/hip-cherries-glow.md
new file mode 100644
index 0000000000..1b4e4a6562
--- /dev/null
+++ b/.changeset/hip-cherries-glow.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Add a new custom label for close button in dialog header
diff --git a/app/co... | diff --git a/test/components/primer/alpha/dialog_test.rb b/test/components/primer/alpha/dialog_test.rb
index 6302936c28..f4a3a2f970 100644
--- a/test/components/primer/alpha/dialog_test.rb
+++ b/test/components/primer/alpha/dialog_test.rb
@@ -129,6 +129,20 @@ def test_renders_footer_with_divider_if_show_divider_is_true... | The Dialog component lacks a custom ARIA label for its close button
### UseCase
As a screen reader user which has a language setup other than English,
I want to hear the label of dialog close button in my custom language,
so that I can easily understand which action it does.
### Problem
Currently, it is not possible t... | [
"https://github.com/primer/view_components/commit/5d5cb589f2fd557a22b5925a57a9095a994ff25c",
"https://github.com/primer/view_components/commit/d59830bcf2f6547a1032395140b2ceff76b3fd50",
"https://github.com/primer/view_components/commit/c14226639bf7b0b8cc746c84f6617af788a1ea68",
"https://github.com/primer/view... | 2025-04-15T13:40:22 | 0.0 | Ruby | ||
primer/view_components | 3,205 | primer__view_components-3205 | [
3195
] | f24feab6546fe1ae6be5938fbd42fb1daebf3951 | diff --git a/.changeset/seven-experts-return.md b/.changeset/seven-experts-return.md
new file mode 100644
index 0000000000..27c4dc91c7
--- /dev/null
+++ b/.changeset/seven-experts-return.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Ensure `full_width:` option is respected by the auto_complete input... | diff --git a/test/lib/primer/forms/auto_complete_input_test.rb b/test/lib/primer/forms/auto_complete_input_test.rb
index 6c91285227..a750d2247f 100644
--- a/test/lib/primer/forms/auto_complete_input_test.rb
+++ b/test/lib/primer/forms/auto_complete_input_test.rb
@@ -36,4 +36,28 @@ def test_only_primer_error_markup
... | Setting properties on a form control when using the form builder
I am trying to use the autocomplete component from within a form builder:
```ruby
class MyForm < ApplicationForm
form do |form|
form.auto_complete(
name: :skills,
label: "Skills",
placeholder: "Search skills library",
... | Uh oh! @dereke, the image you shared is missing helpful alt text. Check your issue body.
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.
Learn more ab... | Uh oh! @dereke, the image you shared is missing helpful alt text. Check your issue body.
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.
Learn more ab... | [
"https://github.com/primer/view_components/commit/9e7822a00e28d65b388af7126b109e20923ccaee",
"https://github.com/primer/view_components/commit/52c26c33abf92c67f85629315c9e3f3a99eed783"
] | 2024-11-21T22:31:47 | 0.0 | Ruby |
primer/view_components | 3,072 | primer__view_components-3072 | [
3073
] | 96b42db2e0c0402008d2e00851e481d993b1506e | diff --git a/.changeset/curvy-apes-judge.md b/.changeset/curvy-apes-judge.md
new file mode 100644
index 0000000000..649f7fd5b2
--- /dev/null
+++ b/.changeset/curvy-apes-judge.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': minor
+---
+
+[Forms] Fix position of caption for checkbox and radio groups
diff --git a/app/... | diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/check_box_group/with_caption/default.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/check_box_group/with_caption/default.png
index b98885780c..02c19c38d0 100644
Binary files a/.playwright/screenshots/snapshots.test.ts-... | Check box group: documented anatomy doesn't match what actually gets rendered
## Summary
Currently, there's not any way to configure the "position" of the Caption to match what's in its documented Anatomy. 😅
The Primer Docs' [anatomy of a checkbox group](https://primer.style/components/checkbox-group#anatomy) order... | https://github.com/primer/view_components/pull/3072 is targeted to address this 🎯
| [
"https://github.com/primer/view_components/commit/933cb6ec883baff59832a1b3daaeed041d33aab4",
"https://github.com/primer/view_components/commit/a9e03588a6803adf5de21ee44cb4a563f49c203b",
"https://github.com/primer/view_components/commit/c955e8fe748f8e9e22cb1cc77388566ec642f2c9",
"https://github.com/primer/view... | 2024-09-09T21:11:38 | 0.0 | Ruby | |
JEG2/highline | 272 | JEG2__highline-272 | [
271
] | 3e7c9dcc1c60ca977ad184604cd695a3025af8b4 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index ae4eaf7..e149742 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -36,7 +36,7 @@ jobs:
ruby-version: '3.3'
runs-on: ${{ matrix.os }}
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@... | diff --git a/test/acceptance/at_readline.rb b/test/acceptance/at_readline.rb
index 5167394..fd5a63a 100644
--- a/test/acceptance/at_readline.rb
+++ b/test/acceptance/at_readline.rb
@@ -17,7 +17,7 @@
"that begins with the 'l' letter in this particular case.\n\n" \
"If I don't type any character but press <TAB>... | `ask()` causes `Readline`-related error on Ruby 3.3
On Ruby 3.3, `ask()` causes the following error:
```
/path/to/gems/ruby-3.3.1/gems/highline-3.0.1/lib/highline/terminal.rb:115:in `readline_read': uninitialized constant HighLine::Terminal::Readline (NameError)
Readline.completion_proc = lambda do |str|... | Thanks for reporting it. I'll take a look at it as soon as possible. I'll keep you informed.
At [Ruby 3.3.0 release note](https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/) we have:
```
Stdlib compatibility issues
ext/readline is retired
We have reline that is pure Ruby implementation compatib... | Thanks for reporting it. I'll take a look at it as soon as possible. I'll keep you informed.
At [Ruby 3.3.0 release note](https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/) we have:
```
Stdlib compatibility issues
ext/readline is retired
We have reline that is pure Ruby implementation compatib... | [
"https://github.com/JEG2/highline/commit/685a39412cb3ac011ac199adf4981852dc18f29b",
"https://github.com/JEG2/highline/commit/96f9d38cb958b413e1bbfe3f9a457b23032bde4b",
"https://github.com/JEG2/highline/commit/247eae8aef2154239fe863c62f1540760162d5a4",
"https://github.com/JEG2/highline/commit/b64a9dfeda7d4f869... | 2024-07-15T14:54:00 | 2.1 | Ruby |
JEG2/highline | 257 | JEG2__highline-257 | [
233
] | 49eed912b0113b3b9c0949f0ef056f390ed359ba | diff --git a/Changelog.md b/Changelog.md
index fb665c2..9a86f8a 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -2,6 +2,10 @@
Below is a complete listing of changes for each revision of HighLine.
+### Unreleased 2.2.0.develop.1
+* I #233 Show Question#default hint for non String values (@abinoam)
+ * Add Question... | diff --git a/test/test_highline.rb b/test/test_highline.rb
index e623305..13ff406 100755
--- a/test/test_highline.rb
+++ b/test/test_highline.rb
@@ -817,17 +817,47 @@ def test_default_with_Symbol
end
def test_default_with_non_String_objects
- # With a non-string object, it should not show
+ # With a non-s... | default value has to be a string
I'm not sure this is intentional.
The default value for ask has to be a string, if it is an integer, it is silently ignored.
Tested with v1.7.10
This was not the case prior to v1.7.0
Demo:
```
require 'highline' ... | Hi @branch14 ,
I don't plan to patch 1.7-stable branch anymore.
I couldn't reproduce the issue at 2.0 branch.
@branch14 today we have officially released 2.0.0 version!
I'll close this issue, but feel free to reopen it if you think it's necessary.
Thank you very much for your feedback! 👍
Thank you for your ... | Hi @branch14 ,
I don't plan to patch 1.7-stable branch anymore.
I couldn't reproduce the issue at 2.0 branch.
@branch14 today we have officially released 2.0.0 version!
I'll close this issue, but feel free to reopen it if you think it's necessary.
Thank you very much for your feedback! 👍
Thank you for your ... | [
"https://github.com/JEG2/highline/commit/078490a4b250008b0f762bceae67018f5f1864f9",
"https://github.com/JEG2/highline/commit/bf7ad58dceb5eba1b54461c402375cb711468b2c",
"https://github.com/JEG2/highline/commit/b4067e75b620573238115a6f7252ffeaaf9672cc"
] | 2023-01-01T17:07:31 | 2.1 | Ruby |
JEG2/highline | 278 | JEG2__highline-278 | [
277
] | 8c99b67dd3515c991029eb5135254a9f5aec34d6 | diff --git a/Changelog.md b/Changelog.md
index 7ac826b..ec452ef 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -2,6 +2,9 @@
Below is a complete listing of changes for each revision of HighLine.
+### 3.1.2 / 2025-01-05
+* PR #278 - Prevent ArgumentError for #col_count_calculate when items exceed 80 chars (@davidjk... | diff --git a/test/test_highline.rb b/test/test_highline.rb
index bd420c5..c9a4883 100755
--- a/test/test_highline.rb
+++ b/test/test_highline.rb
@@ -1024,6 +1024,17 @@ def test_lists
@output.truncate(@output.rewind)
+ colums_of_81 = ["1234567890" * (81 / 10) + "1"]
+
+ @terminal.say("<%= list(#{colums_of... | Default to 1 column if col_count_calculate returns 0
@justintsteele and I found this issues when 81+ length entries were in the array
Seen in version 2.1.0 but should be valid for the current latest 3.1.1 as well.
## Issue Seen
When the passed array has entries over 80 chars with `:columns_down`.
```
irb(mai... | Thanks for spotting it.
Would you like to open a PR? I'd be glad to merge and release.
But, if you're busy or something, just tell me that I'll try to do it by myself.
> Thanks for spotting it.
>
> Would you like to open a PR? I'd be glad to merge and release.
>
> But, if you're busy or something, just tell... | Thanks for spotting it.
Would you like to open a PR? I'd be glad to merge and release.
But, if you're busy or something, just tell me that I'll try to do it by myself.
> Thanks for spotting it.
>
> Would you like to open a PR? I'd be glad to merge and release.
>
> But, if you're busy or something, just tell... | [
"https://github.com/JEG2/highline/commit/b259640ae848b9900901a9996e8fbdc8d1fefcb1",
"https://github.com/JEG2/highline/commit/238a5eab09afd68c35be337e609d001c7289316e",
"https://github.com/JEG2/highline/commit/035ecfc9b941abd0122b59824955152b1598c705"
] | 2025-01-05T23:09:53 | 2.1 | Ruby |
JEG2/highline | 256 | JEG2__highline-256 | [
249
] | 33cee8a7a7946e27b3be8459721f69c73eee7694 | diff --git a/lib/highline/question/answer_converter.rb b/lib/highline/question/answer_converter.rb
index 76558aeb..6a4585c2 100644
--- a/lib/highline/question/answer_converter.rb
+++ b/lib/highline/question/answer_converter.rb
@@ -9,7 +9,7 @@ class AnswerConverter
extend Forwardable
def_delegators :@que... | diff --git a/test/test_highline.rb b/test/test_highline.rb
index 67d8fade..e6233059 100755
--- a/test/test_highline.rb
+++ b/test/test_highline.rb
@@ -1358,6 +1358,25 @@ def test_range_requirements
"? ", @output.string)
end
+ def test_range_requirements_with_array_of_strings
+ @input.trunca... | Have to set convert type in order for `.in` to work with array
If you do this, no validation happens:
```Ruby
ask('Letter a, b, or c? ') { |q| q.in = %w[ a b c ] }
```
You can enter in `d`, and it accepts the input.
In order for it to work, you have to pass in `String`:
```Ruby
ask('Letter a, b, or c? ',... | [
"https://github.com/JEG2/highline/commit/b999371c828c73d17b96fbb30a55a86c9ac861ef",
"https://github.com/JEG2/highline/commit/9577a874e8d296206d943f05cb415efa26521d36",
"https://github.com/JEG2/highline/commit/f147388e42c592cf2a6930956c6160970f519d04"
] | 2023-01-01T01:29:07 | 2.1 | Ruby | ||
JEG2/highline | 258 | JEG2__highline-258 | [
246
] | ee18153d63db64242fdbf467a89774c9627d54d5 | diff --git a/Changelog.md b/Changelog.md
index 9a86f8a7..cafba856 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -3,7 +3,11 @@
Below is a complete listing of changes for each revision of HighLine.
### Unreleased 2.2.0.develop.1
-* I #233 Show Question#default hint for non String values (@abinoam)
+* PR #258 / I #2... | diff --git a/test/test_highline.rb b/test/test_highline.rb
index 13ff406c..8de8551d 100755
--- a/test/test_highline.rb
+++ b/test/test_highline.rb
@@ -1626,6 +1626,55 @@ def test_validation
assert_equal("Gray, James Edward", answer)
end
+ class ZeroToTwentyFourValidator
+ def self.valid?(answer)
+ (0... | Possible to accept multiple selections with `.in` and `.default`?
Currently I have
```ruby
# trimmed: puts menu items
cli.ask("Which number? (0 or <Enter> to skip): ", Integer) { |q|
q.in = 0..(possibleSelections.length)
q.default = 0
}
```
This is awesome for choosing multiple items from a list, suc... | Dear @Joshfindit,
Sorry, for the late answer.
I'm not sure I could understand the problem you have stated correctly.
Could you please clarify it? (Note that I'm not a native english speaker)
Best regards
Perhaps it would be easier for me to understand if you provide a complete code snipped that I could try to... | Dear @Joshfindit,
Sorry, for the late answer.
I'm not sure I could understand the problem you have stated correctly.
Could you please clarify it? (Note that I'm not a native english speaker)
Best regards
Perhaps it would be easier for me to understand if you provide a complete code snipped that I could try to... | [
"https://github.com/JEG2/highline/commit/1113451a2ea6832b7aa54374947ddf945b7a44c0",
"https://github.com/JEG2/highline/commit/b5543d973bbc638e83b9f835969b5fb7de96cd94",
"https://github.com/JEG2/highline/commit/ce3481d8c2fb48e7ced5260ffdddbb30d024f11c",
"https://github.com/JEG2/highline/commit/5b785aca521b1a384... | 2023-01-02T21:52:01 | 2.1 | Ruby |
sidekiq/sidekiq | 6,880 | sidekiq__sidekiq-6880 | [
6878
] | 4f368fddecf22fdd7334c44a81f83f0852936234 | diff --git a/lib/sidekiq/job_retry.rb b/lib/sidekiq/job_retry.rb
index 2d4e3b306..a4e9d679c 100644
--- a/lib/sidekiq/job_retry.rb
+++ b/lib/sidekiq/job_retry.rb
@@ -178,10 +178,14 @@ def process_retry(jobinst, msg, queue, exception)
msg["error_backtrace"] = compress_backtrace(lines)
end
- return ... | diff --git a/test/retry_test.rb b/test/retry_test.rb
index c0d04eb6c..94bf1cb19 100644
--- a/test/retry_test.rb
+++ b/test/retry_test.rb
@@ -147,6 +147,22 @@ def job
assert_equal 172800, rfj["retry_for"]
end
+ it "retry_for ignores max_retries setting" do
+ # Set a low max_retries that would norma... | Setting default retry and overriding the options should make sense
### Discussed in https://github.com/sidekiq/sidekiq/discussions/6875
<div type='discussions-op-text'>
<sup>Originally posted by **araishikeiwai** November 26, 2025</sup>
Hi team,
I have faced a surprise in my application that when `Sidekiq.default... | Sidekiq should exclusively use either `retry_for` or `retry` and not mix both within the same logic.
| Sidekiq should exclusively use either `retry_for` or `retry` and not mix both within the same logic.
| [
"https://github.com/sidekiq/sidekiq/commit/7b204c510ad53cda528f0e11eed4a78f80324377"
] | 2025-12-03T01:16:20 | 0.0 | Ruby |
sidekiq/sidekiq | 6,482 | sidekiq__sidekiq-6482 | [
6481
] | 626b4bfbdf9c68889697353cffd9b2d12f9912af | diff --git a/Changes.md b/Changes.md
index 4916962064..7747e2a2de 100644
--- a/Changes.md
+++ b/Changes.md
@@ -5,6 +5,10 @@
HEAD
----------
+- Reimplement `retry_all` and `kill_all` API methods to use ZPOPMIN,
+ approximately 30-60% faster. [#6481]
+- Add preload testing binary at `examples/testing/sidekiq_boot` t... | diff --git a/test/api_test.rb b/test/api_test.rb
index 57d1028939..6ba8a88646 100644
--- a/test/api_test.rb
+++ b/test/api_test.rb
@@ -724,13 +724,6 @@ class JobWithTags
assert_equal 1, ps.size
assert_equal 1, ps.to_a.size
end
-
- def add_retry(jid = "bob", at = Time.now.to_f)
- payload = Sid... | Dead queue stuck in retry loop after hitting "Retry All"
Ruby version: 3.2.5
Rails version: 7.1.4.1
Sidekiq / Pro / Enterprise version(s): sidekiq-pro 5.5.8
Dead queue sometimes gets stuck in a retry loop after hitting "Retry All" from the Dead page on Sidekiq UI. The dead jobs are enqueued & run, end up in the de... | Brainstorming here...
Since the score of any new entries to the Dead set should be strictly larger than any existing score, we should be able to add logic like "break after enqueuing N elements" where N is the size at the start of the loop, instead of looping until size = 0.
PRs welcome, I'm working on Faktory ri... | Brainstorming here...
Since the score of any new entries to the Dead set should be strictly larger than any existing score, we should be able to add logic like "break after enqueuing N elements" where N is the size at the start of the loop, instead of looping until size = 0.
PRs welcome, I'm working on Faktory ri... | [
"https://github.com/sidekiq/sidekiq/commit/4f537f72ea392d2322087e32240c02c0e8fe3b44",
"https://github.com/sidekiq/sidekiq/commit/df552323fbb31c8890a939bcd10a0c6171d7ccad",
"https://github.com/sidekiq/sidekiq/commit/288f1d5d1c57f4b74cd99766dfd4e7fdf2e3176b",
"https://github.com/sidekiq/sidekiq/commit/4bf6255a6... | 2024-10-30T00:26:12 | 0.0 | Ruby |
sidekiq/sidekiq | 6,552 | sidekiq__sidekiq-6552 | [
6546
] | 7239276d85089e9a19c2642584bf6fa5a53224dc | diff --git a/lib/sidekiq/client.rb b/lib/sidekiq/client.rb
index 16580a19a9..2a4fb6a118 100644
--- a/lib/sidekiq/client.rb
+++ b/lib/sidekiq/client.rb
@@ -269,14 +269,16 @@ def atomic_push(conn, payloads)
[at, Sidekiq.dump_json(hash)]
})
else
- queue = payloads.first["queue"]
... | diff --git a/test/client_test.rb b/test/client_test.rb
index 2032874dae..85efbe8783 100644
--- a/test/client_test.rb
+++ b/test/client_test.rb
@@ -58,6 +58,13 @@ def call(worker_class, job, queue, redis)
end
end
+class MiddlewareDynamicQueue
+ def call(worker_class, job, queue, redis)
+ job["queue"] = job["ar... | Dealing with perform_bulk and dynamic queues set from a client middleware.
By design, `perform_bulk` will push all the jobs in a single queue since its based on a single worker. In my case, I've a `client_middleware` that will update a job's queue dynamically based on its args. This works perfectly when calling `perfor... | PRs welcome but this seems like not much value for the increase in code complexity.
| PRs welcome but this seems like not much value for the increase in code complexity.
| [
"https://github.com/sidekiq/sidekiq/commit/214eb333e1bd94d7ab58402cdf0136b68900f768",
"https://github.com/sidekiq/sidekiq/commit/63983558dbbf30a06ecfb823f4aa98170932f4cb"
] | 2024-12-16T21:54:13 | 0.0 | Ruby |
sidekiq/sidekiq | 6,307 | sidekiq__sidekiq-6307 | [
6306
] | e798c23643cd7d3f3b229016a87fec2bfeb7905a | diff --git a/lib/sidekiq/middleware/current_attributes.rb b/lib/sidekiq/middleware/current_attributes.rb
index 80cbe9590e..3b52536c37 100644
--- a/lib/sidekiq/middleware/current_attributes.rb
+++ b/lib/sidekiq/middleware/current_attributes.rb
@@ -46,22 +46,26 @@ def initialize(cattrs)
end
def call(_, jo... | diff --git a/test/current_attributes_test.rb b/test/current_attributes_test.rb
index dab008cb0e..15aa8bb08b 100644
--- a/test/current_attributes_test.rb
+++ b/test/current_attributes_test.rb
@@ -14,6 +14,13 @@ class OtherCurrent < ActiveSupport::CurrentAttributes
end
end
+class CurrentAttributesJob
+ include Sid... | Current attributes lost after inline execution
Ruby version: 3.3.0
Rails version: 7.1.1
Sidekiq / Pro / Enterprise version(s): 7.2.4
While upgrading from Sidekiq 6 to 7, we ran into this problem through our tests. We have Sidekiq jobs which themselves call `perform_async` and found that the parent job lost their c... | Would you like to work on a PR?
Looks good, I prefer the recursion solution.
| Would you like to work on a PR?
Looks good, I prefer the recursion solution.
| [
"https://github.com/sidekiq/sidekiq/commit/c7678e5d406cc24bd4387a46c13d6299f96f773a"
] | 2024-05-23T20:19:48 | 0.0 | Ruby |
sidekiq/sidekiq | 6,510 | sidekiq__sidekiq-6510 | [
6509
] | 2ae94cef5f30623801369e7dd344891248aa90c2 | diff --git a/lib/sidekiq/middleware/current_attributes.rb b/lib/sidekiq/middleware/current_attributes.rb
index 7309a847b8..b33cf5e5c2 100644
--- a/lib/sidekiq/middleware/current_attributes.rb
+++ b/lib/sidekiq/middleware/current_attributes.rb
@@ -1,5 +1,6 @@
# frozen_string_literal: true
+require "active_job/argumen... | diff --git a/test/current_attributes_test.rb b/test/current_attributes_test.rb
index b31e08f96b..9cc13ada04 100644
--- a/test/current_attributes_test.rb
+++ b/test/current_attributes_test.rb
@@ -21,6 +21,8 @@ def perform
end
end
+Serializer = ActiveJob::Arguments
+
describe "Current attributes" do
before do
... | CurrentAttributes issue/improvement - Serialization
Currently if an app uses current attributes with full objects, such as `Current.organization`, you can run into errors such as:
> NoMethodError: undefined method `name' for "#Organization:0x0000111111111111111":String
I don't see mention of any restrictions usin... | Since this class already assumes Rails, it's ok to use Rails classes and methods, like `AJ::Arguments`.
Will this break existing job data already serialized in Redis? Is there existing code in Rails to hydrate CurrentAttributes that we can copy as a best practice? What does Active Job itself do?
It doesn't break exi... | Since this class already assumes Rails, it's ok to use Rails classes and methods, like `AJ::Arguments`.
Will this break existing job data already serialized in Redis? Is there existing code in Rails to hydrate CurrentAttributes that we can copy as a best practice? What does Active Job itself do?
It doesn't break exi... | [
"https://github.com/sidekiq/sidekiq/commit/09f0eaeb110f262ee16fe123effe444b4ef4407e",
"https://github.com/sidekiq/sidekiq/commit/e9fb7c30b9a452adb1f74006c58e4a7bb3d5cd2d",
"https://github.com/sidekiq/sidekiq/commit/c72c9acada63b054663f82c930d2e1a648234fc1",
"https://github.com/sidekiq/sidekiq/commit/a4e072ecc... | 2024-11-22T00:02:07 | 0.0 | Ruby |
freerange/mocha | 660 | freerange__mocha-660 | [
657
] | e62fa61e086199f7777d70e85371525f6c2afe03 | diff --git a/lib/mocha/parameter_matchers/has_entries.rb b/lib/mocha/parameter_matchers/has_entries.rb
index 1b6d18d81..2b90f34b8 100644
--- a/lib/mocha/parameter_matchers/has_entries.rb
+++ b/lib/mocha/parameter_matchers/has_entries.rb
@@ -30,20 +30,23 @@ def has_entries(entries) # rubocop:disable Naming/PredicateName... | diff --git a/test/acceptance/parameter_matcher_test.rb b/test/acceptance/parameter_matcher_test.rb
index d982539fa..49cb58226 100644
--- a/test/acceptance/parameter_matcher_test.rb
+++ b/test/acceptance/parameter_matcher_test.rb
@@ -11,6 +11,24 @@ def teardown
teardown_acceptance_test
end
+ def test_should_m... | Error on `expects.with` with empty hash argument
How to reproduce:
minitest (5.24.1)
mocha (2.4.2)
rails (6.1.7.8)
Ruby 3.3.0
```ruby
require "test_helper"
class MyKlass
def self.method_accepting_hash(h)
"whatever"
end
end
class MochaErrorTest < ActiveSupport::TestCase
hash_with_value1 ... | workaround is to use block matcher
@floehopper just in case
```ruby
module ParameterMatchers
# @private
class PositionalOrKeywordHash < Base
def matches?(available_parameters)
parameter, is_last_parameter = extract_parameter(available_parameters)
# return false unless HasEntries... | workaround is to use block matcher
@floehopper just in case
```ruby
module ParameterMatchers
# @private
class PositionalOrKeywordHash < Base
def matches?(available_parameters)
parameter, is_last_parameter = extract_parameter(available_parameters)
# return false unless HasEntries... | [
"https://github.com/freerange/mocha/commit/96a85ad7ea5bf433d80575103b281dc21afc8f96",
"https://github.com/freerange/mocha/commit/18448d19c80d70bca657612d3ea5ac9c662c144d",
"https://github.com/freerange/mocha/commit/5e6a07b2710dac76e9346def561ca0d44765bf86"
] | 2024-07-18T16:02:00 | 0.12 | Ruby |
freerange/mocha | 721 | freerange__mocha-721 | [
646
] | e6ea88f4428dea31618769f88b88353809e62ddf | diff --git a/lib/mocha/mockery.rb b/lib/mocha/mockery.rb
index 31839a748..740d697f3 100644
--- a/lib/mocha/mockery.rb
+++ b/lib/mocha/mockery.rb
@@ -49,9 +49,13 @@ def verify(*args)
end
def teardown(origin = nil)
+ if @instances.nil?
+ raise NotInitializedError, 'Mocha::Mockery.teardown ... | diff --git a/test/unit/mockery_test.rb b/test/unit/mockery_test.rb
index f3293b99b..80c467cfd 100644
--- a/test/unit/mockery_test.rb
+++ b/test/unit/mockery_test.rb
@@ -3,6 +3,17 @@
require 'mocha/state_machine'
require 'mocha/expectation_error_factory'
+class MockeryNeverSetupTest < Mocha::TestCase
+ include Moch... | Better error message if `Mockery.teardown` is called when `Mockery.setup` has not been called successfully
This seems to have happened to at least a couple of people in relation to Rails fixtures - see #611. I think we could probably provide a more useful error message if `Mockery.instance` is not set.
| [
"https://github.com/freerange/mocha/commit/b5a89f5669e6852fc0898ac0d9e5ca4ff55aaa49"
] | 2025-01-01T17:23:25 | 0.12 | Ruby | ||
freerange/mocha | 655 | freerange__mocha-655 | [
654
] | 5a3a208ecaee9c4dce7cc38313b543704f0aa3ad | diff --git a/lib/mocha/parameter_matchers/base.rb b/lib/mocha/parameter_matchers/base.rb
index 52725d70e..8c1fa22d8 100644
--- a/lib/mocha/parameter_matchers/base.rb
+++ b/lib/mocha/parameter_matchers/base.rb
@@ -2,11 +2,6 @@ module Mocha
module ParameterMatchers
# @abstract Subclass and implement +#matches?+ a... | diff --git a/test/acceptance/keyword_argument_matching_test.rb b/test/acceptance/keyword_argument_matching_test.rb
index be5861cdf..8988d3905 100644
--- a/test/acceptance/keyword_argument_matching_test.rb
+++ b/test/acceptance/keyword_argument_matching_test.rb
@@ -198,6 +198,24 @@ def test_should_match_keyword_args_wit... | Since #648 `has_entry` no longer matches by exact value
Since https://github.com/freerange/mocha/pull/648, `has_entry`'s behaviour changed:
```ruby
require "bundler/setup"
require "minitest/autorun"
require "mocha/minitest"
require "mocha/mock"
class FooTest < Minitest::Test
def setup
@mock = mock("fo... | @ElvinEfendi Thanks for reporting this - sorry for the slow response - I've been away on leave. I'll take a look as soon as I can.
@ElvinEfendi
I've had an initial look at this and I agree that it is an accidental regression caused by #648.
Many thanks for supplying a test that reproduces the problem.
I've att... | @ElvinEfendi Thanks for reporting this - sorry for the slow response - I've been away on leave. I'll take a look as soon as I can.
@ElvinEfendi
I've had an initial look at this and I agree that it is an accidental regression caused by #648.
Many thanks for supplying a test that reproduces the problem.
I've att... | [
"https://github.com/freerange/mocha/commit/be24b41bf94757b36f536f690714611fbe94a73e",
"https://github.com/freerange/mocha/commit/600ee2aaa769b489034bac070363dd4d8dd418b3",
"https://github.com/freerange/mocha/commit/e9de64e493508457163a060220d3052d031af11f",
"https://github.com/freerange/mocha/commit/3b60b7df3... | 2024-07-12T12:31:12 | 0.12 | Ruby |
freerange/mocha | 695 | freerange__mocha-695 | [
628
] | d1274b3ba4a5bf75e0a1a2d70f0044e4b85a4729 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 1b3e995a6..0fcd7d80f 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -70,7 +70,6 @@ workflows:
matrix:
parameters:
docker-image:
- - ruby:2.1
- ruby:2.2
... | diff --git a/test/acceptance/stubbing_nil_test.rb b/test/acceptance/stubbing_nil_test.rb
deleted file mode 100644
index e7777fb02..000000000
--- a/test/acceptance/stubbing_nil_test.rb
+++ /dev/null
@@ -1,60 +0,0 @@
-require File.expand_path('../acceptance_test_helper', __FILE__)
-require 'mocha/configuration'
-
-class ... | Drop support for Ruby v2.1
This version has been [EOL since 31 Mar 2017](https://www.ruby-lang.org/en/downloads/branches/), i.e. nearly 8 years ago.
| [
"https://github.com/freerange/mocha/commit/c8e81604bdec7d5cb4a8d628584e80ffee2550aa"
] | 2024-12-08T00:29:53 | 0.12 | Ruby | ||
freerange/mocha | 720 | freerange__mocha-720 | [
588
] | a04434f3eb631b261b7614234713723087ed9e0d | diff --git a/lib/mocha/inspect.rb b/lib/mocha/inspect.rb
index 70272c4a4..e5fd11e01 100755
--- a/lib/mocha/inspect.rb
+++ b/lib/mocha/inspect.rb
@@ -28,7 +28,11 @@ def mocha_inspect
end
end.join(', ')
- Hash.ruby2_keywords_hash?(self) ? unwrapped : "{#{unwrapped}}"
+ if Hash.ruby2_ke... | diff --git a/test/unit/hash_inspect_test.rb b/test/unit/hash_inspect_test.rb
index 3a60edffa..dfb20d279 100644
--- a/test/unit/hash_inspect_test.rb
+++ b/test/unit/hash_inspect_test.rb
@@ -19,6 +19,11 @@ def test_should_return_unwrapped_keyword_style_hash_when_keyword_hash
assert_equal 'a: true, b: false', hash.... | Mocking a call with empty keyword arguments fails its parameter validation
Given the following code (a slight change from the example of `with`):
```ruby
object = mock()
object.expects(:expected_method).with(:param1, :param2)
kwargs = {}
object.expected_method(:param1, :param2, **kwargs)
```
This worked fine in ... | @herwinw
Thanks for reporting this. I've managed to reproduce the issue under Ruby v2.7 but not under Ruby 3.1. Is that what you're seeing too?
My initial reaction is surprise that this test passed with Mocha v1.x since as soon as you call `Expectation#with` an invocation needs to match all the expected arguments... | @herwinw
Thanks for reporting this. I've managed to reproduce the issue under Ruby v2.7 but not under Ruby 3.1. Is that what you're seeing too?
My initial reaction is surprise that this test passed with Mocha v1.x since as soon as you call `Expectation#with` an invocation needs to match all the expected arguments... | [
"https://github.com/freerange/mocha/commit/62106cc515aa85d67127b236c8fb8cc41fd7fee7"
] | 2025-01-01T16:41:19 | 0.12 | Ruby |
sinatra/sinatra | 1,922 | sinatra__sinatra-1922 | [
1884
] | 516ee3bc5a256c52e1452009168c2caf2751c5fb | diff --git a/lib/sinatra/base.rb b/lib/sinatra/base.rb
index c3ebf61924..35e22161b7 100644
--- a/lib/sinatra/base.rb
+++ b/lib/sinatra/base.rb
@@ -914,6 +914,35 @@ def compile_block_template(template, options, &body)
end
end
+ # Extremely simple template cache implementation.
+ # * Not thread-safe.
+ # ... | diff --git a/test/sinatra_test.rb b/test/sinatra_test.rb
index 92a30809aa..71a6257539 100644
--- a/test/sinatra_test.rb
+++ b/test/sinatra_test.rb
@@ -7,6 +7,6 @@ class SinatraTest < Minitest::Test
end
it "responds to #template_cache" do
- assert_kind_of Tilt::Cache, Sinatra::Base.new!.template_cache
+ as... | Remove `Tilt::Cache` usage (needed for Tilt 3)
I'm [planning on deprecating `Tilt::Cache`](https://github.com/jeremyevans/tilt/commit/2a021538630138569532f1eb0fe62aec8edd0416) in the next release of tilt (2.2.0), as it isn't used internally, isn't thread safe, and doesn't add any real value (faster to use a plain hash)... | Thanks for the heads-up!
@jeremyevans Just to be clear, Tilt is not following https://semver.org/ and there will continue to be breaking changes in the 2.x series?
Looks like Sinatra (sinatra-contrib) isn't fully compatible with Tilt 2.1.0 that was just released: https://github.com/sinatra/sinatra/actions/runs/4... | Thanks for the heads-up!
@jeremyevans Just to be clear, Tilt is not following https://semver.org/ and there will continue to be breaking changes in the 2.x series?
Looks like Sinatra (sinatra-contrib) isn't fully compatible with Tilt 2.1.0 that was just released: https://github.com/sinatra/sinatra/actions/runs/4... | [
"https://github.com/sinatra/sinatra/commit/3ceafd920638343c59444e1d27550569e24dcbca"
] | 2023-04-20T21:48:34 | 1.0 | Ruby |
sinatra/sinatra | 1,975 | sinatra__sinatra-1975 | [
1973
] | cadbeddf001680a5dfc336cb8b2834c949f754cd | diff --git a/Gemfile b/Gemfile
index 24341b641..caf490ec6 100644
--- a/Gemfile
+++ b/Gemfile
@@ -39,6 +39,7 @@ gem 'traces', '< 0.10.0' if RUBY_VERSION >= '2.6.0' && RUBY_VERSION < '2.7.0'
gem 'asciidoctor'
gem 'builder'
+gem 'childprocess'
gem 'commonmarker', '~> 0.23.4', platforms: [:ruby]
gem 'erubi'
gem 'eve... | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ed55c4b94..4eeb55047 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -71,7 +71,7 @@ jobs:
tilt:
- stable
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3... | Classic Style Application without a `config.ru` does not work with Ruby 3.3 and Bundler 2.5
Steps to reproduce.
Source files:
```ruby
# my_app.rb
require 'sinatra'
get "/ready" do
"ready"
end
```
```ruby
# Gemfile
source 'https://rubygems.org'
gem "sinatra"
gem "webrick"
```
```ruby
# Gemf... | With Ruby 3.2.2 it works fine:
```shell
$ bundle exec ruby my_app.rb
[2023-12-27 23:57:08] INFO WEBrick 1.8.1
[2023-12-27 23:57:08] INFO ruby 3.2.2 (2023-03-30) [x86_64-linux]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-27 23:57:08] INFO WEBrick::HTTPSer... | With Ruby 3.2.2 it works fine:
```shell
$ bundle exec ruby my_app.rb
[2023-12-27 23:57:08] INFO WEBrick 1.8.1
[2023-12-27 23:57:08] INFO ruby 3.2.2 (2023-03-30) [x86_64-linux]
== Sinatra (v3.1.0) has taken the stage on 4567 for development with backup from WEBrick
[2023-12-27 23:57:08] INFO WEBrick::HTTPSer... | [
"https://github.com/sinatra/sinatra/commit/aaa296ed62dfefc382446c4be913c1d544feb1bf",
"https://github.com/sinatra/sinatra/commit/42130956d38ce4796e1f8c4737c9e38ffa908997",
"https://github.com/sinatra/sinatra/commit/57f775929e3c0388b413693bd03f5d315badf36c"
] | 2023-12-29T01:00:34 | 1.0 | Ruby |
sinatra/sinatra | 2,081 | sinatra__sinatra-2081 | [
2076
] | c4b7c04e6d23ef8e17404d64cc731bece268acea | diff --git a/lib/sinatra/base.rb b/lib/sinatra/base.rb
index f0bccd8ae..fe9c0537e 100644
--- a/lib/sinatra/base.rb
+++ b/lib/sinatra/base.rb
@@ -396,11 +396,11 @@ def content_type(type = nil, params = {})
end
params.delete :charset if mime_type.include? 'charset'
unless params.empty?
- mime_... | diff --git a/test/helpers_test.rb b/test/helpers_test.rb
index a856bb912..a028d2e8b 100644
--- a/test/helpers_test.rb
+++ b/test/helpers_test.rb
@@ -706,7 +706,19 @@ def status_app(code, &block)
end
get '/'
- assert_equal 'foo/bar;level=1, charset=utf-8', response['Content-Type']
+ assert_equa... | Built content_type are malformed
I encountered this while looking into https://github.com/prometheus/prometheus/issues/15777. It appears that a comma (`,`) is used as a separator in the `Content-Type` header instead of a semicolon (`;`).
here:
https://github.com/sinatra/sinatra/blob/7b50a1bbb5324838908dfaa00ec53ad3... | I'm not quite sure I get the problem. Can you provide an example Sinatra application and example requests demonstrating the issue?
https://gitlab.com/gitlab-org/ruby/gems/gitlab-exporter/-/blob/f16670c44a4a26393f780512d3ff669aa74d2cf6/lib/gitlab_exporter/web_exporter.rb#L136 which triggers the Prometheus issue I linked... | I'm not quite sure I get the problem. Can you provide an example Sinatra application and example requests demonstrating the issue?
https://gitlab.com/gitlab-org/ruby/gems/gitlab-exporter/-/blob/f16670c44a4a26393f780512d3ff669aa74d2cf6/lib/gitlab_exporter/web_exporter.rb#L136 which triggers the Prometheus issue I linked... | [
"https://github.com/sinatra/sinatra/commit/13c477ac123d743afa03931940d52f1bec8d2c42"
] | 2025-02-03T17:11:51 | 1.0 | Ruby |
sinatra/sinatra | 1,890 | sinatra__sinatra-1890 | [
1889
] | 50b8398dd7bcd5d5c187da51b23a939c5f3de210 | diff --git a/lib/sinatra/base.rb b/lib/sinatra/base.rb
index 9a2cd954c9..4982034b51 100644
--- a/lib/sinatra/base.rb
+++ b/lib/sinatra/base.rb
@@ -317,7 +317,7 @@ def redirect(uri, *args)
# Generates the absolute URI for a given path in the app.
# Takes Rack routers and reverse proxies into account.
def ... | diff --git a/test/helpers_test.rb b/test/helpers_test.rb
index 50ee677872..ee1298b213 100644
--- a/test/helpers_test.rb
+++ b/test/helpers_test.rb
@@ -1845,6 +1845,12 @@ def obj.is_a?(thing) 60.is_a?(thing) end
assert_equal 'http://example.org/foo/bar', body
end
+ it 'handles integer input' do
+ m... | `NoMethodError - undefined method '=~' for 1:Integer`
```ruby
# config.ru
require "sinatra/base"
class App < Sinatra::Base
get "/" do
uri(1)
end
end
run App
```
```
arm64 $ bundle exec puma
Puma starting in single mode...
* Puma version: 6.1.0 (ruby 3.2.1-p31) ("The Way Up")
* Min threads: ... | Before 3.2.0, a warning was printed (if you ran with warnings enabled)
```
arm64 $ RUBYOPT=-W bundle exec puma
Puma starting in single mode...
* Puma version: 6.1.0 (ruby 3.1.3-p185) ("The Way Up")
* Min threads: 0
* Max threads: 5
* Environment: development
* PID: 60791
* Listening on http://0.0... | Before 3.2.0, a warning was printed (if you ran with warnings enabled)
```
arm64 $ RUBYOPT=-W bundle exec puma
Puma starting in single mode...
* Puma version: 6.1.0 (ruby 3.1.3-p185) ("The Way Up")
* Min threads: 0
* Max threads: 5
* Environment: development
* PID: 60791
* Listening on http://0.0... | [
"https://github.com/sinatra/sinatra/commit/22f422ae76b0ef76dc7644ebf716e187f959d6ee"
] | 2023-02-26T18:51:26 | 1.0 | Ruby |
sinatra/sinatra | 2,078 | sinatra__sinatra-2078 | [
2077
] | 7b50a1bbb5324838908dfaa00ec53ad322673a29 | diff --git a/lib/sinatra/base.rb b/lib/sinatra/base.rb
index 7eef6533c..f0bccd8ae 100644
--- a/lib/sinatra/base.rb
+++ b/lib/sinatra/base.rb
@@ -398,7 +398,7 @@ def content_type(type = nil, params = {})
unless params.empty?
mime_type << (mime_type.include?(';') ? ', ' : ';')
mime_type << params... | diff --git a/test/base_test.rb b/test/base_test.rb
index 2bccf2e92..66265156c 100644
--- a/test/base_test.rb
+++ b/test/base_test.rb
@@ -181,5 +181,17 @@ class TestMiddlewareContentLength < Sinatra::Base
response = request_content_length.get('/forward')
assert_equal '28', response['Content-Length']
e... | `NoMethodError` when using `content_type` params with `Integer` value
This app
```ruby
require "bundler/inline"
gemfile(true) do
gem "nio4r"
gem "sinatra", require: "sinatra/base"
end
class App < Sinatra::Base
get "/" do
content_type "foo/bar", baz: 1
body "OK"
end
end
run App
```
... | [
"https://github.com/sinatra/sinatra/commit/0b880a63863be7c8158ad5343be116dfc0c93e29"
] | 2025-01-25T04:43:49 | 1.0 | Ruby | ||
googleapis/google-cloud-ruby | 20,535 | googleapis__google-cloud-ruby-20535 | [
20534
] | a5084ad7eded82651e8376ed16333109d72afb87 | diff --git a/google-cloud-errors/lib/google/cloud/errors.rb b/google-cloud-errors/lib/google/cloud/errors.rb
index 2d28f158bad3..0f87234f15db 100644
--- a/google-cloud-errors/lib/google/cloud/errors.rb
+++ b/google-cloud-errors/lib/google/cloud/errors.rb
@@ -231,6 +231,13 @@ def self.gapi_error_class_for http_status_co... | diff --git a/google-cloud-errors/test/google/cloud/errors/wrapped_gapi_test.rb b/google-cloud-errors/test/google/cloud/errors/wrapped_gapi_test.rb
index 71d2762e355a..8cee64d07c49 100644
--- a/google-cloud-errors/test/google/cloud/errors/wrapped_gapi_test.rb
+++ b/google-cloud-errors/test/google/cloud/errors/wrapped_ga... | Add GRPC error code to Ruby Cloud error classes for the REST wrapping cases.
Currently the Ruby Cloud errors surface the underlying cause's error code. When they wrap HTTP error there is no `code` (there is an http status code in `status_code`). We should add the corresponding GRPC error code directly to the classes.
| [
"https://github.com/googleapis/google-cloud-ruby/commit/ffe3ba76e8edb7e0d5c6eb333e92c74e7a71540c",
"https://github.com/googleapis/google-cloud-ruby/commit/92bde6db12c96cf4309961ca74d5047b210e2fde",
"https://github.com/googleapis/google-cloud-ruby/commit/f8fecca7915d43b0d5314a60406357c8efacc74d",
"https://gith... | 2023-02-27T22:30:40 | 0.15 | Ruby | ||
googleapis/google-cloud-ruby | 20,913 | googleapis__google-cloud-ruby-20913 | [
20479
] | baab078b1008b428b83d4c65a5b613e1c7de1338 | diff --git a/google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher/batch.rb b/google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher/batch.rb
index e1a7352c9c62..46bc0449374d 100644
--- a/google-cloud-pubsub/lib/google/cloud/pubsub/async_publisher/batch.rb
+++ b/google-cloud-pubsub/lib/google/cloud/pubsub/as... | diff --git a/google-cloud-pubsub/acceptance/pubsub/schema_test.rb b/google-cloud-pubsub/acceptance/pubsub/schema_test.rb
index c634384573bd..4333ea9c80bb 100644
--- a/google-cloud-pubsub/acceptance/pubsub/schema_test.rb
+++ b/google-cloud-pubsub/acceptance/pubsub/schema_test.rb
@@ -46,6 +46,7 @@
let(:bad_value) { { ... | Topic publish latencies
I'm using Pubsub as a backend together with ActiveJob for a background job system. I'm running `google-cloud-pubsub (2.15.0)`.
I'm experiencing big latencies when publishing messages. Here's the code:
```ruby
def publish(job)
serialized_job = job.serialize
enqueued_at = ... | I have added more logs to see if I can find the reason for the messages to be stuck in the topic. I'm logging every 10 seconds this:
```ruby
topic.async_publisher.instance_variable_get(:@batches).each_value do |batch|
LOGGER.info(
labels: {
name: "app.metrics.pubsub.batch",
topic_id: queue
... | I have added more logs to see if I can find the reason for the messages to be stuck in the topic. I'm logging every 10 seconds this:
```ruby
topic.async_publisher.instance_variable_get(:@batches).each_value do |batch|
LOGGER.info(
labels: {
name: "app.metrics.pubsub.batch",
topic_id: queue
... | [
"https://github.com/googleapis/google-cloud-ruby/commit/5156e17b5e08405aea0d5eda70e4b85114a86284",
"https://github.com/googleapis/google-cloud-ruby/commit/b398c17f732fed3bc7ced36bd6377e5d5d302bfd",
"https://github.com/googleapis/google-cloud-ruby/commit/056b162e8f7d630463bddde2d6d2816c94d6c997",
"https://gith... | 2023-03-15T13:05:50 | 0.3 | Ruby |
googleapis/google-cloud-ruby | 32,263 | googleapis__google-cloud-ruby-32263 | [
32247
] | 6a3ab69f3f942a4f5046be7e9608289afa3632f1 | diff --git a/google-cloud-pubsub/OVERVIEW.md b/google-cloud-pubsub/OVERVIEW.md
index 13d2da170f04..361c8d95076f 100644
--- a/google-cloud-pubsub/OVERVIEW.md
+++ b/google-cloud-pubsub/OVERVIEW.md
@@ -36,7 +36,7 @@ into Admin Operations and Data Plane Operations.
* **Data Plane Operations**: For the core functionality o... | diff --git a/google-cloud-pubsub/test/google/cloud/pubsub/publisher/lazy_test.rb b/google-cloud-pubsub/test/google/cloud/pubsub/publisher/lazy_test.rb
new file mode 100644
index 000000000000..45865f28812a
--- /dev/null
+++ b/google-cloud-pubsub/test/google/cloud/pubsub/publisher/lazy_test.rb
@@ -0,0 +1,39 @@
+# Copyrig... | Allow creating Publisher without GetTopic API lookup to prevent Admin Quota exhaustion
**Is your feature request related to a problem? Please describe.**
This request addresses a regression in functionality introduced in google-cloud-pubsub version 3.0 regarding the initialization of Topic/Publisher references.
In v... | Ack, thanks for the report and PR! I will get it figured out this week.
| Ack, thanks for the report and PR! I will get it figured out this week.
@aandreassa thank you for addressing the initial request and merging the reference-based initialization. However, after testing version 3.1, we have found that the issue remains unresolved.
While the factory method now allows skipping the lookup d... | [
"https://github.com/googleapis/google-cloud-ruby/commit/44d8836318dd6cbbc91e83e2c6ebd7e119e9c403",
"https://github.com/googleapis/google-cloud-ruby/commit/bf802a7730b87cb02f865bae5903862f77bc9065"
] | 2025-12-12T04:50:26 | 3.0 | Ruby |
googleapis/google-cloud-ruby | 25,680 | googleapis__google-cloud-ruby-25680 | [
25682
] | c2e5c2a78570dcffd40fed66c71695df5f8a041a | diff --git a/google-cloud-bigtable/lib/google/cloud/bigtable.rb b/google-cloud-bigtable/lib/google/cloud/bigtable.rb
index 613095c8c0bc..89707641d8a2 100644
--- a/google-cloud-bigtable/lib/google/cloud/bigtable.rb
+++ b/google-cloud-bigtable/lib/google/cloud/bigtable.rb
@@ -163,6 +163,7 @@ def self.new_with_emulator pr... | diff --git a/google-cloud-bigtable/test/test_proxy/Gemfile b/google-cloud-bigtable/test/test_proxy/Gemfile
new file mode 100644
index 000000000000..c91da1ac3a62
--- /dev/null
+++ b/google-cloud-bigtable/test/test_proxy/Gemfile
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+gem "googl... | Add Bigtable Client Conformance Tests
The Bigtable team maintains a suite of language-independent "conformance tests", which verify some common edge-cases behave correctly across all of the Bigtable clients.
We would like to add conformance tests for the Ruby client. This is accomplished by authoring a thin proxy, w... | Apologies, I'm backfilling this issue, the work has already been done in #25680 before I realized all PRs should have an issue assigned.
| [
"https://github.com/googleapis/google-cloud-ruby/commit/12448db92aa9ec78f4f487de06e90b15e878f16f",
"https://github.com/googleapis/google-cloud-ruby/commit/ce078e090fa85caa2b2f79feab29a58b19bb8fe2",
"https://github.com/googleapis/google-cloud-ruby/commit/d6bb3fdad66eb63facf9dc601fa229769441d193",
"https://gith... | 2024-04-13T19:45:25 | 0.29 | Ruby | |
googleapis/google-cloud-ruby | 23,732 | googleapis__google-cloud-ruby-23732 | [
23484
] | fc6e5c41d335c1ad663326ddf928a075d03efbe7 | diff --git a/google-cloud-storage/google-cloud-storage.gemspec b/google-cloud-storage/google-cloud-storage.gemspec
index 0ceed18fa112..170122f558de 100644
--- a/google-cloud-storage/google-cloud-storage.gemspec
+++ b/google-cloud-storage/google-cloud-storage.gemspec
@@ -20,7 +20,7 @@ Gem::Specification.new do |gem|
... | diff --git a/google-cloud-storage/acceptance/storage/file_test.rb b/google-cloud-storage/acceptance/storage/file_test.rb
index 4374ae58f1cd..9e4b65678914 100644
--- a/google-cloud-storage/acceptance/storage/file_test.rb
+++ b/google-cloud-storage/acceptance/storage/file_test.rb
@@ -857,4 +857,182 @@
expect { pri... | storage: add support for object retention
Please implement the object retention feature. The following operations must be supported:
- Create a bucket with object retention enabled by using the `enableObjectRetention` bucket create boolean option at bucket create time
- Get the object retention enabled status of a ... | [
"https://github.com/googleapis/google-cloud-ruby/commit/a8525776403b366ea1b9c5e26a1a62889e65bc2c",
"https://github.com/googleapis/google-cloud-ruby/commit/705de60d546f81177ce8f7a728f5a1645aeb1093",
"https://github.com/googleapis/google-cloud-ruby/commit/292b165e48cf0ed358f84f2a75978ab89ac78c31",
"https://gith... | 2024-01-05T09:33:46 | 0.27 | Ruby | ||
faker-ruby/faker | 3,140 | faker-ruby__faker-3140 | [
3139
] | 28505d48c0c9df6d92da889e1c2250679a6ed008 | diff --git a/README.md b/README.md
index 2f42ed4383..cd57430b07 100644
--- a/README.md
+++ b/README.md
@@ -214,7 +214,6 @@ gem 'faker', :git => 'https://github.com/faker-ruby/faker.git', :branch => 'main
- [Faker::Beer](doc/default/beer.md)
- [Faker::Blood](doc/default/blood.md)
- [Faker::Boolean](doc/default/... | diff --git a/test/faker/default/test_faker_bossa_nova.rb b/test/faker/default/test_faker_bossa_nova.rb
deleted file mode 100644
index f5bc2bf112..0000000000
--- a/test/faker/default/test_faker_bossa_nova.rb
+++ /dev/null
@@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-require_relative '../../test_helper'
-
-class Te... | Move `Faker::BossaNova` to `Faker::Music::BossaNova`
Move generator `Faker::BossaNova` to `Faker::Music::BossaNova`, and deprecate `Faker::BossaNova`, pointing to the new namespace.
| [
"https://github.com/faker-ruby/faker/commit/b18a9d23f4edc5edf99d90ad4c27fa18c311b435"
] | 2025-11-16T01:11:36 | 3.5 | Ruby | ||
faker-ruby/faker | 2,791 | faker-ruby__faker-2791 | [
2093
] | 9ee707d20bc8ea96b0292d88157cf85a4e6acf6e | diff --git a/lib/faker/default/date.rb b/lib/faker/default/date.rb
index 6d1997c1af..9fee0f7e38 100644
--- a/lib/faker/default/date.rb
+++ b/lib/faker/default/date.rb
@@ -53,18 +53,26 @@ def between_except(from:, to:, excepted:)
##
# Produce a random date in the future (up to N days).
#
+ # @p... | diff --git a/test/faker/default/test_faker_date.rb b/test/faker/default/test_faker_date.rb
index d509bd85dc..03be200a9c 100644
--- a/test/faker/default/test_faker_date.rb
+++ b/test/faker/default/test_faker_date.rb
@@ -63,6 +63,27 @@ def test_forward
end
end
+ def test_forward_with_from_parameter
+ from =... | Date.today causes timezone issues in Rails.
## Describe the bug
Any Faker method which uses `Date.today` in Ruby On Rails is potentially off by a day. There are similar potential issues for `Time.now` and `DateTime.now`.
## To Reproduce
In Rails console, set a time zone which is in a different day. For example... | If I make the changes as mentioned in the resource given above i.e. if I change Date.today to Date.current will you accept my PR
I'm wondering why this was marked as completed when it's still an issue with the gem? Is there workaround for rails users or something I should be doing instead? I am also happy to put a pa... | If I make the changes as mentioned in the resource given above i.e. if I change Date.today to Date.current will you accept my PR
I'm wondering why this was marked as completed when it's still an issue with the gem? Is there workaround for rails users or something I should be doing instead? I am also happy to put a pa... | [
"https://github.com/faker-ruby/faker/commit/28f7eb078993b5f2d0a47f64bc6ccf4ed0ec2a2a"
] | 2023-06-29T06:41:54 | 3.2 | Ruby |
faker-ruby/faker | 2,950 | faker-ruby__faker-2950 | [
2943
] | 7dc2f4044ca7f83da014f71be9bef87bf8b10e46 | diff --git a/lib/faker/default/internet.rb b/lib/faker/default/internet.rb
index 3ecdcd9838..688b9f8976 100644
--- a/lib/faker/default/internet.rb
+++ b/lib/faker/default/internet.rb
@@ -63,9 +63,12 @@ def email(name: nil, separators: nil, domain: nil)
# Faker::Internet.username(specifier: 20, separators: ['_'... | diff --git a/test/faker/default/test_faker_internet.rb b/test/faker/default/test_faker_internet.rb
index f8a2a6574c..129640a71a 100644
--- a/test/faker/default/test_faker_internet.rb
+++ b/test/faker/default/test_faker_internet.rb
@@ -36,6 +36,14 @@ def test_email_name_with_non_permitted_characters
end
end
+ ... | Random Test Failure: Faker::Omniauth tests fail when generating a name with an apostrophe
## Describe The Bug
The `Faker::Omniauth` module sometimes initializes a last name with an apostrophe (such as O'Connell), which will generate an email address that fails the validation tests within `TestFakerInternetOmniauth`.
... | So currently when we run
```ruby
Faker::Internet.email(name: "Alexis O'MConnell")
#=> o_alexis_mconnell@zieme.example
```
This might not be what we expect. But I'm not sure what is the correct representation for this?
Is it `o.connell_alexis@zieme.example`?
@keshavbiswa exactly...
So this generator ... | So currently when we run
```ruby
Faker::Internet.email(name: "Alexis O'MConnell")
#=> o_alexis_mconnell@zieme.example
```
This might not be what we expect. But I'm not sure what is the correct representation for this?
Is it `o.connell_alexis@zieme.example`?
@keshavbiswa exactly...
So this generator ... | [
"https://github.com/faker-ruby/faker/commit/6d0ef12468c76a9158dd5c6e8b955c86ed0ea622",
"https://github.com/faker-ruby/faker/commit/bc49f6777f519d1c6a69c909685f238012fd48ed",
"https://github.com/faker-ruby/faker/commit/a989db1248118e985940fe35382d4cde2a5f04a3",
"https://github.com/faker-ruby/faker/commit/dceda... | 2024-05-07T17:10:27 | 3.4 | Ruby |
faker-ruby/faker | 3,138 | faker-ruby__faker-3138 | [
3131
] | 94adefd06870ea9568a05a4f3aecd51307add268 | diff --git a/README.md b/README.md
index cd57430b07..929ca184cd 100644
--- a/README.md
+++ b/README.md
@@ -34,6 +34,7 @@ and it was the original impetus for the creation of this gem.
- [Faker](#faker)
- [Quick links](#quick-links)
+ - [In the media](#in-the-media)
- [Table of Contents](#table-of-contents)
... | diff --git a/test/faker/default/test_twitter.rb b/test/faker/default/test_twitter.rb
index 8273ee870e..a17127ffc9 100644
--- a/test/faker/default/test_twitter.rb
+++ b/test/faker/default/test_twitter.rb
@@ -59,4 +59,60 @@ def test_status_with_photo
assert_equal(1, status[:entities][:media].count)
assert_equal... | Update Faker::Twitter: rename to Faker::X and update deprecated attributes
Although we cannot keep track of all the external APIs changes, we do have the opportunity to update `Faker::Twitter` after its rename:
- deprecate `Faker::Twitter` in favour of `Faker::X`
- update `user` to follow the API's updates. Some field... | Hi @stefannibrasil , just curious. How are fixing this issue? we will remove all the deprecated fields in #user method and have only the accepted fields like below?
```
"user": {
"id": 2244994945,
"id_str": "2244994945",
"name": "X Dev",
"screen_name": "XDevelopers",
"location": "127.0.0.1",
"url": "https:... | [
"https://github.com/faker-ruby/faker/commit/a080fcc4512182f4603e48ba520bacea96cb779d",
"https://github.com/faker-ruby/faker/commit/f2aa39540c6bc3c942fed506a237fcecd77fe9a8",
"https://github.com/faker-ruby/faker/commit/82def71507c1dbe96e76b76503ff440230f2073f",
"https://github.com/faker-ruby/faker/commit/6dc25... | 2025-11-13T22:53:01 | 3.5 | Ruby | |
faker-ruby/faker | 2,733 | faker-ruby__faker-2733 | [
2431
] | 53843386b662445d1d766f7b4226aa63549954a6 | diff --git a/.rubocop.yml b/.rubocop.yml
index b61f2ad0a3..2973cfe4cb 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -109,3 +109,7 @@ Security/Eval:
Description: The use of eval represents a serious security risk.
Exclude:
- 'lib/faker/default/json.rb'
+
+Style/IfUnlessModifier:
+ Description: Checks for `... | diff --git a/test/faker/default/test_faker_internet.rb b/test/faker/default/test_faker_internet.rb
index 87509d0a20..d7ec6c9826 100644
--- a/test/faker/default/test_faker_internet.rb
+++ b/test/faker/default/test_faker_internet.rb
@@ -1,6 +1,7 @@
# frozen_string_literal: true
require_relative '../../test_helper'
+r... | Faker is unsafe to use in automated tests - real urls and email addresses are generated
## Describe the bug
Faker::Internet.url, and Faker::Internet.email generate potentially real domain names and email addresses. Using potentially real urls and email addresses in automated testing environments is a security vulnera... | I can tackle this issue.
@patrick-beep please check https://github.com/faker-ruby/faker/pull/2506
```ruby
Faker::Internet.email # => "user@domain.com"
Faker::Config.internet_safe_mode = true
Faker::Internet.email # => "user@domain.example"
Faker::Internet.url # => "http://marks.example/vern"
Faker::Internet.d... | I can tackle this issue.
@patrick-beep please check https://github.com/faker-ruby/faker/pull/2506
```ruby
Faker::Internet.email # => "user@domain.com"
Faker::Config.internet_safe_mode = true
Faker::Internet.email # => "user@domain.example"
Faker::Internet.url # => "http://marks.example/vern"
Faker::Internet.d... | [
"https://github.com/faker-ruby/faker/commit/3ce52b2329a24005ed2868cfd94b1a65a6b4feb3",
"https://github.com/faker-ruby/faker/commit/4a467598376afa0015a7eb163a996ebd4c40a18f"
] | 2023-03-21T02:34:23 | 3.2 | Ruby |
ruby-git/ruby-git | 605 | ruby-git__ruby-git-605 | [
604
] | 429f0bb4b7c3a61507e5c0353adf062922a7b8b4 | diff --git a/lib/git/lib.rb b/lib/git/lib.rb
index 293f2878..b4d16152 100644
--- a/lib/git/lib.rb
+++ b/lib/git/lib.rb
@@ -63,8 +63,6 @@ def initialize(base = nil, logger = nil)
@git_work_dir = base[:working_directory]
end
@logger = logger
-
- Git::Lib.warn_if_old_command(self)
end
... | diff --git a/tests/units/test_lib_meets_required_version.rb b/tests/units/test_lib_meets_required_version.rb
index fce57241..1f572d31 100644
--- a/tests/units/test_lib_meets_required_version.rb
+++ b/tests/units/test_lib_meets_required_version.rb
@@ -21,4 +21,31 @@ def test_with_old_command_version
lib.define_sing... | failure using git built from source
If git was built from source, the version appears as:
git version 2.39.**GIT**
This regex fails, producing a nil version:
https://github.com/ruby-git/ruby-git/blob/ca8ff350a63172630b8e9e919e02a0ce8e7a7a6d/lib/git/lib.rb#L1032
Fix:
version = output[/\d+\.\d+(\.(?:GIT|... | @kcburge can you take a looks at #605 to see if it fixes this problem for you? If it does, I will merge it and make a new version of the git gem.
| @kcburge can you take a looks at #605 to see if it fixes this problem for you? If it does, I will merge it and make a new version of the git gem.
The fix works for me.
The fix is in git-1.13.1 which I published to rubygems.org yesterday.
| [
"https://github.com/ruby-git/ruby-git/commit/ca26ca900701ca4d85325a72461cc54b33433310"
] | 2023-01-11T21:59:16 | 1.13 | Ruby |
ruby-git/ruby-git | 626 | ruby-git__ruby-git-626 | [
599,
600
] | 4c5a6acc524ebdc20652e8b544563155ee071035 | diff --git a/lib/git/branch.rb b/lib/git/branch.rb
index c38c9d4a..31c482e8 100644
--- a/lib/git/branch.rb
+++ b/lib/git/branch.rb
@@ -78,7 +78,11 @@ def merge(branch = nil, message = nil)
end
def update_ref(commit)
- @base.lib.update_ref(@full, commit)
+ if @remote
+ @base.lib.update_r... | diff --git a/tests/units/test_branch.rb b/tests/units/test_branch.rb
index 8fdc1db7..e3acd0d2 100644
--- a/tests/units/test_branch.rb
+++ b/tests/units/test_branch.rb
@@ -98,4 +98,22 @@ def test_branch_create_and_switch
assert(git.branch('other_branch').current)
end
end
+
+ def test_branch_update_ref
+ ... | Git::Branch function update_ref doesn't work as expected
### Subject of the issue
Git::Branch#update_ref creates the wrong ref name, resulting in "refname is ambiguous" warnings.
### Your environment
* git 2.16.2
* ruby 2.3.1
* ruby-git 1.12.0
### Steps to reproduce
```ruby
require 'git'
git = Git.init
Fi... | [
"https://github.com/ruby-git/ruby-git/commit/d5c85b7367e748c6d1b875566de09e4157972081",
"https://github.com/ruby-git/ruby-git/commit/68ba1a8ee95db366baec8a6153dbe3ffaf634468"
] | 2023-02-26T18:10:12 | 1.14 | Ruby | ||
ruby-git/ruby-git | 643 | ruby-git__ruby-git-643 | [
475
] | 6db3ea4d32c4f2e47761dad793f746d95fb48d10 | diff --git a/lib/git/lib.rb b/lib/git/lib.rb
index 74b31862..02c59363 100644
--- a/lib/git/lib.rb
+++ b/lib/git/lib.rb
@@ -338,7 +338,7 @@ def object_contents(sha, &block)
end
def ls_tree(sha)
- data = {'blob' => {}, 'tree' => {}}
+ data = { 'blob' => {}, 'tree' => {}, 'commit' => {} }
co... | diff --git a/tests/test_helper.rb b/tests/test_helper.rb
index e27d2366..4b7111de 100644
--- a/tests/test_helper.rb
+++ b/tests/test_helper.rb
@@ -170,4 +170,9 @@ def assert_command_line(expected_command_line, git_cmd, git_cmd_args)
assert_equal(expected_command_line, actual_command_line)
end
+
+ def assert_... | Git::Object::Tree#check_tree throws exception on a submodule, type 'commit'
### Subject of the issue
If I execute the following code on a workspace with a submodule:
```ruby
git = Git.open(@workspace_path, log: @logger)
gtree = git.gtree('HEAD')
head_sha = gtree.sha
subtrees = gtree.subtrees
```
... it fa... | A friendly reminder that this issue had no activity for 60 days.
| A friendly reminder that this issue had no activity for 60 days.
| [
"https://github.com/ruby-git/ruby-git/commit/2198f872d53c32e0162cdfabfdbb82abebec3c3a"
] | 2023-03-04T21:59:45 | 1.16 | Ruby |
ruby-git/ruby-git | 846 | ruby-git__ruby-git-846 | [
842
] | 4a03b5ce2939ad8a92496a443a6edcd6ce059a70 | diff --git a/lib/git/base.rb b/lib/git/base.rb
index b291c83f..b2f433c4 100644
--- a/lib/git/base.rb
+++ b/lib/git/base.rb
@@ -286,7 +286,10 @@ def local_branch?(branch)
end
def is_local_branch?(branch) # rubocop:disable Naming/PredicatePrefix
- Git.deprecation('Git::Base#is_local_branch? is deprecated... | diff --git a/tests/units/test_deprecations.rb b/tests/units/test_deprecations.rb
new file mode 100644
index 00000000..f12f61dc
--- /dev/null
+++ b/tests/units/test_deprecations.rb
@@ -0,0 +1,187 @@
+# frozen_string_literal: true
+
+require_relative '../test_helper'
+
+# Consolidated deprecation tests to ensure all depr... | `Git.deprecation` is not available but being used on `is_local_branch?`
# What happened
I am not sure if I am not seeing this clear, but I've hit a deprecation warning for `is_local_branch?`:
https://github.com/ruby-git/ruby-git/blob/4a7700dc088f0c85747f6010d415a7952ce44c1e/lib/git/base.rb#L288-L291
That is perfect... | Thank you for the report @carlos-santos-anchor
This issue should be fixed in git-4.0.6. Give it a try and let me know if it fixes your problem.
> Thank you for the report @carlos-santos-anchor
>
> This issue should be fixed in git-4.0.6. Give it a try and let me know if it fixes your problem.
Thank you so much.
| Thank you for the report @carlos-santos-anchor
This issue should be fixed in git-4.0.6. Give it a try and let me know if it fixes your problem.
> Thank you for the report @carlos-santos-anchor
>
> This issue should be fixed in git-4.0.6. Give it a try and let me know if it fixes your problem.
Thank you so much.
| [
"https://github.com/ruby-git/ruby-git/commit/22055b5c9535c23e88a56fb2b41ac0d111187acd"
] | 2025-11-11T18:41:28 | 4.0 | Ruby |
ruby-git/ruby-git | 649 | ruby-git__ruby-git-649 | [
648
] | b07c0f7c2f684c048e470179169e82bac7314f22 | diff --git a/README.md b/README.md
index 578cd1c6..661fad7a 100644
--- a/README.md
+++ b/README.md
@@ -3,73 +3,47 @@
# @title README
-->
-# The `git` Gem
+# The Git Gem
-[](https://badge.fury.io/rb/git)
-[![Change Log](https://img.shields.io/badge/change%20log-Lates... | diff --git a/tests/test_helper.rb b/tests/test_helper.rb
index c496d798..4b7111de 100644
--- a/tests/test_helper.rb
+++ b/tests/test_helper.rb
@@ -5,8 +5,6 @@
require "git"
-Git.deprecation.behavior = :silence
-
class Test::Unit::TestCase
TEST_ROOT = File.expand_path(__dir__)
diff --git a/tests/units/test_gi... | 1.17.0 broke compatibility with ruby <2.7
### Subject of the issue
The addition of the `activesupport` dependency in 1.17.0 (https://github.com/ruby-git/ruby-git/pull/645) broke us (via [`danger` v8.4.*](https://github.com/danger/danger/blob/314bb927605beb862137498e36a3b4bfff413dc7/danger.gemspec#L25)):
```
ERROR: ... | I will revert the change which brought in ActiveSupport and tag it for the next major release which will also upgrade the minimum dependencies for Ruby and git. In the meantime, can you pin yourself to 1.16.0?
> In the meantime, can you pin yourself to 1.16.0?
We actually just upgraded to ruby 2.7, was not a big dea... | I will revert the change which brought in ActiveSupport and tag it for the next major release which will also upgrade the minimum dependencies for Ruby and git. In the meantime, can you pin yourself to 1.16.0?
> In the meantime, can you pin yourself to 1.16.0?
We actually just upgraded to ruby 2.7, was not a big dea... | [
"https://github.com/ruby-git/ruby-git/commit/5a44760a63de6c91794d7b4fa2056ed224d7354e"
] | 2023-03-06T16:17:58 | 1.17 | Ruby |
ruby/debug | 944 | ruby__debug-944 | [
870
] | f190b2877f33719fcbdc47a26381ebf68d444d7c | diff --git a/lib/debug/breakpoint.rb b/lib/debug/breakpoint.rb
index 65161f919..13e9c428b 100644
--- a/lib/debug/breakpoint.rb
+++ b/lib/debug/breakpoint.rb
@@ -101,10 +101,6 @@ def skip_path?(path)
def generate_label(name)
colorize(" BP - #{name} ", [:YELLOW, :BOLD, :REVERSE])
end
-
- def pending_u... | diff --git a/test/console/break_test.rb b/test/console/break_test.rb
index 239a0ef5f..2b9b1e6f8 100644
--- a/test/console/break_test.rb
+++ b/test/console/break_test.rb
@@ -819,7 +819,7 @@ def program path
RUBY
end
- def test_break_on_realoded_file
+ def test_break_on_realoded_file_pending
wi... | VS Code breakpoints skipped after Rails reloads related code
**Your environment**
* `ruby -v`: `3.1.2`
* `rdbg -v`: `1.7.0`
**Describe the bug**
Breakpoints added via VS Code seems to be lost after surrounding code is modified and reloaded by Rails.
For example, if we set a breakpoint at
```rb
def inde... | I think it's related to `LineBreakpoint`'s `@pending` state:
After the first breakpoint hit, the later breakpoint would has `@iseq` like
```
<RubyVM::InstructionSequence:index@/Users/hung-wulo/src/github.com/st0012/debug-issue/app/controllers/posts_controller.rb:5>
```
And this means its [`@pending` state ... | I think it's related to `LineBreakpoint`'s `@pending` state:
After the first breakpoint hit, the later breakpoint would has `@iseq` like
```
<RubyVM::InstructionSequence:index@/Users/hung-wulo/src/github.com/st0012/debug-issue/app/controllers/posts_controller.rb:5>
```
And this means its [`@pending` state ... | [
"https://github.com/ruby/debug/commit/f00aa6d268b8638134a4fca99880b428c55e28c8"
] | 2023-03-25T17:52:45 | 1.7 | Ruby |
ruby/debug | 947 | ruby__debug-947 | [
877
] | e7061938bf6d19340ee1ae3bf8a8110cd5d7ae01 | diff --git a/lib/debug/session.rb b/lib/debug/session.rb
index ffd333a37..301dc96e2 100644
--- a/lib/debug/session.rb
+++ b/lib/debug/session.rb
@@ -345,7 +345,7 @@ def process_event evt
opt = ev_args[3]
add_tracer ObjectTracer.new(@ui, obj_id, obj_inspect, **opt)
else
- # ignore... | diff --git a/test/console/eval_test.rb b/test/console/eval_test.rb
index 6b066b157..ff710cd90 100644
--- a/test/console/eval_test.rb
+++ b/test/console/eval_test.rb
@@ -35,4 +35,30 @@ def test_eval_evaluates_computation_and_assignment
end
end
end
+
+ class EvalThreadTest < ConsoleTestCase
+ def progr... | Debugger freezes when triggering timeout inside a timeout block with Puma server
**Your environment**
* `ruby -v`: `3.1.3`
* `rdbg -v`: `1.7.1`
**Describe the bug**
When the following conditions all match, the debugger has a high possibility to freeze:
- Inside a Rails app with Puma web server
- The break... | Thank you for the report.
* Is it difficult to repro within a single file? (without puma)
* Can you show the backtrace when thread_stopper's TP stoppes?
by modifying like that:
``` ruby
private def thread_stopper
TracePoint.new(:line) do
# run on each thread
tc = ThreadClient.curr... | Thank you for the report.
* Is it difficult to repro within a single file? (without puma)
* Can you show the backtrace when thread_stopper's TP stoppes?
by modifying like that:
``` ruby
private def thread_stopper
TracePoint.new(:line) do
# run on each thread
tc = ThreadClient.curr... | [
"https://github.com/ruby/debug/commit/fa6b096666f9a0fc84b703e818e4a9d67d90e708"
] | 2023-03-28T09:07:25 | 1.7 | Ruby |
ruby/debug | 920 | ruby__debug-920 | [
900
] | 5b29bd785b31048c9c2032ed997d1cb6ae3ac73a | diff --git a/lib/debug/server_dap.rb b/lib/debug/server_dap.rb
index 8dedcdc7a..b32be9dfd 100644
--- a/lib/debug/server_dap.rb
+++ b/lib/debug/server_dap.rb
@@ -437,10 +437,11 @@ def process
expr = req.dig('arguments', 'expression')
if /\A\s*,(.+)\z/ =~ expr
dbg_expr = $1
+ ... | diff --git a/test/protocol/eval_test.rb b/test/protocol/eval_test.rb
index 94ac19dc8..c3893be45 100644
--- a/test/protocol/eval_test.rb
+++ b/test/protocol/eval_test.rb
@@ -23,6 +23,19 @@ def test_eval_evaluates_arithmetic_expressions
req_terminate_debuggee
end
end
+
+ def test_eval_executes_com... | First breakpoint is skipped on a remote development environment
**Describe the bug**
Breakpoint skipped when running on a remote development environment
**To Reproduce**
1. Go to https://github.com/github/codespaces-rails to start with a new Rails app.
2. Choose Use This Template -> Open in a Codespace
3. Cr... | Some further findings on this:
It seems like a race condition. If I add `sleep 0.1` before this line:
https://github.com/ruby/debug/blob/d7bf3b2e4502eb0f07a67f00e5fce5a0d661189e/lib/debug/server.rb#L350
then it stops at the first breakpoint.
I'm wondering if could relate to https://github.com/ruby/debug/pull... | Some further findings on this:
It seems like a race condition. If I add `sleep 0.1` before this line:
https://github.com/ruby/debug/blob/d7bf3b2e4502eb0f07a67f00e5fce5a0d661189e/lib/debug/server.rb#L350
then it stops at the first breakpoint.
I'm wondering if could relate to https://github.com/ruby/debug/pull... | [
"https://github.com/ruby/debug/commit/6cba23f8824cf1bc5cdaf008c640fb660e241f3f",
"https://github.com/ruby/debug/commit/cacaef2b029e24c60d89fd3f50cdead53a4a482d"
] | 2023-03-08T07:42:11 | 1.7 | Ruby |
ruby/debug | 1,138 | ruby__debug-1138 | [
1135
] | bead0984d241a91235e3d3bacd247f0363d2d530 | diff --git a/README.md b/README.md
index 2cd3ddf51..00ae01b9d 100644
--- a/README.md
+++ b/README.md
@@ -471,6 +471,7 @@ config set no_color true
* UI
* `RUBY_DEBUG_LOG_LEVEL` (`log_level`): Log level same as Logger (default: WARN)
* `RUBY_DEBUG_SHOW_SRC_LINES` (`show_src_lines`): Show n lines source code on bre... | diff --git a/test/console/config_test.rb b/test/console/config_test.rb
index 589be7488..6d87b6da4 100644
--- a/test/console/config_test.rb
+++ b/test/console/config_test.rb
@@ -105,6 +105,81 @@ def test_show_src_lines_control_the_lines_displayed_on_breakpoint
end
end
+ class ShowSrcLinesFrameTest < ConsoleTe... | debug does not show context when navigating up & down stack
**Your environment**
* `ruby -v`: any
* `rdbg -v`:
**Describe the bug**
A clear and concise description of what the bug is.
When navigating up and down the stack, debug does not show any context around the source code.
**To Reproduce**
Type `up` or `down`... | Thank you for the fix, much appreciated.
| [
"https://github.com/ruby/debug/commit/d3d3dd45cc474aca551015cf37131cbb3f0ac239"
] | 2025-05-05T15:26:51 | 1.7 | Ruby | |
ruby/debug | 1,163 | ruby__debug-1163 | [
1162
] | 2791573fd24aef2091cbb30aa8750f3117781752 | diff --git a/lib/debug/frame_info.rb b/lib/debug/frame_info.rb
index 8fab332de..558f5466b 100644
--- a/lib/debug/frame_info.rb
+++ b/lib/debug/frame_info.rb
@@ -171,7 +171,7 @@ def parameters_info
private def get_singleton_class obj
obj.singleton_class # TODO: don't use it
- rescue TypeError
+ rescu... | diff --git a/test/console/backtrace_test.rb b/test/console/backtrace_test.rb
index 570d66c80..8c6056a6a 100644
--- a/test/console/backtrace_test.rb
+++ b/test/console/backtrace_test.rb
@@ -229,4 +229,31 @@ def test_backtrace_prints_without_hanging
end
end
end
+
+ class BrokenSingletonMethodBacktraceTest... | Object inspection doesn't work inside Mocks that doesn't expect the `singleton_class` method called
**Your environment**
* `ruby -v`: ruby 3.3.7 (2025-01-15 revision be31f993d7) [x86_64-linux]
* `rdbg -v`: rdbg 1.11.0
**Describe the bug**
Object inspection doesn't work inside Mocks that doesn't expect the `singleton... | [
"https://github.com/ruby/debug/commit/480ee90b6fa7610b6f012a631063e1134360fe84"
] | 2025-12-05T08:19:44 | 1.7 | Ruby |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.