repo
stringclasses
200 values
pull_number
int64
13
143k
instance_id
stringlengths
12
47
issue_numbers
listlengths
1
7
base_commit
stringlengths
40
40
patch
stringlengths
354
98.3k
test_patch
stringlengths
137
8.74M
problem_statement
stringlengths
142
63.8k
hints_text
stringlengths
2
70.5k
all_hints_text
stringlengths
2
70.5k
commit_urls
listlengths
1
119
created_at
timestamp[s]date
2015-04-16 11:31:38
2025-12-17 10:26:03
version
stringclasses
196 values
language
stringclasses
10 values
woocommerce/woocommerce
58,700
woocommerce__woocommerce-58700
[ 58401 ]
9db10f00d6e0a81a5912b7c4041ba24107034ca1
diff --git a/plugins/woocommerce/changelog/58700-wooplug-4457-rest-api-orders-get-with-coupons-has-typeerror-preg_match b/plugins/woocommerce/changelog/58700-wooplug-4457-rest-api-orders-get-with-coupons-has-typeerror-preg_match new file mode 100644 index 0000000000000..a412a1794be17 --- /dev/null +++ b/plugins/woocomm...
diff --git a/plugins/woocommerce/tests/legacy/unit-tests/coupon/coupon.php b/plugins/woocommerce/tests/legacy/unit-tests/coupon/coupon.php index c7c107ba3b0c6..9e9f6289f83f0 100644 --- a/plugins/woocommerce/tests/legacy/unit-tests/coupon/coupon.php +++ b/plugins/woocommerce/tests/legacy/unit-tests/coupon/coupon.php @@ ...
REST API orders GET with coupons has TypeError: preg_match Argument 2 must be of type string stdClass given abstract-wc-data.php:910 ### Prerequisites - [x] I have carried out troubleshooting steps and I believe I have found a bug. - [x] I have searched for similar bugs in both open and closed issues and cannot find a...
Hey @seanconklin - Thanks for reporting this. This has been fixed in the following PR and it's planned for release in WC 10.2.0 - https://github.com/woocommerce/woocommerce/pull/58700
[ "https://github.com/woocommerce/woocommerce/commit/9edb76c066dc5da10c27f5c410aff041132f6f33", "https://github.com/woocommerce/woocommerce/commit/d44fb4fee758f6fdcc148dea678760ced315a06d", "https://github.com/woocommerce/woocommerce/commit/135697f19738997bc56b182ec72a7d4801a515a2", "https://github.com/woocomme...
2025-06-10T20:13:49
2.2
PHP
woocommerce/woocommerce
47,832
woocommerce__woocommerce-47832
[ 47769 ]
50396961b0fb280583d9f14f655eb403d0835e70
diff --git a/plugins/woocommerce-admin/client/launch-your-store/hub/sidebar/xstate.tsx b/plugins/woocommerce-admin/client/launch-your-store/hub/sidebar/xstate.tsx index c937630a64c4f..c51f718894939 100644 --- a/plugins/woocommerce-admin/client/launch-your-store/hub/sidebar/xstate.tsx +++ b/plugins/woocommerce-admin/cli...
diff --git a/plugins/woocommerce/changelog/47832-add-47769-delete-test-orders-in-lys b/plugins/woocommerce/changelog/47832-add-47769-delete-test-orders-in-lys new file mode 100644 index 0000000000000..fec50a6d8a021 --- /dev/null +++ b/plugins/woocommerce/changelog/47832-add-47769-delete-test-orders-in-lys @@ -0,0 +1,4 ...
Delete test orders in LYS hub ## Issue Description Provide an option to delete test orders in LYS. For the first implementation, delete test orders made with the WooPayments payment gateway only. For details about it's test mode, see: https://woocommerce.com/document/woopayments/testing-and-troubleshooting/testing/ W...
**Dev note** The [doc](https://woocommerce.com/document/managing-orders/testing-orders/) says: > There is currently no visual difference or special status for test orders. As a result, other extensions, plugins, or services that integrate with WooCommerce, may be unable to differentiate between these test orders and ...
**Dev note** The [doc](https://woocommerce.com/document/managing-orders/testing-orders/) says: > There is currently no visual difference or special status for test orders. As a result, other extensions, plugins, or services that integrate with WooCommerce, may be unable to differentiate between these test orders and ...
[ "https://github.com/woocommerce/woocommerce/commit/23918972820dbe782a7d79fe744efad24c348269", "https://github.com/woocommerce/woocommerce/commit/10b7fb82854ffd677893fa5417c8a38df3ec94d4", "https://github.com/woocommerce/woocommerce/commit/f3acae25f886f7631f68cad8be85007657667331", "https://github.com/woocomme...
2024-05-26T03:35:19
2.2
PHP
woocommerce/woocommerce
39,700
woocommerce__woocommerce-39700
[ 39215 ]
2afba8b8fef45fff70fb1177932e4813725d9711
diff --git a/plugins/woocommerce/changelog/fix-39215-alternative-refund-meta-keys b/plugins/woocommerce/changelog/fix-39215-alternative-refund-meta-keys new file mode 100644 index 0000000000000..903db8f99811f --- /dev/null +++ b/plugins/woocommerce/changelog/fix-39215-alternative-refund-meta-keys @@ -0,0 +1,4 @@ +Signi...
diff --git a/plugins/woocommerce/tests/php/src/Internal/DataStores/Orders/OrdersTableRefundDataStoreTests.php b/plugins/woocommerce/tests/php/src/Internal/DataStores/Orders/OrdersTableRefundDataStoreTests.php index f82c62b45bcbe..e3d00bd5fb88f 100644 --- a/plugins/woocommerce/tests/php/src/Internal/DataStores/Orders/Or...
HPOS - Refund amount is missing in Woo API order refunds response payload and in data received via Webhooks if HPOS is enabled ### Prerequisites - [X] I have carried out troubleshooting steps and I believe I have found a bug. - [X] I have searched for similar bugs in both open and closed issues and cannot find a du...
@m-mikelkevicius I can only partially reproduce this. If I do a partial or refund on an order while HPOS is enabled, I see the same `refunded_by` value that you do, `0` (i.e. no user ID is present). However, I am seeing the correct value for `amount`. If I switch the data storage setting to "WordPress post tables", I s...
@m-mikelkevicius I can only partially reproduce this. If I do a partial or refund on an order while HPOS is enabled, I see the same `refunded_by` value that you do, `0` (i.e. no user ID is present). However, I am seeing the correct value for `amount`. If I switch the data storage setting to "WordPress post tables", I s...
[ "https://github.com/woocommerce/woocommerce/commit/11a31e8b64f33fb12fcd76f87ce13d849cc2a85f", "https://github.com/woocommerce/woocommerce/commit/07137472a411390c93a3f267808331eef50579fb" ]
2023-08-11T21:15:35
2.2
PHP
woocommerce/woocommerce
46,140
woocommerce__woocommerce-46140
[ 46133 ]
6328ad01a5756b332364e550ce32657231dcf62b
diff --git a/plugins/woocommerce-admin/client/launch-your-store/settings/slotfill.js b/plugins/woocommerce-admin/client/launch-your-store/settings/slotfill.js index c9d8ece38ce38..7cea29f7ec55a 100644 --- a/plugins/woocommerce-admin/client/launch-your-store/settings/slotfill.js +++ b/plugins/woocommerce-admin/client/la...
diff --git a/plugins/woocommerce/tests/php/includes/settings/class-wc-settings-general-test.php b/plugins/woocommerce/tests/php/includes/settings/class-wc-settings-general-test.php index 6eed85dad207d..31ddc74339052 100644 --- a/plugins/woocommerce/tests/php/includes/settings/class-wc-settings-general-test.php +++ b/pl...
[Launch Your Store] Site Visibility tab ## Issue Description Move the site visibility settings to a new tab named "Site Visibility". ![Image](https://github.com/woocommerce/woocommerce/assets/9312929/d87a98af-735c-4a89-bfeb-f3bc35d8c3ae) ## Acceptance Criteria * Create a settings tab named "Site Visibility" * Move th...
[ "https://github.com/woocommerce/woocommerce/commit/4b44192cdcb2766ed45934b140776b5b03cb12df", "https://github.com/woocommerce/woocommerce/commit/7b173fec04caa3939ddef3f7b0cbf6a689570069", "https://github.com/woocommerce/woocommerce/commit/523e5026164af4d93c4a9c1c93e2535f32c7aefe", "https://github.com/woocomme...
2024-04-02T20:40:57
2.2
PHP
woocommerce/woocommerce
59,586
woocommerce__woocommerce-59586
[ 59354 ]
61045517bd46d7b9bcc1851f12e3aec20c0e8ea5
diff --git a/plugins/woocommerce/changelog/59586-wooplug-4867-the-endpoint-wp-jsonwcv3productsorderbyprice-returns b/plugins/woocommerce/changelog/59586-wooplug-4867-the-endpoint-wp-jsonwcv3productsorderbyprice-returns new file mode 100644 index 0000000000000..61d13d00d777d --- /dev/null +++ b/plugins/woocommerce/chang...
diff --git a/plugins/woocommerce/tests/legacy/framework/helpers/class-wc-helper-product.php b/plugins/woocommerce/tests/legacy/framework/helpers/class-wc-helper-product.php index 5067fa019c281..fd8944d6498be 100644 --- a/plugins/woocommerce/tests/legacy/framework/helpers/class-wc-helper-product.php +++ b/plugins/woocom...
The endpoint `wp-json/wc/v3/products?orderby=price` returns incorrect ordering when grouped products are included. ## **Describe the bug** Using the attached [sample_products.csv](https://github.com/user-attachments/files/21013364/sample_products.csv), fetching `wp-json/wc/v3/products?orderby=price` returns this JSON ...
[ "https://github.com/woocommerce/woocommerce/commit/b7cd2572a05032c149a2438169f3132659b26ac3", "https://github.com/woocommerce/woocommerce/commit/59afd757e69f490fff7755150ae315c8137831af", "https://github.com/woocommerce/woocommerce/commit/5cbd67e232ced1d2b6d40d5996e4d474a7c988f3", "https://github.com/woocomme...
2025-07-10T09:41:07
2.2
PHP
statamic/cms
10,059
statamic__cms-10059
[ 10040, 10050, 10056 ]
b65a7f1c1ab982ef0095d133d230482f392c2380
diff --git a/src/Fields/ConfigField.php b/src/Fields/ConfigField.php index dd51455f8f3..4f59c87b6a0 100644 --- a/src/Fields/ConfigField.php +++ b/src/Fields/ConfigField.php @@ -12,4 +12,9 @@ public function preProcess() return $this->newInstance()->setValue($value); } + + public function mustRemainIn...
diff --git a/tests/Fields/FieldTransformerTest.php b/tests/Fields/FieldTransformerTest.php index c911b95d932..4d2f9d98fe6 100644 --- a/tests/Fields/FieldTransformerTest.php +++ b/tests/Fields/FieldTransformerTest.php @@ -2,11 +2,16 @@ namespace Tests\Fields; +use Statamic\Facades\AssetContainer; use Statamic\Fiel...
Field config toggles with default `true` can't be set to `false` ### Bug description It's not possible to set a field config toggle value that has a default of `true` to `false` through the blueprint editor. When you save the key is removed from the YAML. I'm guessing this is caused by https://github.com/statamic/cms/...
[ "https://github.com/statamic/cms/commit/25ec5f84acecedfe388eb8e279997fd687e0a206", "https://github.com/statamic/cms/commit/8ee8464f8eef23b5710f477636337a2392653e54", "https://github.com/statamic/cms/commit/fa0053a54657f9cb582097281bdefc2c972e1227", "https://github.com/statamic/cms/commit/b478791b1caa067ab54b5...
2024-05-13T20:28:34
3.0
PHP
statamic/cms
8,892
statamic__cms-8892
[ 2635 ]
26e5277864222805b4c02da55f0d8e598cdd106d
diff --git a/src/Forms/Email.php b/src/Forms/Email.php index 1c6f429d8c7..ec4d3b2eda6 100644 --- a/src/Forms/Email.php +++ b/src/Forms/Email.php @@ -22,6 +22,7 @@ class Email extends Mailable protected $submissionData; protected $config; protected $site; + private $globalData; public function _...
diff --git a/tests/Forms/EmailTest.php b/tests/Forms/EmailTest.php index b942bc9ec7c..4eeaaf94b6e 100644 --- a/tests/Forms/EmailTest.php +++ b/tests/Forms/EmailTest.php @@ -7,6 +7,7 @@ use Mockery; use Statamic\Facades\Blueprint; use Statamic\Facades\Form; +use Statamic\Facades\GlobalSet; use Statamic\Facades\Site;...
[Forms] Impossible to use globals in form settings ## Bug Description It seems impossible to use global values in forms. I have globals set named "Company information" that contain an "email" handle which serves as the company's main email. If I want to use that value as the form recipient, it throws an error (I valid...
Pretty sure this is a duplicate. Or maybe a FR. However I can’t seem to find it now. This issue has not had recent activity and has been marked as stale β€” by me, a robot. Simply reply to keep it open and send me away. If you do nothing, I will close it in a week. I have no feelings, so whatever you do is fine by me. πŸ¦™...
Pretty sure this is a duplicate. Or maybe a FR. However I can’t seem to find it now. This issue has not had recent activity and has been marked as stale β€” by me, a robot. Simply reply to keep it open and send me away. If you do nothing, I will close it in a week. I have no feelings, so whatever you do is fine by me. πŸ¦™...
[ "https://github.com/statamic/cms/commit/ad7ceee8a9c4e25ae58c270e187df97b5354bf0b", "https://github.com/statamic/cms/commit/d6d522eb52f2d697c301a8e2f1a42617211663f9", "https://github.com/statamic/cms/commit/a715bb3a8b743dd6eaeb538626cda555fd55af56" ]
2023-10-30T12:11:40
3.0
PHP
statamic/cms
11,479
statamic__cms-11479
[ 11480 ]
4ace9665fc598a50e144f8ab6f7b07bf8c2dde59
diff --git a/src/Assets/Attributes.php b/src/Assets/Attributes.php index 010de336ccd..fba9435e2f5 100644 --- a/src/Assets/Attributes.php +++ b/src/Assets/Attributes.php @@ -88,9 +88,18 @@ private function getVideoAttributes() { $id3 = ExtractInfo::fromAsset($this->asset); + $width = Arr::get($id3...
diff --git a/tests/Assets/AttributesTest.php b/tests/Assets/AttributesTest.php index 6cd3786556d..87fc3d02cab 100644 --- a/tests/Assets/AttributesTest.php +++ b/tests/Assets/AttributesTest.php @@ -6,6 +6,7 @@ use Illuminate\Http\UploadedFile; use Illuminate\Support\Carbon; use Illuminate\Support\Facades\Storage; +us...
Video dimensions of rotated videos ### Bug description The dimensions fields `width` and `height` are swapped for videos with rotated video streams. PR is up: #11479 ### How to reproduce Upload a video with a rotated video stream. ### Logs ```shell ``` ### Environment ```yaml Environment Application Name: Sta...
[ "https://github.com/statamic/cms/commit/2e1218cfd1a93d8fdeb230acc58ef5d050d85f8f", "https://github.com/statamic/cms/commit/43bbf7a303bc8a10198f5c7e920c6a8a19da2d86", "https://github.com/statamic/cms/commit/d981ca31d5ac0784126c5a7ab7d74746457f0428" ]
2025-02-21T00:48:08
3.0
PHP
statamic/cms
10,595
statamic__cms-10595
[ 10589 ]
4f8f2e682717414add6dc2bce1f7bb73cfc94694
diff --git a/src/Contracts/Support/Boolable.php b/src/Contracts/Support/Boolable.php new file mode 100644 index 00000000000..3cda81ce653 --- /dev/null +++ b/src/Contracts/Support/Boolable.php @@ -0,0 +1,8 @@ +<?php + +namespace Statamic\Contracts\Support; + +interface Boolable +{ + public function toBool(): bool; +}...
diff --git a/tests/Antlers/Runtime/TemplateTest.php b/tests/Antlers/Runtime/TemplateTest.php index 928d2b3725b..5d0b2db1f1d 100644 --- a/tests/Antlers/Runtime/TemplateTest.php +++ b/tests/Antlers/Runtime/TemplateTest.php @@ -12,12 +12,14 @@ use PHPUnit\Framework\Attributes\Test; use Statamic\Contracts\Data\Augmentabl...
Ternary statement in partial evaluates as true for null values ### Bug description When using a ternary statement within a partial to check if a value is set, the ternary expression is evaluated as true even if the value is null. ### How to reproduce 1. Add a select field `select_field` with some random option...
I wish there was a magic `__toBool()` method like `__toString()`. We can probably make this work in Antlers though. πŸ‘Œ > We can probably make this work in Antlers though. πŸ‘Œ This is already magically working with null values, but not when the ternary statement is used in a partial for some reason πŸ€·β€β™‚οΈ
I wish there was a magic `__toBool()` method like `__toString()`. We can probably make this work in Antlers though. πŸ‘Œ > We can probably make this work in Antlers though. πŸ‘Œ This is already magically working with null values, but not when the ternary statement is used in a partial for some reason πŸ€·β€β™‚οΈ
[ "https://github.com/statamic/cms/commit/8880cbf3c4b5ca6470a35fc29652e63ec99a5bc3", "https://github.com/statamic/cms/commit/3aaf7b48ac30b3762f6277b1fb0c79d737bee75b", "https://github.com/statamic/cms/commit/8ffc5093cfcb571f0acc7450eb8e1e9d90c43140", "https://github.com/statamic/cms/commit/70dab7be6df6af8a4178f...
2024-08-07T20:59:19
3.0
PHP
statamic/cms
7,313
statamic__cms-7313
[ 7312 ]
4105bb67e94646af98156837124485c7cc80d971
diff --git a/routes/cp.php b/routes/cp.php index e115e215cfb..d367911eeda 100644 --- a/routes/cp.php +++ b/routes/cp.php @@ -134,7 +134,7 @@ Route::post('assets/actions', 'ActionController@run')->name('assets.actions.run'); Route::post('assets/actions/list', 'ActionController@bulkActions')->name('asse...
diff --git a/tests/Feature/Assets/BrowserTest.php b/tests/Feature/Assets/BrowserTest.php index a2139bc76f4..35da9b6c637 100644 --- a/tests/Feature/Assets/BrowserTest.php +++ b/tests/Feature/Assets/BrowserTest.php @@ -237,6 +237,13 @@ public function it_searches_for_assets() ->assertSuccessful() ...
Can't search assets in asset browser stack in Runway ### Bug description I use Duncan's Runway, and in the CP (in Runway) attempt to update an asset field. In the stacked asset browser, when I search, the url used gets matched to the wrong CP route, do to extra url segments. However I can reproduce the issue using ...
[ "https://github.com/statamic/cms/commit/27196399d112da593b616d585795b7697d155d04", "https://github.com/statamic/cms/commit/a61e242adb103d0776d019726706be9aee4e80d1", "https://github.com/statamic/cms/commit/89a8199049105e211c658d4db0b1fea9be4e9fa4" ]
2023-01-06T01:04:07
3.0
PHP
vimeo/psalm
10,621
vimeo__psalm-10621
[ 10561 ]
abe7ae828d0004ecaeadf4350a793f6ff7cef374
diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterUtils.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterUtils.php index e0de55bba04..5c32126de0e 100644 --- a/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterUtils.php +++ b/src/Psalm/Internal/Provider/ReturnTypeProvider/FilterUtils.php @@ ...
diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php index f5965f98f40..27b10b28228 100644 --- a/tests/FunctionCallTest.php +++ b/tests/FunctionCallTest.php @@ -1118,6 +1118,24 @@ function filterFloat(string $s) : float { } function filterFloatWithDefault(string...
Assumed filter_var return type can be incorrect Psalm gets a bit confused about the return value from `filter_var` when called with `FILTER_VALIDATE_INT`, a numeric value and some options. https://psalm.dev/r/c1579d2079
I found these snippets: <details> <summary>https://psalm.dev/r/c1579d2079</summary> ```php <?php // validate(50) returns 50 // validate(9000) returns NULL function validate(mixed $c): ?int { // This is_numeric check makes psalm confused about $ret if (is_numeric($c)) { $ret = filter_var($c, FILTER_...
I found these snippets: <details> <summary>https://psalm.dev/r/c1579d2079</summary> ```php <?php // validate(50) returns 50 // validate(9000) returns NULL function validate(mixed $c): ?int { // This is_numeric check makes psalm confused about $ret if (is_numeric($c)) { $ret = filter_var($c, FILTER_...
[ "https://github.com/vimeo/psalm/commit/551625aa4b57fa0bbcdb115d0e6a14f63924fff0", "https://github.com/vimeo/psalm/commit/7023855fb3e8652417c1ec27ead2b33b41226ce4" ]
2024-01-31T13:23:57
0.2
PHP
vimeo/psalm
10,617
vimeo__psalm-10617
[ 10416 ]
baa866029e18b0152c76ead4b7c5647757e225e0
diff --git a/src/Psalm/Internal/Type/TypeExpander.php b/src/Psalm/Internal/Type/TypeExpander.php index 795b5ad9a8a..61af641066f 100644 --- a/src/Psalm/Internal/Type/TypeExpander.php +++ b/src/Psalm/Internal/Type/TypeExpander.php @@ -283,7 +283,7 @@ public static function expandAtomic( $declaring_fq_cla...
diff --git a/tests/TypeAnnotationTest.php b/tests/TypeAnnotationTest.php index 29ee8f6581f..dbcbf0b987d 100644 --- a/tests/TypeAnnotationTest.php +++ b/tests/TypeAnnotationTest.php @@ -865,6 +865,25 @@ public function doesNotWork($_doesNotWork): void { } }', ],...
``@psalm-import-type`` fails importing from ``enum`` Psalm fails importing a type with ``@psalm-import-type`` when importing from ``enum`` instead from a class: https://psalm.dev/r/4fc46bc2a6
I found these snippets: <details> <summary>https://psalm.dev/r/4fc46bc2a6</summary> ```php <?php /** @psalm-type FooClassType = array{value: string} */ class FooClass {} /** @psalm-type FooEnumType = array{value: string} */ enum FooEnum {} /** * @psalm-import-type FooClassType from FooClass * @psalm-import-type F...
I found these snippets: <details> <summary>https://psalm.dev/r/4fc46bc2a6</summary> ```php <?php /** @psalm-type FooClassType = array{value: string} */ class FooClass {} /** @psalm-type FooEnumType = array{value: string} */ enum FooEnum {} /** * @psalm-import-type FooClassType from FooClass * @psalm-import-type F...
[ "https://github.com/vimeo/psalm/commit/6d32d2f69276b31723c98f590f68866972839187" ]
2024-01-30T19:31:52
0.2
PHP
vimeo/psalm
10,722
vimeo__psalm-10722
[ 9782 ]
d3c1222152e000b6a81f37e0a1728b85c38c3659
diff --git a/src/Psalm/Internal/Type/TypeCombiner.php b/src/Psalm/Internal/Type/TypeCombiner.php index e21d41b0559..099ae82c7fc 100644 --- a/src/Psalm/Internal/Type/TypeCombiner.php +++ b/src/Psalm/Internal/Type/TypeCombiner.php @@ -1047,12 +1047,19 @@ private static function scrapeStringProperties( ...
diff --git a/tests/TypeCombinationTest.php b/tests/TypeCombinationTest.php index 56af82a69ed..841fbd67e36 100644 --- a/tests/TypeCombinationTest.php +++ b/tests/TypeCombinationTest.php @@ -127,6 +127,40 @@ function takesLiteralString($arg) {} '$x===' => 'non-falsy-string', ], ...
Loop: uppercase literal strings inferred as non-empty-lowercase-string when combined with numeric-strings https://psalm.dev/r/5dda068487 When a string is concat with int/numeric-string, psalm discards any literal non-lowercase-strings and just assumes they're all lowercase. When using "normal" (non-numeric) strin...
I found these snippets: <details> <summary>https://psalm.dev/r/5dda068487</summary> ```php <?php /** * @return int[] */ function getIntArray() {} $final = array(); foreach ( getIntArray() as $id ) { $final[] = 'TEXT'; $final[] = 'some_' . $id; } /** @psalm-trace $final */; /** * @return string[] */ funct...
I found these snippets: <details> <summary>https://psalm.dev/r/5dda068487</summary> ```php <?php /** * @return int[] */ function getIntArray() {} $final = array(); foreach ( getIntArray() as $id ) { $final[] = 'TEXT'; $final[] = 'some_' . $id; } /** @psalm-trace $final */; /** * @return string[] */ funct...
[ "https://github.com/vimeo/psalm/commit/f035c00a21c6dfb3d6887b56d1da524c655dd19d", "https://github.com/vimeo/psalm/commit/4ac18720aab9dda3c3fc3d5a2d55d8ce2fdf5150" ]
2024-02-19T10:33:30
0.2
PHP
vimeo/psalm
9,130
vimeo__psalm-9130
[ 9102 ]
b6bdc9407020547eb35ea72ac2a5c710c7e18ffa
diff --git a/config.xsd b/config.xsd index 046547eeeed..4f4b7f82a8b 100644 --- a/config.xsd +++ b/config.xsd @@ -44,6 +44,8 @@ <xs:attribute name="findUnusedCode" type="xs:boolean" default="false" /> <xs:attribute name="findUnusedVariablesAndParams" type="xs:boolean" default="false" /> <xs:at...
diff --git a/tests/Config/CreatorTest.php b/tests/Config/CreatorTest.php index 23bd7d6ee0d..a38c3e95ce7 100644 --- a/tests/Config/CreatorTest.php +++ b/tests/Config/CreatorTest.php @@ -38,6 +38,7 @@ public function testDiscoverLibDirectory(): void xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="h...
[Feature request] Report unmatched baseline rules It would be great IMO to force contributors to show the positive effect of their changes by erroring out if there are unused baseline elements or [issue handlers](https://github.com/vimeo/psalm/issues/3262): 1. It validates further that what they are doing is right. 2...
Hey @greg0ire, can you reproduce the issue on https://psalm.dev ?
Hey @greg0ire, can you reproduce the issue on https://psalm.dev ?
[ "https://github.com/vimeo/psalm/commit/56f6dfecc8b7eae6e8e02f79252a1636637dd49e" ]
2023-01-18T00:30:59
0.2
PHP
vimeo/psalm
9,043
vimeo__psalm-9043
[ 9042 ]
c6cfa86f35350842d00e8f1f3b92839fbda5f8f9
diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/DateTimeModifyReturnTypeProvider.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/DateTimeModifyReturnTypeProvider.php index 1b71f1a27db..83d32a7ca01 100644 --- a/src/Psalm/Internal/Provider/ReturnTypeProvider/DateTimeModifyReturnTypeProvider.php +++ b/src...
diff --git a/tests/DateTimeTest.php b/tests/DateTimeTest.php index 25a69376e4a..3d640568487 100644 --- a/tests/DateTimeTest.php +++ b/tests/DateTimeTest.php @@ -44,8 +44,8 @@ function getString(): string $b = $dateTimeImmutable->modify(getString()); ', 'asserti...
DateTimeImutable::modify() should return `static` DateTime type issues strike back... https://psalm.dev/r/09e238bf00 I expect `$foo2` to be of type `Subclass` and indeed, according to PHP it is: https://3v4l.org/j9ZSo I agree that the PHP manual [disagrees](https://www.php.net/manual/en/datetimeimmutable.mo...
I found these snippets: <details> <summary>https://psalm.dev/r/09e238bf00</summary> ```php <?php class Subclass extends DateTimeImmutable { } $foo = new Subclass('2023-01-01 12:12:13'); $foo2 = $foo->modify('+7 days'); /** @psalm-trace $foo2 */ echo $foo2->format('Y-m-d'); ``` ``` Psalm output (using commit c6cfa86...
I found these snippets: <details> <summary>https://psalm.dev/r/09e238bf00</summary> ```php <?php class Subclass extends DateTimeImmutable { } $foo = new Subclass('2023-01-01 12:12:13'); $foo2 = $foo->modify('+7 days'); /** @psalm-trace $foo2 */ echo $foo2->format('Y-m-d'); ``` ``` Psalm output (using commit c6cfa86...
[ "https://github.com/vimeo/psalm/commit/bab17568dcb856ef2232865a637feaefb8db8a7b" ]
2023-01-03T11:12:07
0.2
PHP
mongodb/laravel-mongodb
2,682
mongodb__laravel-mongodb-2682
[ 2391 ]
1c2d1fe29a53278ec34a50c1a289b5e3a8f1a838
diff --git a/src/Schema/Blueprint.php b/src/Schema/Blueprint.php index 2580c407f..6dd28d3b2 100644 --- a/src/Schema/Blueprint.php +++ b/src/Schema/Blueprint.php @@ -5,6 +5,7 @@ namespace MongoDB\Laravel\Schema; use Illuminate\Database\Connection; +use Illuminate\Database\Schema\Blueprint as SchemaBlueprint; use Mo...
diff --git a/tests/SchemaTest.php b/tests/SchemaTest.php index 6befaa942..6e6248beb 100644 --- a/tests/SchemaTest.php +++ b/tests/SchemaTest.php @@ -337,6 +337,46 @@ public function testSparseUnique(): void $this->assertEquals(1, $index['unique']); } + public function testRenameColumn(): void + { ...
Rename column in migration has no effect - Laravel-mongodb Version: 3.8 - PHP Version: 8.1.16 - Database Driver & Version: MongoDB 4.4.14, mongodb php driver 1.13.0 ### Description: When I try to rename a field of a collection within a migration using ```$table->renameColumn()``` the migration runs without erro...
I'm also facing the same issue, No error but renaming has not happened. @flappix did you get any solution for this? No, I think the schema builder is not capable of doing this. You could use a raw query instead of the schema builder like ``` public function up() { DB::collection('users')->update([ ...
I'm also facing the same issue, No error but renaming has not happened. @flappix did you get any solution for this? No, I think the schema builder is not capable of doing this. You could use a raw query instead of the schema builder like ``` public function up() { DB::collection('users')->update([ ...
[ "https://github.com/mongodb/laravel-mongodb/commit/40f738d31fa6d1a2a7fc62c5a6249ce5c65b5a3c", "https://github.com/mongodb/laravel-mongodb/commit/676244152e533c94c73ff7b924352083d2614a43", "https://github.com/mongodb/laravel-mongodb/commit/afa9b7c14919c94756c08af93ae7a431babe69e6", "https://github.com/mongodb/...
2023-11-19T13:46:32
4.1
PHP
mongodb/laravel-mongodb
3,332
mongodb__laravel-mongodb-3332
[ 3184 ]
e62b1d5cac1ddb07f77b7d0d5bce066bfb184f24
diff --git a/src/Connection.php b/src/Connection.php index 4dd04120d..29b72ae44 100644 --- a/src/Connection.php +++ b/src/Connection.php @@ -53,6 +53,9 @@ class Connection extends BaseConnection private ?CommandSubscriber $commandSubscriber = null; + /** @var bool Whether to rename the rename "id" into "_id...
diff --git a/tests/Query/BuilderTest.php b/tests/Query/BuilderTest.php index 20b5a12fb..6e68d42c7 100644 --- a/tests/Query/BuilderTest.php +++ b/tests/Query/BuilderTest.php @@ -12,7 +12,6 @@ use Illuminate\Tests\Database\DatabaseQueryBuilderTest; use InvalidArgumentException; use LogicException; -use Mockery as m; ...
[Feature Request] Options to ignore auto conversion id to _id ### Is your feature request related to a problem? We have a `merchant.id` field in our mongodb document, and after upgrading to mongodb driver 5.1 we encountered issue that mongodb driver modify the where query from `merchant.id` to `merchant._id` which res...
I am looking for the solution here **protected $primaryKey = '_id';** I tried to put above line in model that is not working as well if we want to go with _id there must a be please guide. > I am looking for the solution here What I've done to get rid of the issue is by downgrading the MongoDB d...
I am looking for the solution here **protected $primaryKey = '_id';** I tried to put above line in model that is not working as well if we want to go with _id there must a be please guide. > I am looking for the solution here What I've done to get rid of the issue is by downgrading the MongoDB d...
[ "https://github.com/mongodb/laravel-mongodb/commit/3b4ad5ab55033528ad2383d01a8fdbc81c7f96b6", "https://github.com/mongodb/laravel-mongodb/commit/f7809069deddd5767147cc1efe0208801d0bd048", "https://github.com/mongodb/laravel-mongodb/commit/48c14cccb63383ad9b0dc413976d579cf3600025", "https://github.com/mongodb/...
2025-04-01T14:57:42
4.8
PHP
mongodb/laravel-mongodb
2,877
mongodb__laravel-mongodb-2877
[ 2609, 2718 ]
6b9511f7d9feb25c9d1435d1554e71e3fa3956af
diff --git a/CHANGELOG.md b/CHANGELOG.md index 55a84247e..f653604ea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. * New aggregation pipeline builder by @GromNaN in [#2738](https://github.com/mongodb/laravel-mongodb/pull/2738) * Drop s...
diff --git a/tests/Cache/MongoCacheStoreTest.php b/tests/Cache/MongoCacheStoreTest.php new file mode 100644 index 000000000..4ee97e75a --- /dev/null +++ b/tests/Cache/MongoCacheStoreTest.php @@ -0,0 +1,231 @@ +<?php + +namespace MongoDB\Laravel\Tests\Cache; + +use Illuminate\Cache\Repository; +use Illuminate\Support\Ca...
Can't store cache lock - Laravel-mongodb Version: #.#.# - PHP Version: #.#.# - Database Driver & Version: ### Description: I have issue when store data to cache lock with MongoDB driver. error also occurs when dispatch a job implements ShouldBeUnique. Method acquire Illuminate\Cache\DatabaseLock catch Query...
Thank you for reporting this! It looks like one way would be to only throw a `QueryException` from the MongoDB connection. However, this is not really desirable, as `QueryException` extends `PDOException`, which definitely isn't the right inheritance chain. Instead, we would either have to provide our own `DatabaseStor...
Thank you for reporting this! It looks like one way would be to only throw a `QueryException` from the MongoDB connection. However, this is not really desirable, as `QueryException` extends `PDOException`, which definitely isn't the right inheritance chain. Instead, we would either have to provide our own `DatabaseStor...
[ "https://github.com/mongodb/laravel-mongodb/commit/c9b2e3c6e9824bb4093a74a6e17046f58bcd8c90" ]
2024-04-16T22:40:20
4.2
PHP
mongodb/laravel-mongodb
2,669
mongodb__laravel-mongodb-2669
[ 2657 ]
5387d548b0009feb128ee32d91d1a8213d23a0c4
diff --git a/src/Eloquent/HybridRelations.php b/src/Eloquent/HybridRelations.php index 9e11605a3..f0824c9fb 100644 --- a/src/Eloquent/HybridRelations.php +++ b/src/Eloquent/HybridRelations.php @@ -221,7 +221,7 @@ public function morphTo($name = null, $type = null, $id = null, $ownerKey = null $this->ne...
diff --git a/tests/Models/Photo.php b/tests/Models/Photo.php index dbb92b0ff..74852dc28 100644 --- a/tests/Models/Photo.php +++ b/tests/Models/Photo.php @@ -17,4 +17,9 @@ public function hasImage(): MorphTo { return $this->morphTo(); } + + public function hasImageWithCustomOwnerKey(): MorphTo + ...
Support for morphTo relations broken in 4.1 - Laravel-mongodb Version: 4.1.dev - PHP Version: 8.2.11 - Database Driver & Version: 1.16.2 (6.0.3) ### Description: There has been working support for morphTo relations, but that seems to break after upgrading from 4.0 to 4.1. ### Steps to reproduce 1. You need ...
I also noticed that MorphTo relations are not listed as supported relations on the readme. They have worked nicely before though - so is it safe to assume these will be supported in the future too? Because if not, this would mean migrating away from Mongo in our current project. Hi @apeisa, I was working on this issue ...
I also noticed that MorphTo relations are not listed as supported relations on the readme. They have worked nicely before though - so is it safe to assume these will be supported in the future too? Because if not, this would mean migrating away from Mongo in our current project. Hi @apeisa, I was working on this issue ...
[ "https://github.com/mongodb/laravel-mongodb/commit/54c9a859b66bab3b5425e5845e8e3daa839d7fa6", "https://github.com/mongodb/laravel-mongodb/commit/1a5fd7aba3185fbe4f3da479c7ed31cc5de3704d", "https://github.com/mongodb/laravel-mongodb/commit/c7287791bb3beb993033d2b1b5e8b3a70f0f673e", "https://github.com/mongodb/...
2023-11-06T14:27:31
4.1
PHP
mongodb/laravel-mongodb
3,167
mongodb__laravel-mongodb-3167
[ 3166 ]
5c7e2401e98ddf9592e9360f0f17e2b595271055
diff --git a/src/Connection.php b/src/Connection.php index a76ddc010..84ca97aba 100644 --- a/src/Connection.php +++ b/src/Connection.php @@ -48,7 +48,7 @@ class Connection extends BaseConnection */ protected $connection; - private ?CommandSubscriber $commandSubscriber; + private ?CommandSubscriber $c...
diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php index 4f9dfa10c..fe3272943 100644 --- a/tests/ConnectionTest.php +++ b/tests/ConnectionTest.php @@ -277,6 +277,31 @@ public function testQueryLog() } } + public function testDisableQueryLog() + { + // Disabled by default + ...
Performance Regression 5.x - Laravel-mongodb Version: 5.0.2 - PHP Version: 8.3.12 - Database Driver & Version: pecl/mongodb-1.20.0 ### Description: Hello, We are experiencing a significant performance regression after upgrading to the latest version 5.0.2. Our test suite, comprising approximately 400 test...
Thank you for the report and the demo app; that will definitely help us investigate. This issue is tracked in our Jira for investigation [PHPORM-248](https://jira.mongodb.org/browse/PHPORM-248). I'll check the [`CommandSubscriber`](https://github.com/mongodb/laravel-mongodb/blob/5.x/src/CommandSubscriber.php). Thank...
Thank you for the report and the demo app; that will definitely help us investigate. This issue is tracked in our Jira for investigation [PHPORM-248](https://jira.mongodb.org/browse/PHPORM-248). I'll check the [`CommandSubscriber`](https://github.com/mongodb/laravel-mongodb/blob/5.x/src/CommandSubscriber.php). Thank...
[ "https://github.com/mongodb/laravel-mongodb/commit/1c83dab189591d0d3e034f2ddd5b822b222825fe", "https://github.com/mongodb/laravel-mongodb/commit/28185389f4f0354937aa122626998c00525f1667" ]
2024-10-03T20:02:15
4.8
PHP
prism-php/prism
497
prism-php__prism-497
[ 479 ]
2ee808f4bdc62b9571082807cec2fc6da522246a
diff --git a/src/Providers/OpenAI/Handlers/Structured.php b/src/Providers/OpenAI/Handlers/Structured.php index 7d6af105f..6ba1ae55a 100644 --- a/src/Providers/OpenAI/Handlers/Structured.php +++ b/src/Providers/OpenAI/Handlers/Structured.php @@ -132,7 +132,9 @@ protected function handleStructuredMode(Request $request): ...
diff --git a/tests/Providers/OpenAI/StructuredTest.php b/tests/Providers/OpenAI/StructuredTest.php index 30b6f6fc8..5bb81a9d4 100644 --- a/tests/Providers/OpenAI/StructuredTest.php +++ b/tests/Providers/OpenAI/StructuredTest.php @@ -317,3 +317,71 @@ return true; }); }); + +it('uses meta to define strict ...
[OpenAi] The `strict` flag when using Structured Mode can only currently be `true` When using OpenAi with a Structured Schema Output, the `strict` flag should be set to `true` or `false`. Currently inside this package, the only accepted value is `true` since setting it to `false` will change it to `null`, which is the...
Does it default to false if not set? > Does it default to false if not set? After some testing, it seems to be `true` by default when using their API
Does it default to false if not set? > Does it default to false if not set? After some testing, it seems to be `true` by default when using their API
[ "https://github.com/prism-php/prism/commit/83b7d0dd1f67c9d5edb814cdcd158e8337cc467e" ]
2025-07-13T19:22:03
0.80
PHP
prism-php/prism
426
prism-php__prism-426
[ 423 ]
28c275b3c4615be9e350dd94e7dc8bdc5cd48d05
diff --git a/src/Providers/Gemini/Handlers/Structured.php b/src/Providers/Gemini/Handlers/Structured.php index 482dffa0a..73bf67846 100644 --- a/src/Providers/Gemini/Handlers/Structured.php +++ b/src/Providers/Gemini/Handlers/Structured.php @@ -110,6 +110,7 @@ protected function addStep(array $data, Request $request): ...
diff --git a/tests/Providers/Gemini/GeminiStructuredTest.php b/tests/Providers/Gemini/GeminiStructuredTest.php index 09c67267b..73f2ec955 100644 --- a/tests/Providers/Gemini/GeminiStructuredTest.php +++ b/tests/Providers/Gemini/GeminiStructuredTest.php @@ -109,10 +109,10 @@ ])) ->withProviderOptions([...
Gemini Caching not working I tried using caching in Gemini as such: ```php $response = Prism::structured() ->using(Provider::Gemini, 'gemini-2.5-flash') ->usingTemperature(0.0) ->withSystemPrompt($systemPrompt) ->withPrompt($inputText) ->...
Ok nvm, so I figured it out. I was including `->withSystemPrompt($systemPrompt)`, which wasn't needed anymore. However, the metadata still seems to indicate no caching, but my prompt and response are as expected, which means it is getting system prompt from the cache. `{"promptTokens":2845,"completionTokens":16,"cach...
Ok nvm, so I figured it out. I was including `->withSystemPrompt($systemPrompt)`, which wasn't needed anymore. However, the metadata still seems to indicate no caching, but my prompt and response are as expected, which means it is getting system prompt from the cache. `{"promptTokens":2845,"completionTokens":16,"cach...
[ "https://github.com/prism-php/prism/commit/550ce0d1bc8d6e322648f3e6f39e7804bf5226d3", "https://github.com/prism-php/prism/commit/fe6f371eed7706454edfaf573bf82f811614dc00", "https://github.com/prism-php/prism/commit/640782715dbb03bb1001b359603e9e81df0bce63" ]
2025-06-21T06:09:29
0.74
PHP
prism-php/prism
442
prism-php__prism-442
[ 439 ]
a16dc7b7c34152d19db1453d31f9c67f15576446
diff --git a/src/Embeddings/PendingRequest.php b/src/Embeddings/PendingRequest.php index 3118c00b2..38716f4ac 100644 --- a/src/Embeddings/PendingRequest.php +++ b/src/Embeddings/PendingRequest.php @@ -80,6 +80,7 @@ protected function toRequest(): Request { return new Request( model: $this->mo...
diff --git a/tests/Testing/AssertRequestTest.php b/tests/Testing/AssertRequestTest.php new file mode 100644 index 000000000..5de757f90 --- /dev/null +++ b/tests/Testing/AssertRequestTest.php @@ -0,0 +1,54 @@ +<?php + +declare(strict_types=1); + +use Prism\Prism\Enums\Provider; +use Prism\Prism\Prism; +use Prism\Prism\T...
Assertions example in docs leads to a call to an undefined method This test fails because `Call to undefined method Prism\Prism\Text\Request::provider()`. It passes otherwise. ```php <?php use Prism\Prism\Prism; use Prism\Prism\Enums\Provider; use Prism\Prism\ValueObjects\Usage; use Prism\Prism\Testing\TextResponseFa...
[ "https://github.com/prism-php/prism/commit/fd41d4b060f56074ec24d059b5dbe3e58b14f7df", "https://github.com/prism-php/prism/commit/6569043c4ea9162e6855034b0f4e678ae8113130" ]
2025-06-24T18:48:30
0.78
PHP
prism-php/prism
639
prism-php__prism-639
[ 533 ]
bbbadc7a77ff5050e86146fab8820abb79f404c2
diff --git a/docs/core-concepts/schemas.md b/docs/core-concepts/schemas.md index a2d0b8b32..345dfcf50 100644 --- a/docs/core-concepts/schemas.md +++ b/docs/core-concepts/schemas.md @@ -131,6 +131,66 @@ $profileSchema = new ObjectSchema( ); ``` +### AnyOfSchema + +For flexible data that can match one of several sche...
diff --git a/tests/Fixtures/openai/anyof-structured-1.json b/tests/Fixtures/openai/anyof-structured-1.json new file mode 100644 index 000000000..87f0e4fa6 --- /dev/null +++ b/tests/Fixtures/openai/anyof-structured-1.json @@ -0,0 +1,30 @@ +{ + "id": "resp_anyof_test_1", + "object": "response", + "created_at": 1741990...
Add Support for OpenAI Extended Schema (Structured Output JSON) I’d like to suggest adding support for OpenAI’s Structured Output schema, which allows us to define richer and more precise response formats when using tools/function calling. OpenAI supports a subset of JSON Schema with some extended properties and types...
Also support of `anyOf` would be extremely helpful I'm open to support the extended schema and would welcome a PR, also with `anyOf` support
Also support of `anyOf` would be extremely helpful I'm open to support the extended schema and would welcome a PR, also with `anyOf` support
[ "https://github.com/prism-php/prism/commit/12fc6ab2bd47480c435c4da7553657f8b4790978", "https://github.com/prism-php/prism/commit/d04d543530dea74b42cd0fef40b7d19ecaac160c", "https://github.com/prism-php/prism/commit/926a8ab061ebe35ad053b9d5e0ebf1d889719965", "https://github.com/prism-php/prism/commit/bd6d93387...
2025-09-25T17:17:37
0.84
PHP
prism-php/prism
13
prism-php__prism-13
[ 3 ]
339c4dca0e2e3d00346d0dba3ca434b888fcc3d9
diff --git a/config/prism.php b/config/prism.php index 3bf739257..ac2b0ded5 100644 --- a/config/prism.php +++ b/config/prism.php @@ -17,5 +17,9 @@ 'ollama' => [ 'url' => env('OLLAMA_URL', 'http://localhost:11434/v1'), ], + 'mistral' => [ + 'api_key' => env('MISTRAL_API_K...
diff --git a/tests/Fixtures/mistral/generate-text-with-a-prompt-1.json b/tests/Fixtures/mistral/generate-text-with-a-prompt-1.json new file mode 100644 index 000000000..cc401cefc --- /dev/null +++ b/tests/Fixtures/mistral/generate-text-with-a-prompt-1.json @@ -0,0 +1,23 @@ +{ + "id": "8f82539654874b73a8b8dd1330c80221"...
Mistral Support ## Description Add Mistral to the first party supported providers. We should do some investigation but I'm pretty sure all we need to do is add the configuration using the OpenAI driver, similar to Ollama. https://docs.mistral.ai/api/
Can I work on this @sixlive ? @pushpak1300 yeah! Go for it!
Can I work on this @sixlive ? @pushpak1300 yeah! Go for it!
[ "https://github.com/prism-php/prism/commit/bed68539b01edc9aa53e4522ddc6cf55e8e172bd", "https://github.com/prism-php/prism/commit/efca74320fc1698b979635c2c00847c740793767", "https://github.com/prism-php/prism/commit/19d05d6431bf1bfc1efda9a6a8a550eb1469bd7a", "https://github.com/prism-php/prism/commit/915824087...
2024-10-09T08:48:24
0.3
PHP
PHP-CS-Fixer/PHP-CS-Fixer
6,776
PHP-CS-Fixer__PHP-CS-Fixer-6776
[ 6775 ]
fa326d316a6f5a0f9f03a5f79705a0e64a4ea3d7
diff --git a/src/Fixer/Basic/CurlyBracesPositionFixer.php b/src/Fixer/Basic/CurlyBracesPositionFixer.php index bcd58fe9dfb..42b343dbbd7 100644 --- a/src/Fixer/Basic/CurlyBracesPositionFixer.php +++ b/src/Fixer/Basic/CurlyBracesPositionFixer.php @@ -312,7 +312,7 @@ protected function applyFix(\SplFileInfo $file, Tokens ...
diff --git a/tests/Fixer/Basic/CurlyBracesPositionFixerTest.php b/tests/Fixer/Basic/CurlyBracesPositionFixerTest.php index 27408f2233d..0873fd7d272 100644 --- a/tests/Fixer/Basic/CurlyBracesPositionFixerTest.php +++ b/tests/Fixer/Basic/CurlyBracesPositionFixerTest.php @@ -666,6 +666,38 @@ function foo( ...
Error: Missing block "end" ## Bug report ### Description File is not fixed, becouse errors reported during fixing. ### Runtime version PHP CS Fixer 3.14.3 Oliva by Fabien Potencier and Dariusz Ruminski. PHP runtime: 8.1.8 ### Used command php-cs-fixer fix test.php --using-cache no --allow-risky=yes ...
note: if there is no empty space after "{" Fixer will fix it correctly this is fixed: ``` public function example(){//test } ``` fixed code: ``` public function example()//test { } ``` return error: ``` public function example(){ //test } ```
note: if there is no empty space after "{" Fixer will fix it correctly this is fixed: ``` public function example(){//test } ``` fixed code: ``` public function example()//test { } ``` return error: ``` public function example(){ //test } ```
[ "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/29276d632a7c06424e0069647f62fa2120a9542c", "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/115b9fde4dd0b05675296b44fb8d170e2e2001d6", "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/ff7ff48c459ab47086b93ebeabaae8517f8a1733" ]
2023-02-07T17:00:57
0.0
PHP
PHP-CS-Fixer/PHP-CS-Fixer
8,787
PHP-CS-Fixer__PHP-CS-Fixer-8787
[ 8786 ]
3d9c19ed658ad051845170e775fc0a3fb9845bc0
diff --git a/src/Tokenizer/TokensAnalyzer.php b/src/Tokenizer/TokensAnalyzer.php index 7645270542d..af68d84993d 100644 --- a/src/Tokenizer/TokensAnalyzer.php +++ b/src/Tokenizer/TokensAnalyzer.php @@ -868,7 +868,9 @@ private function findClassyElements(int $classIndex, int $index): array ]; ...
diff --git a/tests/Fixer/ClassNotation/VisibilityRequiredFixerTest.php b/tests/Fixer/ClassNotation/VisibilityRequiredFixerTest.php index 95e1c214a78..169d151e43a 100644 --- a/tests/Fixer/ClassNotation/VisibilityRequiredFixerTest.php +++ b/tests/Fixer/ClassNotation/VisibilityRequiredFixerTest.php @@ -682,6 +682,16 @@ pu...
Incorrectly added a public declaration to the formal parameter. ### Problem description public function process(public object $event): void { } v3.78.0 Incorrectly added a public declaration to the formal parameter. Promoted properties can be in constructor only. ### Minimal reproducer CLI command php...
@liangchenwsl please, share your config, without it is hard to understand what is happening.
@liangchenwsl please, share your config, without it is hard to understand what is happening.
[ "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/8d166682b652d1c9ebd76b678ce515fa56683adb", "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/81a0a747d93c2cc5b8e29e0016733a4a0eaed2e3", "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/b44c89f5898704f48e785791991be1038939b41c" ]
2025-07-06T13:21:42
0.0
PHP
PHP-CS-Fixer/PHP-CS-Fixer
7,750
PHP-CS-Fixer__PHP-CS-Fixer-7750
[ 7744 ]
e3afa3251358138654f4299025a393d02e3262bd
diff --git a/src/Fixer/Import/FullyQualifiedStrictTypesFixer.php b/src/Fixer/Import/FullyQualifiedStrictTypesFixer.php index 7135e54d6b7..e751b3baf52 100644 --- a/src/Fixer/Import/FullyQualifiedStrictTypesFixer.php +++ b/src/Fixer/Import/FullyQualifiedStrictTypesFixer.php @@ -262,6 +262,9 @@ protected function applyFix...
diff --git a/tests/Fixer/Import/FullyQualifiedStrictTypesFixerTest.php b/tests/Fixer/Import/FullyQualifiedStrictTypesFixerTest.php index beb079b7004..63bb385bd86 100644 --- a/tests/Fixer/Import/FullyQualifiedStrictTypesFixerTest.php +++ b/tests/Fixer/Import/FullyQualifiedStrictTypesFixerTest.php @@ -876,6 +876,23 @@ cl...
Symbols' casing is changed when there's name collision between imported class and imported function ## Bug report ### Description There's a weird behavior when a variable has the same name as an imported class, and where this class is used via the static operator `::`. ![20240115_22h34m54s_grim](https://github...
The problem is in imports (`Request` class and `request` function), not in variable name. I believe this will be fixed with #7704 / #7705 (depending on the chosen implementation), because imports will be sorted by kind. Now all the imports are collected into one list, which makes the matching inaccurate (last one is us...
The problem is in imports (`Request` class and `request` function), not in variable name. I believe this will be fixed with #7704 / #7705 (depending on the chosen implementation), because imports will be sorted by kind. Now all the imports are collected into one list, which makes the matching inaccurate (last one is us...
[ "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/ccb4bff0968645b57c8ac7d232c4126f2ec6719d", "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/88f43f4e0a6d3a9c2cac97198df801f59bd4b133" ]
2024-01-16T09:33:47
0.0
PHP
PHP-CS-Fixer/PHP-CS-Fixer
7,324
PHP-CS-Fixer__PHP-CS-Fixer-7324
[ 7292 ]
e34645e4bfdc578b6dbdb36d677464efe49b0b55
diff --git a/src/Fixer/ArrayNotation/ArraySyntaxFixer.php b/src/Fixer/ArrayNotation/ArraySyntaxFixer.php index f762d99a39e..a7b0b20f6e3 100644 --- a/src/Fixer/ArrayNotation/ArraySyntaxFixer.php +++ b/src/Fixer/ArrayNotation/ArraySyntaxFixer.php @@ -70,11 +70,11 @@ public function getDefinition(): FixerDefinitionInterfa...
diff --git a/tests/AutoReview/FixerFactoryTest.php b/tests/AutoReview/FixerFactoryTest.php index 865a4ed3c5b..a31c343ae9d 100644 --- a/tests/AutoReview/FixerFactoryTest.php +++ b/tests/AutoReview/FixerFactoryTest.php @@ -341,6 +341,8 @@ private static function getFixersPriorityGraph(): array ], ...
Two passes needed for array_syntax+ single_space_around_construct ## Bug report ### Description Two passes may be required if we use both `ArraySyntaxFixer` and `SingleSpaceAroundConstructFixer`. ### Runtime version ``` PHP CS Fixer 3.26.1 Crank Cake by Fabien Potencier and Dariusz Ruminski. PHP runtime: ...
[ "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/7cfd5b21184ffca1717d0381b8abb7b09d0f105e" ]
2023-09-26T12:19:05
0.0
PHP
PHP-CS-Fixer/PHP-CS-Fixer
8,510
PHP-CS-Fixer__PHP-CS-Fixer-8510
[ 8509 ]
c3d07b5a306d7ade125cae116cb578d915c2fd67
diff --git a/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php b/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php index c10c3ef7331..537e2763724 100644 --- a/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php +++ b/src/Fixer/PhpUnit/PhpUnitAttributesFixer.php @@ -366,12 +366,20 @@ private static function fixDataProvider(Tokens $token...
diff --git a/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php b/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php index c91ff7176ac..4ba6b0cd372 100644 --- a/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php +++ b/tests/Fixer/PhpUnit/PhpUnitAttributesFixerTest.php @@ -699,6 +699,31 @@ public static function provide...
PhpUnitAttributesFixer - remove parentheses as they appear ### Problem description Rule: `\PhpCsFixer\Fixer\PhpUnit\PhpUnitAttributesFixer` Sometimes, people use invalid syntax with brackets when defining the dataProvider annotation. While PHPUnit handles this annotation without issues, using the same syntax with at...
[ "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/ff39229b8003db0eec3753ff454270a8d8108045", "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/b4adff19ccf908f2f40699b188750010e097245d", "https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/commit/f8c0588ee612e80bc96d9be256f7058ca82ebfc4", "https://github.com/PH...
2025-03-17T13:46:38
0.0
PHP
shopware/shopware
8,878
shopware__shopware-8878
[ 8770 ]
e1a3eac69dd46ea24288e54177363c8881906432
diff --git a/.bc-exclude.php b/.bc-exclude.php index 56790a8319c..b7d4f15d2a6 100644 --- a/.bc-exclude.php +++ b/.bc-exclude.php @@ -43,5 +43,7 @@ // No break as the `{get,set}SeoLink()` changes have not been released 'REMOVED: Property Shopware\\\\Core\\\\Content\\\\Category\\\\SalesChannel\\\\SalesC...
diff --git a/tests/unit/Core/Framework/Adapter/Filesystem/Adapter/AsyncAwsS3WriteBatchAdapterTest.php b/tests/unit/Core/Framework/Adapter/Filesystem/Adapter/AsyncAwsS3WriteBatchAdapterTest.php index 5984349b91c..76dfbb56e9b 100644 --- a/tests/unit/Core/Framework/Adapter/Filesystem/Adapter/AsyncAwsS3WriteBatchAdapterTes...
Copy batch ignores visibility configuration for S3 ### Shopware Version 6.6.10.3 ### Affected area / extension Platform(Default) ### Actual behaviour With the following code in `src/Core/Framework/Adapter/Filesystem/Plugin/CopyBatch.php`: ```php $adapter = self::getAdapter($filesystem); if ($adapter instanceof Wri...
Reopening issue because the related pull request needs to be backported. Reopening issue because the related pull request needs to be backported.
[ "https://github.com/shopware/shopware/commit/23cf94df8fc262392a7fb4d80ab4867e429cb591" ]
2025-04-28T11:52:35
0.0
PHP
shopware/shopware
12,115
shopware__shopware-12115
[ 11953 ]
9ceeba38d42edf52ef7d827a380892579df576d2
diff --git a/src/Core/System/SalesChannel/Context/SalesChannelContextFactory.php b/src/Core/System/SalesChannel/Context/SalesChannelContextFactory.php index f63e3f5efd4..8ae885800a1 100644 --- a/src/Core/System/SalesChannel/Context/SalesChannelContextFactory.php +++ b/src/Core/System/SalesChannel/Context/SalesChannelCo...
diff --git a/tests/unit/Core/System/SalesChannel/Context/SalesChannelContextFactoryTest.php b/tests/unit/Core/System/SalesChannel/Context/SalesChannelContextFactoryTest.php index b277a39d01d..f24c72d7540 100644 --- a/tests/unit/Core/System/SalesChannel/Context/SalesChannelContextFactoryTest.php +++ b/tests/unit/Core/Sy...
Inactive customer can buy ### Shopware Version 6.6.10.6 ### Affected area / extension Platform(Default) ### Actual behaviour - a customer is logged in in frontend - the customer will be disabled in admin - the customer can use his account furthermore ### Expected behaviour the customer is being logged out, at le...
FYI: During the assembly of the `SalesChannelContext`, the Criteria for getting the customer missing a active check - we should add that. don't add it to the criteria, do it afterwards on php side because of mysql table index
FYI: During the assembly of the `SalesChannelContext`, the Criteria for getting the customer missing a active check - we should add that. don't add it to the criteria, do it afterwards on php side because of mysql table index Reopening issue because the related pull request needs to be backported. thank you @mstegmeyer...
[ "https://github.com/shopware/shopware/commit/3aa531495bcfd1e0ccd88968879f901955fd936c", "https://github.com/shopware/shopware/commit/7cf5c7493714e64066d24488b8c021361e4313a4", "https://github.com/shopware/shopware/commit/c414ba8be518db06c1ca9214a26235060fa4b3fe" ]
2025-08-27T06:25:45
0.0
PHP
shopware/shopware
12,101
shopware__shopware-12101
[ 12074 ]
262ef0d544c0b4f3ec8ae9a8921202a5316d4018
diff --git a/changelog/_unreleased/2025-08-26-apply-search-score-as-fallback-sort-criteria-on-searching.md b/changelog/_unreleased/2025-08-26-apply-search-score-as-fallback-sort-criteria-on-searching.md new file mode 100644 index 00000000000..fa826185123 --- /dev/null +++ b/changelog/_unreleased/2025-08-26-apply-search...
diff --git a/tests/unit/Core/Content/Product/SalesChannel/Listing/Processor/SortingListingProcessorTest.php b/tests/unit/Core/Content/Product/SalesChannel/Listing/Processor/SortingListingProcessorTest.php index 16f9cf30c1b..7777ec4c460 100644 --- a/tests/unit/Core/Content/Product/SalesChannel/Listing/Processor/SortingL...
Apply search score as fallback sort criteria on searching ### Technical TODO Currently when searching, the `_score` (search rank) is the default sort criteria applies. They can change this criteria to something else like Topseller or price. However, if products have equal values for these sort conditions, the ID is t...
[ "https://github.com/shopware/shopware/commit/91127983deb7ef3a717ee49c88335e3ee176f8c0", "https://github.com/shopware/shopware/commit/48469e3444a1423d62cf0733f16a65e911a64e70", "https://github.com/shopware/shopware/commit/3df5ab654534749217c6d6c93c28ddcc8489fd15" ]
2025-08-26T08:00:42
0.0
PHP
shopware/shopware
12,318
shopware__shopware-12318
[ 11968 ]
2750b8cfb7a66c0cceb9689502235659865749b5
diff --git a/src/Core/Checkout/Document/Zugferd/ZugferdDocument.php b/src/Core/Checkout/Document/Zugferd/ZugferdDocument.php index d8e6f8e8084..a553812591c 100644 --- a/src/Core/Checkout/Document/Zugferd/ZugferdDocument.php +++ b/src/Core/Checkout/Document/Zugferd/ZugferdDocument.php @@ -176,9 +176,14 @@ public functio...
diff --git a/tests/unit/Core/Checkout/Document/Zugferd/ZugferdBuilderTest.php b/tests/unit/Core/Checkout/Document/Zugferd/ZugferdBuilderTest.php index ff0d3186e52..f1299a723a5 100644 --- a/tests/unit/Core/Checkout/Document/Zugferd/ZugferdBuilderTest.php +++ b/tests/unit/Core/Checkout/Document/Zugferd/ZugferdBuilderTest...
ZUGFeRD LineItem netPrice uses wrong value for basisQuantity ### Shopware Version 6.7.* ### Affected area / extension Platform(Default) ### Actual behaviour In this code, `$lineItem->getQuantity()` is used as the second argument. This argument is used to set the [BaseQuantity](https://docs.peppol.eu/poacc/billing/...
Todo: we have to evaluate this, e.g. is this specific to Peppol or did we set the wrong value accoring to our implemented zugferd format. Also we likely don't want to hardcode this to `1` but instead use a shopware product value for it (maybe this is already configurable as "this price applies to x units")
Todo: we have to evaluate this, e.g. is this specific to Peppol or did we set the wrong value accoring to our implemented zugferd format. Also we likely don't want to hardcode this to `1` but instead use a shopware product value for it (maybe this is already configurable as "this price applies to x units") From Zugferd...
[ "https://github.com/shopware/shopware/commit/2223e5432fe55600699d65f25e23197a6e06d278", "https://github.com/shopware/shopware/commit/a5c16e7e101e116bed2f04f187f14a09a23fa44c", "https://github.com/shopware/shopware/commit/b61a4dfc2fd980a451b216a990fe0211dd59d327", "https://github.com/shopware/shopware/commit/5...
2025-09-04T09:51:42
0.0
PHP
shopware/shopware
11,627
shopware__shopware-11627
[ 9976 ]
f4303eeffdce43feaae305d367c1b72560046d0f
diff --git a/src/Core/Content/Flow/Dispatching/FlowExecutor.php b/src/Core/Content/Flow/Dispatching/FlowExecutor.php index d1949ff1d48..a5594508c1f 100644 --- a/src/Core/Content/Flow/Dispatching/FlowExecutor.php +++ b/src/Core/Content/Flow/Dispatching/FlowExecutor.php @@ -124,8 +124,7 @@ public function executeSequence...
diff --git a/tests/integration/Core/Content/Flow/Dispatching/Action/GrantDownloadAccessActionTest.php b/tests/integration/Core/Content/Flow/Dispatching/Action/GrantDownloadAccessActionTest.php index 39d75136581..e1574de37bf 100644 --- a/tests/integration/Core/Content/Flow/Dispatching/Action/GrantDownloadAccessActionTes...
Rule Builder current child action sequence is not updated ### Shopware Version 6.7.0.0-rc.4 ### Affected area / extension Platform(Default) ### Actual behaviour When talking about Flow Builder. There are two action avenues. One with a rule, one without. In our test we add 2 actions that run one after the other (...
Hi @augsteyer, thanks for the detailed issue report. Could you please add a bit more context on the root issue, e.g. what problem you are trying to solve (either as an administration user or developer using our APIs). That would help us prioritize this issue accordingly and better understand the context of this issue οΏ½...
Hi @augsteyer, thanks for the detailed issue report. Could you please add a bit more context on the root issue, e.g. what problem you are trying to solve (either as an administration user or developer using our APIs). That would help us prioritize this issue accordingly and better understand the context of this issue οΏ½...
[ "https://github.com/shopware/shopware/commit/121ada14f8198d0b0df9fb6bc99be013ae734462", "https://github.com/shopware/shopware/commit/41ee61b76aa2cfc97de7cec2fb34eee6c06269ac", "https://github.com/shopware/shopware/commit/9683dc9272a6612d6f09cf0ba3d5fa3871d692ac", "https://github.com/shopware/shopware/commit/e...
2025-07-30T14:53:26
0.0
PHP
10up/ElasticPress
3,500
10up__ElasticPress-3500
[ 2000 ]
2b32a9212d176b96730d0dd0dda0b475de8ee23e
diff --git a/includes/classes/Command.php b/includes/classes/Command.php index 7b2f20e2ed..e96872a18d 100644 --- a/includes/classes/Command.php +++ b/includes/classes/Command.php @@ -689,6 +689,9 @@ public function delete_transient_on_int( $signal_no ) { * [--show-nobulk-errors] * : Display the error message retu...
diff --git a/tests/php/TestCommands.php b/tests/php/TestCommands.php index 87c85945b6..eaebf616c6 100644 --- a/tests/php/TestCommands.php +++ b/tests/php/TestCommands.php @@ -929,6 +929,55 @@ public function testRequest() { $this->assertStringContainsString( 'Response:', $output ); } + /** + * Test sync command...
Create a new --stop-on-errors parameter for the WP-CLI index command **Is your enhancement related to a problem? Please describe.** Currently, WP-CLI index command will only stop if the response to the request is an error. Otherwise, it will record all errors (like "too many fields" errors) and present them at the e...
[ "https://github.com/10up/ElasticPress/commit/ec85541b681752a18f8a28d6e40038dd2a215adb", "https://github.com/10up/ElasticPress/commit/c16488a546ea59d7fcbcac9c3fda755c89608f36", "https://github.com/10up/ElasticPress/commit/ec8e02f31957f4e6744eff9fb7bcbaca2570d8d8", "https://github.com/10up/ElasticPress/commit/5...
2023-06-19T13:25:04
4.7
PHP
10up/ElasticPress
4,185
10up__ElasticPress-4185
[ 3352 ]
b57dd4f98000e5ba9227348fe8cffdc9c6aaf4d4
diff --git a/includes/classes/Elasticsearch.php b/includes/classes/Elasticsearch.php index 86be0fa5e3..6eaacb0ed3 100644 --- a/includes/classes/Elasticsearch.php +++ b/includes/classes/Elasticsearch.php @@ -1300,7 +1300,7 @@ public function remote_request( $path, $args = [], $query_args = [], $type = '' * @param {...
diff --git a/tests/php/features/TestAutosuggest.php b/tests/php/features/TestAutosuggest.php index 66775d0278..d5f5b0793b 100644 --- a/tests/php/features/TestAutosuggest.php +++ b/tests/php/features/TestAutosuggest.php @@ -517,4 +517,16 @@ function ( $path, $index, $type, $query ) { $this->assertTrue( $query->elas...
Turn certain filters into WP_Query arguments ### Is your enhancement related to a problem? Please describe. In certain parts of the plugin, custom filters are used to apply changes or functionality to `WP_Query` queries. The downside of this approach is that it's hard to target queries specifically as any query that o...
[ "https://github.com/10up/ElasticPress/commit/5fb11423bfaddba03538802745b79f20c69662b0", "https://github.com/10up/ElasticPress/commit/e15973342a9d7cf2ad9b2440993b04764f2f71c8", "https://github.com/10up/ElasticPress/commit/a8962f9f2915f39db8ba7b93f55f3e9932620a00", "https://github.com/10up/ElasticPress/commit/f...
2025-08-13T10:33:35
5.3
PHP
10up/ElasticPress
3,243
10up__ElasticPress-3243
[ 3225 ]
925c8e58751485d0b95451b7bf50063cd7ff3431
diff --git a/includes/classes/Indexable/Comment/QueryIntegration.php b/includes/classes/Indexable/Comment/QueryIntegration.php index 7520dfa579..9cf1bc781f 100644 --- a/includes/classes/Indexable/Comment/QueryIntegration.php +++ b/includes/classes/Indexable/Comment/QueryIntegration.php @@ -123,15 +123,17 @@ public func...
diff --git a/tests/php/indexables/TestCommentMultisite.php b/tests/php/indexables/TestCommentMultisite.php index 37893f8dfc..fbbafc7745 100644 --- a/tests/php/indexables/TestCommentMultisite.php +++ b/tests/php/indexables/TestCommentMultisite.php @@ -265,4 +265,86 @@ public function testCommentQueryWithDeprecatedSitesP...
BUG: Search in multisite for 'sites' => 'current' ### Describe the bug After upgrading to Elasticpress 4.4.0 we are no longer able to search within the 'current' site, all requests seams to be using the Main site URL ### Steps to Reproduce If the search quests is using: ``` new WP_Query( array( 's' => 's...
Hi @anders-naslund , By what you said, it seems this would be a regression? If so, can you let us know which version was working correctly for you? 4.3.1 was working fine, looks like it might have to do with changes in [includes/classes/Indexable/Comment/QueryIntegration.php] Changed to use 'sites__in' accord...
Hi @anders-naslund , By what you said, it seems this would be a regression? If so, can you let us know which version was working correctly for you? 4.3.1 was working fine, looks like it might have to do with changes in [includes/classes/Indexable/Comment/QueryIntegration.php] Changed to use 'sites__in' accord...
[ "https://github.com/10up/ElasticPress/commit/1861bc2b25efbc893dd823b9ec4c25f3234f32d3", "https://github.com/10up/ElasticPress/commit/55748f97fa2fa9ef9a55a575b82b97506957eb53", "https://github.com/10up/ElasticPress/commit/14cfbd2bd6451255c5be27fbc583aff99c2dd5e4" ]
2023-01-04T13:06:24
4.4
PHP
10up/ElasticPress
3,259
10up__ElasticPress-3259
[ 3219 ]
bba5b9700391dd359f336104c28d23138b8d3ee7
diff --git a/includes/classes/Feature/WooCommerce/WooCommerce.php b/includes/classes/Feature/WooCommerce/WooCommerce.php index 2322a4381f..5f45bbe276 100644 --- a/includes/classes/Feature/WooCommerce/WooCommerce.php +++ b/includes/classes/Feature/WooCommerce/WooCommerce.php @@ -300,12 +300,15 @@ public function transla...
diff --git a/tests/php/bootstrap.php b/tests/php/bootstrap.php index f0a6b886d2..e7d9abd3a2 100644 --- a/tests/php/bootstrap.php +++ b/tests/php/bootstrap.php @@ -124,6 +124,7 @@ function skip_translations_api() { require_once __DIR__ . '/includes/classes/factory/UserFactory.php'; require_once __DIR__ . '/includes/cl...
Increase Unit tests coverage for Feature -> WooCommerce ### Is your enhancement related to a problem? Please describe. Currently only 20% of functionality of https://github.com/10up/ElasticPress/tree/develop/includes/classes/Feature/WooCommerce is cover in the unit tests. We need to add the more unit tests. ###...
[ "https://github.com/10up/ElasticPress/commit/656e0fe0161c6533b6b7a2ef43d9ca65dae8d5dc", "https://github.com/10up/ElasticPress/commit/5a6edc46447815a95215602abed03ec2395d9256", "https://github.com/10up/ElasticPress/commit/d3d996fb4dfdd48c1b80a8977dcd989eb24626a7", "https://github.com/10up/ElasticPress/commit/0...
2023-01-13T13:25:51
4.5
PHP
10up/ElasticPress
3,546
10up__ElasticPress-3546
[ 3535 ]
8ea0136aa2e40a086dfbe8be37f8e6740e7c6588
diff --git a/includes/classes/Feature/WooCommerce/Products.php b/includes/classes/Feature/WooCommerce/Products.php index c415ed5fd6..08ffda2396 100644 --- a/includes/classes/Feature/WooCommerce/Products.php +++ b/includes/classes/Feature/WooCommerce/Products.php @@ -617,12 +617,24 @@ public function translate_args( $qu...
diff --git a/tests/php/features/WooCommerce/TestWooCommerceProduct.php b/tests/php/features/WooCommerce/TestWooCommerceProduct.php index bb1fda8696..826dd8eeb7 100644 --- a/tests/php/features/WooCommerce/TestWooCommerceProduct.php +++ b/tests/php/features/WooCommerce/TestWooCommerceProduct.php @@ -63,20 +63,15 @@ publi...
BUG: No mapping found for [popularity] in order to sort on ### Describe the bug Under certain circumstances for WooCommerce stores, ElasticPress will integrate a WP_Query that is not the main query, causing an error `No mapping found for [popularity] in order to sort on` ### Steps to Reproduce Place the following sn...
This is fixed in #3502 (see 6834542) In the meantime, users facing this problem can drop the following snippet in a custom plugin or their theme's functions.php file: ```php /** * Translate WooCommerce `price` and `popularity` fields in orderby clauses. * * This should be removed if using versions of Elast...
This is fixed in #3502 (see 6834542) In the meantime, users facing this problem can drop the following snippet in a custom plugin or their theme's functions.php file: ```php /** * Translate WooCommerce `price` and `popularity` fields in orderby clauses. * * This should be removed if using versions of Elast...
[ "https://github.com/10up/ElasticPress/commit/5b6c073eaea353e1d5cf917aff2bc730d7b7991b", "https://github.com/10up/ElasticPress/commit/553aee955e54dee328592b930e270a3c29e3f9fc", "https://github.com/10up/ElasticPress/commit/dbe3ec5ab7340ea0f585fcf2d30db0ec42923405", "https://github.com/10up/ElasticPress/commit/c...
2023-07-19T17:54:51
4.6
PHP
zircote/swagger-php
1,438
zircote__swagger-php-1438
[ 1437 ]
bf5ab27a574a3efdccb01c0955f7b72e94310290
diff --git a/src/Annotations/PathItem.php b/src/Annotations/PathItem.php index aa5f6da85..cfeeeddab 100644 --- a/src/Annotations/PathItem.php +++ b/src/Annotations/PathItem.php @@ -28,18 +28,25 @@ class PathItem extends AbstractAnnotation public $ref = Generator::UNDEFINED; /** - * Key for the Path Obje...
diff --git a/tests/Annotations/AbstractAnnotationTest.php b/tests/Annotations/AbstractAnnotationTest.php index dd12c4e11..935ed0ff5 100644 --- a/tests/Annotations/AbstractAnnotationTest.php +++ b/tests/Annotations/AbstractAnnotationTest.php @@ -103,8 +103,6 @@ public function testTypeValidation(): void $this->...
Include description as a public property within the PathItem Annotation class According to [OAS3](https://swagger.io/docs/specification/paths-and-operations/) > Paths may have an optional short summary **and a longer description** for documentation purposes. This information is supposed to be relevant to all operati...
[ "https://github.com/zircote/swagger-php/commit/b64dcaa09c355d30775a03030682d3c05da1797b" ]
2023-04-05T20:57:52
3.3
PHP
zircote/swagger-php
1,843
zircote__swagger-php-1843
[ 1839 ]
1449b0a43d980bcbdb3ca0689a6cc77872555189
diff --git a/src/Type/LegacyTypeResolver.php b/src/Type/LegacyTypeResolver.php index 4897e2882..33fd4a8fd 100644 --- a/src/Type/LegacyTypeResolver.php +++ b/src/Type/LegacyTypeResolver.php @@ -188,7 +188,7 @@ protected function getDocblockTypeDetails(\Reflector $reflector, ?Context $conte $pattern = "/$tagName...
diff --git a/tests/Fixtures/PHP/DocblockAndTypehintTypes.php b/tests/Fixtures/PHP/DocblockAndTypehintTypes.php index 97f82eabd..027ce086d 100644 --- a/tests/Fixtures/PHP/DocblockAndTypehintTypes.php +++ b/tests/Fixtures/PHP/DocblockAndTypehintTypes.php @@ -168,4 +168,15 @@ public function paramMethod( ): void ...
Mix types when name is similar ```php #[\OpenApi\Attributes\Schema()] class Test { /** * @param ?string[] $blah_values */ public function __construct( #[\OpenApi\Attributes\Property(example: 'My value')] public ?string $blah, #[\OpenApi\Attributes\Property(nullable: true, items...
[ "https://github.com/zircote/swagger-php/commit/71a219dab3634254eb5b8d44030c43021d01355c" ]
2025-11-14T09:14:03
2.1
PHP
zircote/swagger-php
1,422
zircote__swagger-php-1422
[ 1419 ]
441969e1013eaf41ce9cfcdb989b48de8610443a
diff --git a/src/Analysers/AttributeAnnotationFactory.php b/src/Analysers/AttributeAnnotationFactory.php index 31b7f5e53..0bbeed5e7 100644 --- a/src/Analysers/AttributeAnnotationFactory.php +++ b/src/Analysers/AttributeAnnotationFactory.php @@ -53,6 +53,7 @@ public function build(\Reflector $reflector, Context $context...
diff --git a/tests/Fixtures/Scratch/PromotedProperty.php b/tests/Fixtures/Scratch/PromotedProperty.php new file mode 100644 index 000000000..4453f8732 --- /dev/null +++ b/tests/Fixtures/Scratch/PromotedProperty.php @@ -0,0 +1,55 @@ +<?php declare(strict_types=1); + +/** + * @license Apache 2.0 + */ + +namespace OpenApi...
Wrong docs generation for php8 promoted properties. Using php 8 promoted properties, I expect the doccomment to be parsed the same as for the basic class properties. But it actually looks like they are overridden by method arguments. As far as I'm concerned, the only reason I want to use elevated properties is the lint...
Yep, that could be better. Also the `"nullable": false` is kinda redundant I suppose...
Yep, that could be better. Also the `"nullable": false` is kinda redundant I suppose... And also one more bug founded here. While there is no fix yet, I tried to move all the comments to property description attribute parameter, and found that `property` property ignored. Class: ```php #[Schema()] class NameVa...
[ "https://github.com/zircote/swagger-php/commit/4e27a63d4151ffb93bfc4fd25924d719834e567c" ]
2023-03-06T03:27:53
3.3
PHP
zircote/swagger-php
1,634
zircote__swagger-php-1634
[ 1633 ]
c469b10f57fedf9d626e6de525fef264576413d8
diff --git a/src/Processors/AugmentTags.php b/src/Processors/AugmentTags.php index 21eeb2c38..171b6387c 100644 --- a/src/Processors/AugmentTags.php +++ b/src/Processors/AugmentTags.php @@ -34,6 +34,10 @@ public function __invoke(Analysis $analysis) $declaredTags[$tag->name] = $tag; } ...
diff --git a/tests/Fixtures/SurplusTag.php b/tests/Fixtures/SurplusTag.php index 0ac32cc63..ad5d12036 100644 --- a/tests/Fixtures/SurplusTag.php +++ b/tests/Fixtures/SurplusTag.php @@ -14,11 +14,18 @@ description: 'test', version: '2.0.0' ), + tags: [ + // definding tag 'other' globally...
Tags within api definition are not unique Hi, when having the same tag for multiple methods / routes the resulting api definition has the same tag multiple times but the specification says that tag names must be unique. Within the specification for the `tags` within the OpenAPI object, the [OpenAPI specification]...
I think this is a mixture of two different things and perhaps some confustion about what the `Tag` annotation does. The `Tag` annotation can be top level or nested insode the `OpenApi` annotation and is used to define tags which then can be used/referenced by HTTP operations. This is similar to components - surely ...
I think this is a mixture of two different things and perhaps some confustion about what the `Tag` annotation does. The `Tag` annotation can be top level or nested insode the `OpenApi` annotation and is used to define tags which then can be used/referenced by HTTP operations. This is similar to components - surely ...
[ "https://github.com/zircote/swagger-php/commit/98965e399cf99f125a4804259178e9970863df2a" ]
2024-07-26T02:56:21
2.1
PHP
zircote/swagger-php
1,375
zircote__swagger-php-1375
[ 1374 ]
e505bce612a86fe90f8fd50917e0848afc5d2ba8
diff --git a/composer.json b/composer.json index a68b5f4e6..d5e09024d 100644 --- a/composer.json +++ b/composer.json @@ -46,7 +46,7 @@ "require": { "php": ">=7.2", "ext-json": "*", - "doctrine/annotations": "^1.7", + "doctrine/annotations": "^1.7 || ^2.0", "psr/log": "^1.1 ...
diff --git a/tests/Analysers/DocBlockParserTest.php b/tests/Analysers/DocBlockParserTest.php index ba5c94926..1413446d0 100644 --- a/tests/Analysers/DocBlockParserTest.php +++ b/tests/Analysers/DocBlockParserTest.php @@ -6,6 +6,7 @@ namespace OpenApi\Tests\Analysers; +use Doctrine\Common\Annotations\AnnotationRegi...
Add support for `doctrine/annotations` ^2.0 The `doctrine/annotations` package got a [2.0 release](https://github.com/doctrine/annotations/releases/tag/2.0.0) just before the new year. Unfortunately, the release has a bit of impact on this package as the `OpenApi\Generator` class [relies on the deprecated `Doctrine\Co...
Correct on both. I think I'll keep the code in there for now as with PhpCSFixer not allowing ^2.0 yet its mostly decoration. I'll mark the code block as deprecated so we can remove it at a later time.
Correct on both. I think I'll keep the code in there for now as with PhpCSFixer not allowing ^2.0 yet its mostly decoration. I'll mark the code block as deprecated so we can remove it at a later time.
[ "https://github.com/zircote/swagger-php/commit/9211cbc34af36f02435458ff1bd1ae4e6dfd5e8d" ]
2023-01-03T19:50:12
3.3
PHP
PrestaShop/PrestaShop
38,746
PrestaShop__PrestaShop-38746
[ 38454 ]
e050d6ff11d510827b2a94c57963c4e810c61404
diff --git a/admin-dev/themes/new-theme/js/pages/discount/discount-map.ts b/admin-dev/themes/new-theme/js/pages/discount/discount-map.ts index 0d8f933bd859e..09fe3f1c59410 100644 --- a/admin-dev/themes/new-theme/js/pages/discount/discount-map.ts +++ b/admin-dev/themes/new-theme/js/pages/discount/discount-map.ts @@ -32,...
diff --git a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php b/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php index 22396f8d6697c..b58423a8303cb 100644 --- a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureConte...
Select a free gift product # Context A new field in the creation form allows the selection of the product to offer If the product to be offered has combinations (e.g., size, color), the merchant can select ony one ombination to offer Error messages must be handled in this issue: https://github.com/PrestaShop/PrestaShop...
[ "https://github.com/PrestaShop/PrestaShop/commit/c6ba7ec75e71413529cde957741b58da3777f42a" ]
2025-05-20T13:08:49
1.6
PHP
PrestaShop/PrestaShop
40,104
PrestaShop__PrestaShop-40104
[ 38683 ]
8cc947d42228136c18ac1a9efcf335f9220e2188
diff --git a/src/Adapter/Discount/CommandHandler/BulkDeleteDiscountsHandler.php b/src/Adapter/Discount/CommandHandler/BulkDeleteDiscountsHandler.php new file mode 100644 index 0000000000000..bf878cbc75e28 --- /dev/null +++ b/src/Adapter/Discount/CommandHandler/BulkDeleteDiscountsHandler.php @@ -0,0 +1,88 @@ +<?php +/**...
diff --git a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php b/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php index 3492a76cc992c..14a405253a9d4 100644 --- a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureConte...
Delete discounts in bulk # Context Back office user can delete in bulk from the discount list. A deleted discount must be remove from the list, the db and is no longer applied (if it was the case). # Mockup ![Image](https://github.com/user-attachments/assets/818387ff-28c5-4493-9d2c-f7ad346bb693) # Tests - delete via...
[ "https://github.com/PrestaShop/PrestaShop/commit/267593c0df286b431206c2e72d7e13629ba5ee3b", "https://github.com/PrestaShop/PrestaShop/commit/fbe7fe26338d9abf4a2ce15d346185b0f59b5a26", "https://github.com/PrestaShop/PrestaShop/commit/795ef269a09ff13b18d1260b2bf4cef74c1fe246", "https://github.com/PrestaShop/Pre...
2025-11-25T17:17:07
1.6
PHP
PrestaShop/PrestaShop
32,861
PrestaShop__PrestaShop-32861
[ 32734 ]
6c07ca3129f7dba5d7b21fcb37abd428c9cd129e
diff --git a/src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/EmployeeController.php b/src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/EmployeeController.php index a3cf08f0b96ef..59271cb72e340 100644 --- a/src/PrestaShopBundle/Controller/Admin/Configure/AdvancedParameters/EmployeeCo...
diff --git a/tests/Integration/PrestaShopBundle/Controller/Admin/Sell/Order/OrderControllerTest.php b/tests/Integration/PrestaShopBundle/Controller/Admin/Sell/Order/OrderControllerTest.php index 10035a66acfa3..631f9d06d06e3 100644 --- a/tests/Integration/PrestaShopBundle/Controller/Admin/Sell/Order/OrderControllerTest....
Invalid token when changing email address in profile page ### Prerequisites - [X] I understand and accept the project's [code of conduct](https://github.com/PrestaShop/PrestaShop/blob/develop/CODE_OF_CONDUCT.md). - [X] I have already [searched in existing issues](https://github.com/PrestaShop/PrestaShop/issues?q=is%3A...
The problem is caused when you change the email address of the account you're connected with. At some point in a redirection, the token of the BO access is regenerated. But it is regenerated using the old email address. The new address should be already saved into db but when the regeneration process fetches the user i...
The problem is caused when you change the email address of the account you're connected with. At some point in a redirection, the token of the BO access is regenerated. But it is regenerated using the old email address. The new address should be already saved into db but when the regeneration process fetches the user i...
[ "https://github.com/PrestaShop/PrestaShop/commit/e5b6ff16d906f2855e138bc6ce9b0537b970d96b" ]
2023-06-07T16:48:49
1.6
PHP
PrestaShop/PrestaShop
40,103
PrestaShop__PrestaShop-40103
[ 38681 ]
445914e21fd74a896b2922faaeec6871ddd0e1aa
diff --git a/src/Adapter/Discount/CommandHandler/BulkUpdateDiscountsStatusHandler.php b/src/Adapter/Discount/CommandHandler/BulkUpdateDiscountsStatusHandler.php new file mode 100644 index 0000000000000..91d34a3f3385c --- /dev/null +++ b/src/Adapter/Discount/CommandHandler/BulkUpdateDiscountsStatusHandler.php @@ -0,0 +1...
diff --git a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php b/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php index 0d9d3e8d0d1e7..bb2f29a4802ad 100644 --- a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureConte...
Enable/disable discounts in bulk # Context Back office user can disable in bulk from the discount list. A disabled discount is no longer applied (if it was the case). # Mockup ![Image](https://github.com/user-attachments/assets/dc37cf8f-fc41-4fcd-b911-5266317a2852) # Tests - disable via bulk action => selection must...
[ "https://github.com/PrestaShop/PrestaShop/commit/a2229a97b7e322da9e34ad03fe85a58b1592d589", "https://github.com/PrestaShop/PrestaShop/commit/335d4c8b584ee39cdffbc4f0c192c26244d78fa4", "https://github.com/PrestaShop/PrestaShop/commit/5b17b778d4ea1af70ebda63cb225b8cb10acccea", "https://github.com/PrestaShop/Pre...
2025-11-25T16:45:48
1.6
PHP
PrestaShop/PrestaShop
38,201
PrestaShop__PrestaShop-38201
[ 37793 ]
927a3df09630e5b5efd1a9707e19e9da2293bfcb
diff --git a/src/Adapter/CartRule/CartRuleBuilder.php b/src/Adapter/CartRule/CartRuleBuilder.php index 0a79fa4288b2c..215a1197f85c3 100644 --- a/src/Adapter/CartRule/CartRuleBuilder.php +++ b/src/Adapter/CartRule/CartRuleBuilder.php @@ -31,6 +31,7 @@ use PrestaShop\PrestaShop\Core\Domain\Discount\Command\AddCartLevelD...
diff --git a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php b/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureContext.php index f85293ea1d7f5..103814caef319 100644 --- a/tests/Integration/Behaviour/Features/Context/Domain/Discount/DiscountFeatureConte...
Create a product-level discount # Context A product-level discount is applied only to the selected products, regardless of the order's content (cart + shipping fees). # Default values Information: - Name automatically generated (= code) - No description Dates: - Start date = Creation date - Never expires (no expirat...
[ "https://github.com/PrestaShop/PrestaShop/commit/fcd4d7b334fdf9e80ed2ab0e13d3a68606c736cf" ]
2025-03-05T17:31:24
1.6
PHP
wp-graphql/wp-graphql
3,271
wp-graphql__wp-graphql-3271
[ 3269 ]
1e6e008c219633141cce9dac43614209212fca97
diff --git a/src/Data/PostObjectMutation.php b/src/Data/PostObjectMutation.php index cbb867196..e077db2dc 100644 --- a/src/Data/PostObjectMutation.php +++ b/src/Data/PostObjectMutation.php @@ -355,6 +355,13 @@ protected static function set_object_terms( int $post_id, array $input, WP_Post_ return; } + ...
diff --git a/tests/wpunit/PostObjectMutationsTest.php b/tests/wpunit/PostObjectMutationsTest.php index 3b6484e1e..9a7720f2e 100644 --- a/tests/wpunit/PostObjectMutationsTest.php +++ b/tests/wpunit/PostObjectMutationsTest.php @@ -1298,4 +1298,57 @@ public function testDeletePostWithLockFails() { $actual = graphql( co...
Uncategorized is added by default when adding a post ### Description ![image](https://github.com/user-attachments/assets/031cee66-fbe3-46c6-8f4a-06c87feb1d60) ![image](https://github.com/user-attachments/assets/38d39943-7d02-42bb-97fd-be53d0ffac63) When adding a post, it adds the 'Uncategorized' category by de...
@Pizza1 hello, Thanks for reporting this and providing clear steps to reproduce! I have confirmed this behavior and am looking into a resolution.
@Pizza1 hello, Thanks for reporting this and providing clear steps to reproduce! I have confirmed this behavior and am looking into a resolution.
[ "https://github.com/wp-graphql/wp-graphql/commit/75f36db4527dec39ad72e12a52991e68b7d4a50c", "https://github.com/wp-graphql/wp-graphql/commit/5b841406a16ac8a1b3ee3314fd7c916780a67a36", "https://github.com/wp-graphql/wp-graphql/commit/c1fbe2f63ef39046e44dbed4c5851eaee1f312f8", "https://github.com/wp-graphql/wp-...
2025-01-15T23:33:05
1.27
PHP
wp-graphql/wp-graphql
2,945
wp-graphql__wp-graphql-2945
[ 1843 ]
2937585d4f73756535302b0ebe78592e51e23c94
diff --git a/access-functions.php b/access-functions.php index c4e96eb4f..2cf757976 100644 --- a/access-functions.php +++ b/access-functions.php @@ -402,15 +402,34 @@ static function ( TypeRegistry $type_registry ) use ( $connection_name, $fields * @since 1.3.4 */ function rename_graphql_field( string $type_name, ...
diff --git a/tests/wpunit/AccessFunctionsTest.php b/tests/wpunit/AccessFunctionsTest.php index a443157f3..15a374062 100644 --- a/tests/wpunit/AccessFunctionsTest.php +++ b/tests/wpunit/AccessFunctionsTest.php @@ -636,6 +636,23 @@ public function testRenameGraphQLFieldName() { ); } + public function testRenameGra...
rename_graphql_field doesn't work properly for connections The new `rename_graphql_field` API doesn't work properly for connections. ## Steps to Reproduce Add the following code to functions.php or custom plugin code: ```php add_action( 'graphql_register_types', function() { rename_graphql_field( 'RootQ...
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issu...
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. This issue has been automatically closed because it has not had recent activity. If you believe this issue is still valid, please open a new issu...
[ "https://github.com/wp-graphql/wp-graphql/commit/0a849e9f9b4b0a0b3a9eee002e352fd02bc6e4c3", "https://github.com/wp-graphql/wp-graphql/commit/25497c039b5bc5e118d408f01d15cfc449f3f33a", "https://github.com/wp-graphql/wp-graphql/commit/15fc495341765f2b62863008878ebfa9bfb912e4" ]
2023-09-30T19:30:10
1.27
PHP
wp-graphql/wp-graphql
3,048
wp-graphql__wp-graphql-3048
[ 2514 ]
54d03523d4fee4064900e093be1518cbacb2cb41
diff --git a/src/Model/PostType.php b/src/Model/PostType.php index 251fecdca..9e054cbee 100644 --- a/src/Model/PostType.php +++ b/src/Model/PostType.php @@ -182,16 +182,8 @@ protected function init() { }, // If the homepage settings are to set to 'isPostsPage' => function () { - if ( - '...
diff --git a/tests/wpunit/NodeByUriTest.php b/tests/wpunit/NodeByUriTest.php index 2a704588b..faddf5483 100644 --- a/tests/wpunit/NodeByUriTest.php +++ b/tests/wpunit/NodeByUriTest.php @@ -70,6 +70,8 @@ public function getQuery(): string { databaseId } uri + isPostsPage + isFrontPage } } ...
On ContentType union in nodeByUri returns incorrect isPostsPage ### Description `...on ContentType` union in `nodeByUri` returns incorrect `isPostsPage` ### Steps to reproduce 1. Set your WordPress instance to have a static posts page 2. Use the following query to query it by uri (in my case `/blog`): ``...
Related: #2486 (can probably be temporarily resolved before #2491) cc: #2513 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. confirmed not stale wp 6.4.1 + wpgraphql 1.18.2 ![image](https://g...
Related: #2486 (can probably be temporarily resolved before #2491) cc: #2513 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. confirmed not stale wp 6.4.1 + wpgraphql 1.18.2 ![image](https://g...
[ "https://github.com/wp-graphql/wp-graphql/commit/710943672d0c686056f6cc6b1c70b37604a89961", "https://github.com/wp-graphql/wp-graphql/commit/3744e1d68cdde3cf7a31628edd44ff5d8beaf055", "https://github.com/wp-graphql/wp-graphql/commit/f8f44372d9645de0227af8a620d91e870df4c763", "https://github.com/wp-graphql/wp-...
2024-02-16T20:05:51
1.27
PHP
wp-graphql/wp-graphql
3,172
wp-graphql__wp-graphql-3172
[ 3159 ]
d011c9a04458b487da04c058a36b96b6a907eb8b
diff --git a/cli/wp-cli.php b/cli/wp-cli.php index e2b9ade46..002e60c10 100644 --- a/cli/wp-cli.php +++ b/cli/wp-cli.php @@ -39,8 +39,16 @@ public function generate_static_schema( $args, $assoc_args ) { * Generate the Schema */ WP_CLI::line( 'Getting the Schema...' ); + + // Set the introspection query flag...
diff --git a/tests/wpunit/AccessFunctionsTest.php b/tests/wpunit/AccessFunctionsTest.php index 1441215d9..bf608fee4 100644 --- a/tests/wpunit/AccessFunctionsTest.php +++ b/tests/wpunit/AccessFunctionsTest.php @@ -2376,13 +2376,11 @@ public function testRegisterFieldWithNonExistingTypeReturnsErrorWhenFieldIsRefer $t...
Eagerly Load Types should only be true for introspection requests ### What problem does this address? When a type is defined as `eagerlyLoadType => true` there is a run-time performance cost for each query and this is typically only needed for Introspection queries. ### What is your proposed solution? We should con...
[ "https://github.com/wp-graphql/wp-graphql/commit/de2e5f2ad10896fa7d958a715d844b4bb37b1c6a", "https://github.com/wp-graphql/wp-graphql/commit/8352fbe231aa2b93880174f95b7ad370405d6b84", "https://github.com/wp-graphql/wp-graphql/commit/3fbb25ab9a6798527d191e0be30081c6d16ff56e", "https://github.com/wp-graphql/wp-...
2024-07-09T22:20:55
1.27
PHP
wp-graphql/wp-graphql
3,433
wp-graphql__wp-graphql-3433
[ 3432 ]
6e64fd170ce30af6d46017a84729d11fed8478c6
diff --git a/phpcs/WPGraphQL/PHPCS/Sniffs/Functions/VersionParameterSniff.php b/phpcs/WPGraphQL/PHPCS/Sniffs/Functions/VersionParameterSniff.php index 3d535b77c..d8198b548 100644 --- a/phpcs/WPGraphQL/PHPCS/Sniffs/Functions/VersionParameterSniff.php +++ b/phpcs/WPGraphQL/PHPCS/Sniffs/Functions/VersionParameterSniff.php...
diff --git a/tests/wpunit/MediaItemQueriesTest.php b/tests/wpunit/MediaItemQueriesTest.php index 7e02ae747..54db4d94c 100644 --- a/tests/wpunit/MediaItemQueriesTest.php +++ b/tests/wpunit/MediaItemQueriesTest.php @@ -1033,4 +1033,60 @@ public function testMediaDetailsFilePath() { wp_delete_attachment( $attachment_...
MediaItemSizeEnum becomes empty when intermediate image sizes are disabled β†’ schema invalid ### Description When WordPress runs with all intermediate image sizes disabled (policy on WordPress VIP), WPGraphQL exposes MediaItemSizeEnum with zero values. This produces an invalid GraphQL schema and breaks tools that consu...
@tloureiro Thanks for opening this issue and providing context and steps to reproduce! I am working on a PR and hope to have something ready shortly.
@tloureiro Thanks for opening this issue and providing context and steps to reproduce! I am working on a PR and hope to have something ready shortly.
[ "https://github.com/wp-graphql/wp-graphql/commit/58fc33a30f4af757b840d23fff4aefd184b0d3c9", "https://github.com/wp-graphql/wp-graphql/commit/7db8c1bdfa98314ee743c46cbc565a659c4e08a5", "https://github.com/wp-graphql/wp-graphql/commit/d81d354f5ff1c8c9a6dc2b559ad2e7cf4caf1e85", "https://github.com/wp-graphql/wp-...
2025-10-30T03:22:48
1.27
PHP
codeigniter4/CodeIgniter4
7,187
codeigniter4__CodeIgniter4-7187
[ 7178 ]
6e5a9cbf2a59d0e810bd4ea4ddfca03194852f91
diff --git a/system/Session/Handlers/RedisHandler.php b/system/Session/Handlers/RedisHandler.php index 4492c4dbed32..9910637663f5 100644 --- a/system/Session/Handlers/RedisHandler.php +++ b/system/Session/Handlers/RedisHandler.php @@ -24,7 +24,8 @@ */ class RedisHandler extends BaseHandler { - private const DEFA...
diff --git a/tests/system/Session/Handlers/Database/RedisHandlerTest.php b/tests/system/Session/Handlers/Database/RedisHandlerTest.php index 4a4cdcc45f19..b5d67a768c47 100644 --- a/tests/system/Session/Handlers/Database/RedisHandlerTest.php +++ b/tests/system/Session/Handlers/Database/RedisHandlerTest.php @@ -54,6 +54,...
Bug: Can't connect to Redis with Session RedisHandler over TLS ### PHP Version 8.1 ### CodeIgniter4 Version 4.3.1 ### CodeIgniter4 Installation Method Composer (using `codeigniter4/appstarter`) ### Which operating systems have you tested for this bug? Windows, Linux ### Which server did you use?...
For now we connect to `Redis` without `Protocol` I send PR #7187, @TOAD-Joey can try this changes? @ddevsr Yes, great, this fixes the issue.
For now we connect to `Redis` without `Protocol` I send PR #7187, @TOAD-Joey can try this changes? @ddevsr Yes, great, this fixes the issue.
[ "https://github.com/codeigniter4/CodeIgniter4/commit/b547b22efd0f7821a03dea6052b7db1faddb13e4", "https://github.com/codeigniter4/CodeIgniter4/commit/ff572f6f1d112c880e4996dabbedad5551f20ddb", "https://github.com/codeigniter4/CodeIgniter4/commit/1e8b87c2f80f2a861c629834a1a5795bc2ccacbd", "https://github.com/co...
2023-01-26T10:08:27
4.3
PHP
codeigniter4/CodeIgniter4
7,046
codeigniter4__CodeIgniter4-7046
[ 7045 ]
6eaa945aa6f6f2a21f823284206a11911bda553d
diff --git a/system/Events/Events.php b/system/Events/Events.php index 3117969882df..064f01ab4104 100644 --- a/system/Events/Events.php +++ b/system/Events/Events.php @@ -246,7 +246,7 @@ public static function setFiles(array $files) * * @return string[] */ - public function getFiles() + public s...
diff --git a/tests/system/Events/EventsTest.php b/tests/system/Events/EventsTest.php index b6a8aa1a4cb7..1a106aca3548 100644 --- a/tests/system/Events/EventsTest.php +++ b/tests/system/Events/EventsTest.php @@ -55,21 +55,21 @@ public function testInitialize() // it should start out empty MockEvents:...
Bug: The getFiles method of \CodeIgniter\Events class is declared as 'public', but it should probably be 'public static'. ### PHP Version 8.2 ### CodeIgniter4 Version 4.2.11 ### CodeIgniter4 Installation Method Composer (using `codeigniter4/appstarter`) ### Which operating systems have you tested for this bug? L...
The properties in the Event class are all static and all methods other than getFiles() are static. So I agree that the method should be static.
The properties in the Event class are all static and all methods other than getFiles() are static. So I agree that the method should be static. That looks like just a typo to me. It will still work in an instantiated object even if we change it to `static` so let's do just that. @benedict-tshaba Would you send a PR fo...
[ "https://github.com/codeigniter4/CodeIgniter4/commit/5764d0c75565443315026731db1e113ece1af371", "https://github.com/codeigniter4/CodeIgniter4/commit/5148921b3a730411d70af92663cfb5b43a337118", "https://github.com/codeigniter4/CodeIgniter4/commit/76610375748e7c90e86b7e086e1c1769d7761dd2", "https://github.com/co...
2023-01-03T11:43:28
4.2
PHP
codeigniter4/CodeIgniter4
8,446
codeigniter4__CodeIgniter4-8446
[ 8419 ]
5bbf3afe0173d4d8fffd1e90b850116413d988f0
diff --git a/system/Email/Email.php b/system/Email/Email.php index d18b40ff7cef..42835c3d404e 100644 --- a/system/Email/Email.php +++ b/system/Email/Email.php @@ -705,6 +705,7 @@ public function attach($file, $disposition = '', $newname = null, $mime = '') public function setAttachmentCID($filename) { ...
diff --git a/tests/system/Email/EmailTest.php b/tests/system/Email/EmailTest.php index dfcbedf183cc..77f40dead168 100644 --- a/tests/system/Email/EmailTest.php +++ b/tests/system/Email/EmailTest.php @@ -162,4 +162,55 @@ private function createMockEmail(): MockEmail return new MockEmail($config); } + + ...
Bug: Email.php inline images fail. ### PHP Version 7.4, 8.0, 8.1, 8.2, 8.3 ### CodeIgniter4 Version 4.4.1+ ### CodeIgniter4 Installation Method Composer (using `codeigniter4/appstarter`) ### Which operating systems have you tested for this bug? macOS, Linux ### Which server did you use? apach...
The first parameter is a real filename., not new filename. See https://codeigniter4.github.io/CodeIgniter4/libraries/email.html#CodeIgniter\Email\Email::setAttachmentCID ```php public function index(): string { $email = \Config\Services::email(); $filename = ROOTPATH . 'tests/_support/...
The first parameter is a real filename., not new filename. See https://codeigniter4.github.io/CodeIgniter4/libraries/email.html#CodeIgniter\Email\Email::setAttachmentCID ```php public function index(): string { $email = \Config\Services::email(); $filename = ROOTPATH . 'tests/_support/...
[ "https://github.com/codeigniter4/CodeIgniter4/commit/1741648fe6d2ad0b78deeceec85c2ef7a337f4ae", "https://github.com/codeigniter4/CodeIgniter4/commit/51d6963588c5c0c3761e8e2e26621c54d3c45e34" ]
2024-01-23T22:17:13
4.4
PHP
codeigniter4/CodeIgniter4
9,009
codeigniter4__CodeIgniter4-9009
[ 9007 ]
d14dce8a215bb7cab28e56d7d8de0c23a3ef2770
diff --git a/phpstan-baseline.php b/phpstan-baseline.php index 5a39d840a54d..bd665e22f5f7 100644 --- a/phpstan-baseline.php +++ b/phpstan-baseline.php @@ -1819,12 +1819,6 @@ 'count' => 1, 'path' => __DIR__ . '/system/Database/BaseBuilder.php', ]; -$ignoreErrors[] = [ - // identifier: missingType.iterableValue - 'm...
diff --git a/tests/system/Database/Builder/SelectTest.php b/tests/system/Database/Builder/SelectTest.php index cd3f39029f6b..fe4ad5b80178 100644 --- a/tests/system/Database/Builder/SelectTest.php +++ b/tests/system/Database/Builder/SelectTest.php @@ -19,6 +19,7 @@ use CodeIgniter\Database\SQLSRV\Builder as SQLSRVBuild...
Bug: [QueryBuilder] select() TypeError: trim(): Argument #1 ($string) must be of type string, CodeIgniter\Database\RawSql given ### PHP Version 8.1 ### CodeIgniter4 Version 4.5.3 ### CodeIgniter4 Installation Method Composer (as dependency to an existing project) ### Which operating systems have you tested for th...
Expected Output ```sql SELECT col1, `col2` FROM `table` ``` Why do you want to use RawSql to only the first element? Check this. #9009 > Expected Output > > ```sql > SELECT col1, `col2` > FROM `table` > ``` > > Why do you want to use RawSql to only the first element? I have developed a custom library...
Expected Output ```sql SELECT col1, `col2` FROM `table` ``` Why do you want to use RawSql to only the first element? Check this. #9009 > Expected Output > > ```sql > SELECT col1, `col2` > FROM `table` > ``` > > Why do you want to use RawSql to only the first element? I have developed a custom library...
[ "https://github.com/codeigniter4/CodeIgniter4/commit/43ce1350f64b48c8de7cffab5d7cadc49fa51443", "https://github.com/codeigniter4/CodeIgniter4/commit/1962e8c82c46b5c4d4ea3c0235cbae590efe59a6", "https://github.com/codeigniter4/CodeIgniter4/commit/73d67fb659b54b25d5d0ab51b919daebb678f9a7", "https://github.com/co...
2024-06-28T00:19:22
4.5
PHP
codeigniter4/CodeIgniter4
9,679
codeigniter4__CodeIgniter4-9679
[ 9678 ]
509ed87b648908e7c5a5f6dea1e96b52390a3bf7
diff --git a/system/Database/Config.php b/system/Database/Config.php index 6f25ad3c0059..fcf700ee3bcb 100644 --- a/system/Database/Config.php +++ b/system/Database/Config.php @@ -81,7 +81,9 @@ public static function connect($group = null, bool $getShared = true) $connection = static::$factory->load($config, ...
diff --git a/tests/system/Database/Live/ConnectTest.php b/tests/system/Database/Live/ConnectTest.php index 3f7941a201ec..e41fdbdfc114 100644 --- a/tests/system/Database/Live/ConnectTest.php +++ b/tests/system/Database/Live/ConnectTest.php @@ -115,4 +115,22 @@ public function testConnectWithFailover(): void $...
Bug: Unshared DB instance affects subsequent shared DB instances ### PHP Version 8.4 ### CodeIgniter4 Version develop, 4.7 ### CodeIgniter4 Installation Method Git ### Which operating systems have you tested for this bug? macOS ### Which server did you use? cli ### Database SQLite3 ### What happened? When ...
[ "https://github.com/codeigniter4/CodeIgniter4/commit/55ef9f0564c4a6794dd6ce4794e3776ea11fc12d", "https://github.com/codeigniter4/CodeIgniter4/commit/bca4d82d58b616a79f06dd28427d6df1c6380613" ]
2025-08-12T19:08:47
4.6
PHP
dedoc/scramble
860
dedoc__scramble-860
[ 540 ]
98e49da20474c6712d4e1ed8fb72612470416c80
diff --git a/src/Infer/Reflector/MethodReflector.php b/src/Infer/Reflector/MethodReflector.php index b469094d3..dc0994de6 100644 --- a/src/Infer/Reflector/MethodReflector.php +++ b/src/Infer/Reflector/MethodReflector.php @@ -70,16 +70,16 @@ public function getAstNode(): ?ClassMethod $partialClass = "<?ph...
diff --git a/tests/Infer/ConstsFetchResolutionTest.php b/tests/Infer/ConstsFetchResolutionTest.php new file mode 100644 index 000000000..d76a8d2ba --- /dev/null +++ b/tests/Infer/ConstsFetchResolutionTest.php @@ -0,0 +1,16 @@ +<?php + +namespace Dedoc\Scramble\Tests\Infer; + +use Dedoc\Scramble\Tests\Infer\stubs\Respon...
Response Body Returning String when using ApiResponser Trait Hello All I use scamble version 0.11.13 with Laravel 11. When I build an API, I always create an ApiResponser Trait to keep my API response consistent. Such as: ``` { success: boolean, data: array, message: string } ``` I create **Api...
@arislanhaikal This is Scramble's issue. I will fix! ```php public function index(Requests $request): JsonResource { // more code including `$user` return $this->returnData($user); } public function returnData($user): JsonResource { // some more code return new UsersResource($user); } ``` ...
@arislanhaikal This is Scramble's issue. I will fix! ```php public function index(Requests $request): JsonResource { // more code including `$user` return $this->returnData($user); } public function returnData($user): JsonResource { // some more code return new UsersResource($user); } ``` ...
[ "https://github.com/dedoc/scramble/commit/4972a69135504d526115691569d870ea0bb5efc9" ]
2025-05-30T14:21:53
0.12
PHP
dedoc/scramble
124
dedoc__scramble-124
[ 111 ]
2d547028a8e11aa62aad4c181e33a102aabce928
diff --git a/src/Support/Generator/Parameter.php b/src/Support/Generator/Parameter.php index 2e6222126..a4ef05928 100644 --- a/src/Support/Generator/Parameter.php +++ b/src/Support/Generator/Parameter.php @@ -65,6 +65,13 @@ public function required(bool $required) return $this; } + public function se...
diff --git a/tests/Generator/Request/ValidationRulesDocumentation.php b/tests/Generator/Request/ValidationRulesDocumentation.php new file mode 100644 index 000000000..14a95b7d1 --- /dev/null +++ b/tests/Generator/Request/ValidationRulesDocumentation.php @@ -0,0 +1,16 @@ +<?php + +use Dedoc\Scramble\Support\OperationExt...
Add `confirmed` rule support Rule: 'password' => [ 'required', 'string', 'confirmed', ], Problem: Docs not showing the 'password_confirmation' parameter _Originally posted by @JesperFiltenborg in https://github.com/dedoc/scramble/discussions/108_
[ "https://github.com/dedoc/scramble/commit/d253f5d93baf9063ffd542369d47562e1434660a" ]
2023-04-16T10:57:05
0.7
PHP
dedoc/scramble
658
dedoc__scramble-658
[ 455 ]
43d8f7573e83d8dbf080bc76a9f11cfd0318ad74
diff --git a/src/Support/OperationExtensions/RulesExtractor/RulesMapper.php b/src/Support/OperationExtensions/RulesExtractor/RulesMapper.php index acbaa386e..d8f345892 100644 --- a/src/Support/OperationExtensions/RulesExtractor/RulesMapper.php +++ b/src/Support/OperationExtensions/RulesExtractor/RulesMapper.php @@ -11,...
diff --git a/tests/ValidationRulesDocumentingTest.php b/tests/ValidationRulesDocumentingTest.php index 8c8ac4a78..ccc2db1ae 100644 --- a/tests/ValidationRulesDocumentingTest.php +++ b/tests/ValidationRulesDocumentingTest.php @@ -80,6 +80,38 @@ function validationRulesToDocumentationWithDeep(array $rules) assertMat...
Rule::enum doesn't take into consideration additional params `Rule::enum` ignores `only` or `except` methods, which allows you to limit which enum values are allowed. https://laravel.com/docs/master/validation#rule-enum I've updated to latest version `0.11.4.` <img width="1205" alt="Screenshot 2024-07-15 at 21...
I'm also running into the same problem Here are the screenshots ![image](https://github.com/user-attachments/assets/030da88e-f0c6-4367-940c-2a3b04dbdd99) ![image](https://github.com/user-attachments/assets/14b251c4-45f3-435c-b109-8d1d40d96718) If someone knows it is possible to hide the Enum values not in my on...
I'm also running into the same problem Here are the screenshots ![image](https://github.com/user-attachments/assets/030da88e-f0c6-4367-940c-2a3b04dbdd99) ![image](https://github.com/user-attachments/assets/14b251c4-45f3-435c-b109-8d1d40d96718) If someone knows it is possible to hide the Enum values not in my on...
[ "https://github.com/dedoc/scramble/commit/6027e9a61db321849199efbc88c2843f5d1c6dea", "https://github.com/dedoc/scramble/commit/c27cecf89d96b41ce3b687f16c6e304603f3b7c4" ]
2024-12-11T20:56:52
0.11
PHP
dedoc/scramble
165
dedoc__scramble-165
[ 164 ]
bc7811ce756c4986b7b4fc3d8af3186fa64b6abe
diff --git a/src/Support/ResponseExtractor/ModelInfo.php b/src/Support/ResponseExtractor/ModelInfo.php index d2067bf40..a3a785c73 100644 --- a/src/Support/ResponseExtractor/ModelInfo.php +++ b/src/Support/ResponseExtractor/ModelInfo.php @@ -321,6 +321,7 @@ protected function getCastType($column, $model) protected ...
diff --git a/tests/Support/ResponseExtractor/ModelInfoTest.php b/tests/Support/ResponseExtractor/ModelInfoTest.php new file mode 100644 index 000000000..2de9ae14c --- /dev/null +++ b/tests/Support/ResponseExtractor/ModelInfoTest.php @@ -0,0 +1,16 @@ +<?php + +use Dedoc\Scramble\Support\ResponseExtractor\ModelInfo; + +i...
ModelInfo->getCastsWithDates() - array_flip error I am getting the following error when generating API documentation for my Laravel 10 project. "array_flip(): Can only flip string and integer values, entry skipped {"exception":"[object] (ErrorException(code: 0): array_flip()" The array that $model->getDates() re...
@deffjay fixed in 0.8.1 https://github.com/dedoc/scramble/releases/tag/v0.8.1
@deffjay fixed in 0.8.1 https://github.com/dedoc/scramble/releases/tag/v0.8.1 @romalytvynenko - excellent, thank you. I just verified on 0.8.1.
[ "https://github.com/dedoc/scramble/commit/cdfde86a0b7785adc5e02895de64b3460ca27bf2" ]
2023-08-05T08:43:00
0.8
PHP
dedoc/scramble
377
dedoc__scramble-377
[ 311 ]
001a37ba4844a54a9d1281a17fa6f451bc2bf9b5
diff --git a/src/Support/TypeToSchemaExtensions/AnonymousResourceCollectionTypeToSchema.php b/src/Support/TypeToSchemaExtensions/AnonymousResourceCollectionTypeToSchema.php index e939c8880..d4a23d8d2 100644 --- a/src/Support/TypeToSchemaExtensions/AnonymousResourceCollectionTypeToSchema.php +++ b/src/Support/TypeToSche...
diff --git a/tests/ResourceCollectionResponseTest.php b/tests/ResourceCollectionResponseTest.php index d260397b5..082b84af6 100644 --- a/tests/ResourceCollectionResponseTest.php +++ b/tests/ResourceCollectionResponseTest.php @@ -1,12 +1,10 @@ <?php use Dedoc\Scramble\Infer; -use Dedoc\Scramble\Scramble; use Dedoc\...
Additional collection’s data: Not documenting According to the docs, Additional collection data will automatically be documented when adding additional data to a collection. ```php use Illuminate\Http\Resources\Json\AnonymousResourceCollection; use App\Models\TodoItem; use Illuminate\Pagination\LengthAwarePaginat...
Works for me as follows: ``` <?php namespace App\Http\Controllers\V1; use App\Http\Controllers\Controller; use App\Http\Requests\StoreCourseRequest; use App\Http\Resources\CourseResource; use App\Models\Course; use Illuminate\Http\Resources\Json\AnonymousResourceCollection; use Illuminate\Pagination\Leng...
Works for me as follows: ``` <?php namespace App\Http\Controllers\V1; use App\Http\Controllers\Controller; use App\Http\Requests\StoreCourseRequest; use App\Http\Resources\CourseResource; use App\Models\Course; use Illuminate\Http\Resources\Json\AnonymousResourceCollection; use Illuminate\Pagination\Leng...
[ "https://github.com/dedoc/scramble/commit/f783f01a3713015e3dd1e499416cb9cd43fd5cd3", "https://github.com/dedoc/scramble/commit/b34286c2395cad5c3fd1fa2cfd4876d9422e957b" ]
2024-05-18T07:10:45
0.10
PHP
briannesbitt/Carbon
3,051
briannesbitt__Carbon-3051
[ 2604, 3050 ]
4ecea7648d2addd5c26d8d373c1a417b637556ac
diff --git a/phpstan.neon b/phpstan.neon index bd50d81065..55977ff14e 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -57,6 +57,10 @@ parameters: message: '#^Call to an undefined method Carbon\\CarbonImmutable::[a-zA-Z]+Of[a-zA-Z]+\(\)\.$#' paths: - tests/CarbonImmutable/Gette...
diff --git a/tests/Carbon/DiffTest.php b/tests/Carbon/DiffTest.php index f43c48eab8..6b16590a10 100644 --- a/tests/Carbon/DiffTest.php +++ b/tests/Carbon/DiffTest.php @@ -136,11 +136,11 @@ public function testDiffInMonthsWithTimezone() $this->assertSame(-1, (int) $first->diffInMonths($second, false)); ...
diffInMonths inconsistent, adding a day makes the difference bigger instead of smaller <!-- πŸ›‘ DON'T REMOVE ME. This issue template apply to all - bug reports, - feature proposals, - and documentation requests Having all those informations will allow us to know exactly what yo...
I've thrown together this, which seems to produce more consistent results (not quite sure if youd call them correct?) ```php /** * Adds $months months to the date with no overflow while attempting to keep the calendar day/hour/minute/second the same (or lower) * @param Carbon $carbon Is copied, not mo...
I've thrown together this, which seems to produce more consistent results (not quite sure if youd call them correct?) ```php /** * Adds $months months to the date with no overflow while attempting to keep the calendar day/hour/minute/second the same (or lower) * @param Carbon $carbon Is copied, not mo...
[ "https://github.com/briannesbitt/Carbon/commit/0e2a607329784dbb1a06270584dbd028ad377ad2", "https://github.com/briannesbitt/Carbon/commit/4d3f401d3954764fd08f99a2997b2c1ecdf55043", "https://github.com/briannesbitt/Carbon/commit/37b3bd5f341da63f93aa0abd3ad6a95c14ab9041", "https://github.com/briannesbitt/Carbon/...
2024-07-15T16:59:17
1.39
PHP
briannesbitt/Carbon
2,984
briannesbitt__Carbon-2984
[ 2982 ]
6bfea14bb0792e85f2e1ff0919487c88419c5883
diff --git a/src/Carbon/CarbonPeriod.php b/src/Carbon/CarbonPeriod.php index 326ef3383f..3579c1619c 100644 --- a/src/Carbon/CarbonPeriod.php +++ b/src/Carbon/CarbonPeriod.php @@ -595,11 +595,17 @@ public static function __callStatic(string $method, array $parameters): mixed */ public function __construct(......
diff --git a/tests/CarbonPeriod/CreateTest.php b/tests/CarbonPeriod/CreateTest.php index 5e7282c13c..a2f6086bba 100644 --- a/tests/CarbonPeriod/CreateTest.php +++ b/tests/CarbonPeriod/CreateTest.php @@ -856,4 +856,36 @@ public function testEnums() $this->assertSame(2, $period->count()); } + + public ...
Period `start` and `end` always wrong with Carbon 3 In Carbon 3 the `start` and `end` properties of a CarbonPeriod or CarbonPeriodImmutable are always `2000-01-01` and `null`. [Sandbox example.](https://play.phpsandbox.io/nesbot/carbon/mN7g4E1kZgKWn281) Code to reproduce the issue: ```php [ Carbon::parse...
It's because now `CarbonPeriod` extends `DatePeriod` but readonly cannot be controlled from sub-class. I recommend you use the getters: ```php [ Carbon::parse('Sep 1')->toPeriod('Sep 30')->getStartDate(), Carbon::parse('Sep 1')->toPeriod('Sep 30')->getEndDate(), ]; ``` We can make it correct at creatio...
It's because now `CarbonPeriod` extends `DatePeriod` but readonly cannot be controlled from sub-class. I recommend you use the getters: ```php [ Carbon::parse('Sep 1')->toPeriod('Sep 30')->getStartDate(), Carbon::parse('Sep 1')->toPeriod('Sep 30')->getEndDate(), ]; ``` We can make it correct at creatio...
[ "https://github.com/briannesbitt/Carbon/commit/3eaeec4c4217ddb9de91c3ab4937f58bafa8270e", "https://github.com/briannesbitt/Carbon/commit/aa0ed85ef22edfaf729bab91e1004210db397e4b" ]
2024-03-27T18:14:00
1.39
PHP
briannesbitt/Carbon
3,144
briannesbitt__Carbon-3144
[ 3143 ]
a95c8e7b5bc6e5bdee4c45cadd932a063da23a95
diff --git a/src/Carbon/Lang/az.php b/src/Carbon/Lang/az.php index c53865e6df..1b5ded05b9 100644 --- a/src/Carbon/Lang/az.php +++ b/src/Carbon/Lang/az.php @@ -18,6 +18,7 @@ * - Orxan * - ΕžΙ™hriyar Δ°manov * - Baran ŞengΓΌl + * - Novruz Rahimov */ return [ 'year' => ':count il', @@ -34,13 +35,13 @@ 'd' =...
diff --git a/tests/Localization/AzAzTest.php b/tests/Localization/AzAzTest.php index 1ecade93b4..dc71a3038e 100644 --- a/tests/Localization/AzAzTest.php +++ b/tests/Localization/AzAzTest.php @@ -227,35 +227,35 @@ class AzAzTest extends LocalizationTestCase // Carbon::now()->subSeconds(1)->diffForHumans() ...
Short and long time translation mismatchs |English|Azerbaijani|comments| |--|--|--| |2h|2 saat|This should rather be '2 s' because in Azerbaijani, abbreviating 'saat' to 's' is a common practice for time expressions, especially for shorthand notation, similar to other languages using single-letter time units.| |2 minut...
[ "https://github.com/briannesbitt/Carbon/commit/964001c7d2c8069041b133fc7d37673c01167076", "https://github.com/briannesbitt/Carbon/commit/d4ad3cdc985f5c3398b01a3a9c2c5509b6279ec2", "https://github.com/briannesbitt/Carbon/commit/2ac02b5a09edc3c046df65600d4a06d12c8eafe7" ]
2025-02-08T13:21:09
1.39
PHP
briannesbitt/Carbon
2,859
briannesbitt__Carbon-2859
[ 2858 ]
98276233188583f2ff845a0f992a235472d9466a
diff --git a/composer.json b/composer.json index 7560763027..48366b5ddc 100644 --- a/composer.json +++ b/composer.json @@ -42,14 +42,15 @@ "require": { "php": "^7.1.8 || ^8.0", "ext-json": "*", + "carbonphp/carbon-doctrine-types": "*", "psr/clock": "^1.0", "symfony/polyfi...
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index c671af5065..2563be5ec1 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -139,6 +139,7 @@ jobs: - name: Install dependencies uses: nick-fields/retry@v2 + if: steps.composer-cache.outputs.cac...
CarbonTypeConverter broken with Doctrine/Dbal 3.7 <!-- πŸ›‘ DON'T REMOVE ME. This issue template applies to all - bug reports, - feature proposals, - and documentation requests Having all those informations will allow us to know exactly what you expect and answer you faster and ...
Line 39 should use ?? instead of ? But 3.7.0 is bringing lot of preparation to 4.0, so it might bring more important change. I had to go back to earlier version of DBAL. That's a great news because in oldest versions of dbal, it was not possible to know if the precision was set to 0 or not set at all (so to use th...
Line 39 should use ?? instead of ? But 3.7.0 is bringing lot of preparation to 4.0, so it might bring more important change. I had to go back to earlier version of DBAL. That's a great news because in oldest versions of dbal, it was not possible to know if the precision was set to 0 or not set at all (so to use th...
[ "https://github.com/briannesbitt/Carbon/commit/4d0680223fda625d5573910dcf9785e5f293f173", "https://github.com/briannesbitt/Carbon/commit/0398c6ba6a7a2a3a0feeaad34d9a218db1380a7c", "https://github.com/briannesbitt/Carbon/commit/2a52c0db1863948138a4c4228eaa1dc936b7977b" ]
2023-10-01T14:42:54
1.39
PHP
briannesbitt/Carbon
3,103
briannesbitt__Carbon-3103
[ 3102 ]
d481d8d69a94dc00e5c1b147ec1f7e7492626b12
diff --git a/src/Carbon/Traits/Date.php b/src/Carbon/Traits/Date.php index 8a2860af5b..8ac81ea732 100644 --- a/src/Carbon/Traits/Date.php +++ b/src/Carbon/Traits/Date.php @@ -2965,7 +2965,7 @@ private static function floorZeroPad(int|float $value, int $length): string private function mutateIfMutable(CarbonInterfa...
diff --git a/tests/Carbon/SettersTest.php b/tests/Carbon/SettersTest.php index 9883679381..d732ac28f8 100644 --- a/tests/Carbon/SettersTest.php +++ b/tests/Carbon/SettersTest.php @@ -629,6 +629,14 @@ public function testMidDayAtSetter() $this->assertSame(12, $d->getMidDayAt()); } + public function te...
setUnitNoOverflow incorrect when using immutable carbon instance <!-- πŸ›‘ Important notice to read. Before anything else, please search in previous issues (both open and close): https://github.com/briannesbitt/Carbon/issues?q=is%3Aissue ⚠️ Please don't create an issue about a problem already disc...
Thank you for the report and the analysis. I added a test with your case and I reproduce it. I tried to revert this change but apparently it's not the faulty one. I'm investigating. Fixed in 3.8.2 > Fixed in 3.8.2 Insanely quick response time. Thank you so much!
Thank you for the report and the analysis. I added a test with your case and I reproduce it. I tried to revert this change but apparently it's not the faulty one. I'm investigating. Fixed in 3.8.2 > Fixed in 3.8.2 Insanely quick response time. Thank you so much!
[ "https://github.com/briannesbitt/Carbon/commit/9d1cc387a55d3708b93daeeec7465bfb5f349fdc" ]
2024-11-07T17:38:38
1.39
PHP
cakephp/cakephp
17,049
cakephp__cakephp-17049
[ 17048 ]
59c6d482d1ac68156e504d984a9b281b103bb7d6
diff --git a/src/Http/Cookie/Cookie.php b/src/Http/Cookie/Cookie.php index f4fea6736cc..24d2494cd5f 100644 --- a/src/Http/Cookie/Cookie.php +++ b/src/Http/Cookie/Cookie.php @@ -621,7 +621,7 @@ public function withNeverExpire() public function withExpired() { $new = clone $this; - $new->expires...
diff --git a/tests/TestCase/Http/Cookie/CookieTest.php b/tests/TestCase/Http/Cookie/CookieTest.php index 37cfa51ebc5..03e3d8d1afd 100644 --- a/tests/TestCase/Http/Cookie/CookieTest.php +++ b/tests/TestCase/Http/Cookie/CookieTest.php @@ -236,6 +236,21 @@ public function testWithExpired(): void $this->assertStri...
Expire cookie when App defaultTimezone is not UTC ### Description Cakephp 4.x How to reproduce : Configuration ```php # config/app.php 'defaultTimezone' => 'Europe/Paris', ``` Tests controller ```php <?php declare(strict_types=1); namespace App\Controller; use Cake\Http\Cookie\Cookie; class...
The response when `setcookie()` expires timestamp is negative. ``` HTTP/1.1 302 Found Host: localhost:8000 Date: Fri, 03 Mar 2023 17:26:25 GMT Connection: close X-Powered-By: PHP/8.1.16 Content-Type: text/html; charset=UTF-8 Location: http://localhost:8000/tests/readCookie X-DEBUGKIT-ID: b94f8d2a-935c-42e0-8...
The response when `setcookie()` expires timestamp is negative. ``` HTTP/1.1 302 Found Host: localhost:8000 Date: Fri, 03 Mar 2023 17:26:25 GMT Connection: close X-Powered-By: PHP/8.1.16 Content-Type: text/html; charset=UTF-8 Location: http://localhost:8000/tests/readCookie X-DEBUGKIT-ID: b94f8d2a-935c-42e0-8...
[ "https://github.com/cakephp/cakephp/commit/8e6a6683b35fb458602dae499d93b03dbcead282", "https://github.com/cakephp/cakephp/commit/03789139aac56f8f4172dd14e4c661d4744b9d97", "https://github.com/cakephp/cakephp/commit/eb6dae46bd59b95b7ac9077b68c0ae5c19598936", "https://github.com/cakephp/cakephp/commit/c60ed9c8b...
2023-03-03T16:21:21
0.0
PHP
cakephp/cakephp
18,993
cakephp__cakephp-18993
[ 15175 ]
ffb9b4d3ea686b134376d4bb2ed1064a8be8a248
diff --git a/src/Database/Query.php b/src/Database/Query.php index d639049747a..b4d18f6a12e 100644 --- a/src/Database/Query.php +++ b/src/Database/Query.php @@ -1691,6 +1691,7 @@ protected function _expressionsVisitor(mixed $expression, Closure $callback): vo */ public function bind(string|int $param, mixed ...
diff --git a/tests/TestCase/ORM/Query/SelectQueryTest.php b/tests/TestCase/ORM/Query/SelectQueryTest.php index 6db889d3d60..48739479d0b 100644 --- a/tests/TestCase/ORM/Query/SelectQueryTest.php +++ b/tests/TestCase/ORM/Query/SelectQueryTest.php @@ -1611,6 +1611,29 @@ public function testCount(): void $this->as...
Query::bind() does not make the count query dirty although it should This is a (multiple allowed): * [x] bug * [ ] enhancement * [ ] feature-discussion (RFC) * CakePHP Version: 3.8.12 * Platform and Target: Apache, MySQL ### What you did In a table class: ``` $Query = $this->find() -...
Worth mentioning that marking an already executed query dirty will reset all existing bindings, so if `bind()` would mark the query dirty, each `bind()` call would remove any previously set bindings, so that only the last `bind()` call would have any effect. In your specific situation you could call `clearResult()` ...
Worth mentioning that marking an already executed query dirty will reset all existing bindings, so if `bind()` would mark the query dirty, each `bind()` call would remove any previously set bindings, so that only the last `bind()` call would have any effect. In your specific situation you could call `clearResult()` ...
[ "https://github.com/cakephp/cakephp/commit/3dd656633f85a28dae0e6319d1a7f368ec88c682" ]
2025-10-24T16:27:35
0.0
PHP
cakephp/cakephp
17,380
cakephp__cakephp-17380
[ 17378 ]
3ed29ebe4a6728593a8afcc80e0487094cc18499
diff --git a/src/View/Widget/DateTimeWidget.php b/src/View/Widget/DateTimeWidget.php index be173f651c2..49f31364050 100644 --- a/src/View/Widget/DateTimeWidget.php +++ b/src/View/Widget/DateTimeWidget.php @@ -17,6 +17,7 @@ namespace Cake\View\Widget; use Cake\Chronos\ChronosDate; +use Cake\Chronos\ChronosTime; use...
diff --git a/tests/TestCase/View/Helper/FormHelperTest.php b/tests/TestCase/View/Helper/FormHelperTest.php index 47b3ddbc59b..a9d3bc39deb 100644 --- a/tests/TestCase/View/Helper/FormHelperTest.php +++ b/tests/TestCase/View/Helper/FormHelperTest.php @@ -17,6 +17,7 @@ namespace Cake\Test\TestCase\View\Helper; use Arr...
TypeError when using Form::time() with Cake\I18n\Time ### Description I would expect `Form::time()` to accept `Cake\I18n\Time` but instead I get a TypeError: `Cake\View\Widget\DateTimeWidget::formatDateTime(): Argument #1 ($value) must be of type Cake\Chronos\ChronosDate|DateTimeInterface|string|int|null, Cake\I18n\T...
What version of Chronos are you using Are you using [3.0.2](https://github.com/cakephp/chronos/releases/tag/3.0.2)+? > What version of Chronos are you using Are you using [3.0.2](https://github.com/cakephp/chronos/releases/tag/3.0.2)+? Yes, 3.0.4 at the moment.
What version of Chronos are you using Are you using [3.0.2](https://github.com/cakephp/chronos/releases/tag/3.0.2)+? > What version of Chronos are you using Are you using [3.0.2](https://github.com/cakephp/chronos/releases/tag/3.0.2)+? Yes, 3.0.4 at the moment.
[ "https://github.com/cakephp/cakephp/commit/d3c0746b2063a144d42605b93194cf65e4c1ed3c" ]
2023-10-25T07:47:48
0.0
PHP
cakephp/cakephp
17,607
cakephp__cakephp-17607
[ 17604 ]
1daf3c0854c139bac85d3535505cef6154f9d164
diff --git a/src/I18n/DateFormatTrait.php b/src/I18n/DateFormatTrait.php index fc11ce3ce9a..945534e8245 100644 --- a/src/I18n/DateFormatTrait.php +++ b/src/I18n/DateFormatTrait.php @@ -101,7 +101,7 @@ protected function _formatObject( static::$formatters[$key] = $formatter; } - return (st...
diff --git a/tests/TestCase/I18n/DateTimeTest.php b/tests/TestCase/I18n/DateTimeTest.php index 3417a2f258a..87b2850628f 100644 --- a/tests/TestCase/I18n/DateTimeTest.php +++ b/tests/TestCase/I18n/DateTimeTest.php @@ -412,6 +412,12 @@ public function testI18nFormat(): void $result = $time->i18nFormat(IntlDateFo...
Problem formatting milliseconds using i18nFormat ### Description I am facing similar problem to https://github.com/cakephp/cakephp/issues/10439 when formatting using the function `i18nFormat` This line https://github.com/cakephp/cakephp/blob/1daf3c0854c139bac85d3535505cef6154f9d164/src/I18n/DateFormatTrait.php#L1...
The ticket you have referenced relates to saving value to datetime columns with milliseconds. Have you mapped your column to the `datetimefractional` type in table schema? (This type didn't exist in CakePHP 3.x). NVM, I see now that the issue is limited to just formatting. The change looks fine to me.
The ticket you have referenced relates to saving value to datetime columns with milliseconds. Have you mapped your column to the `datetimefractional` type in table schema? (This type didn't exist in CakePHP 3.x). NVM, I see now that the issue is limited to just formatting. The change looks fine to me. Fix released in...
[ "https://github.com/cakephp/cakephp/commit/8db90e55d7c48bc5d40870b660d4f16ea993da01", "https://github.com/cakephp/cakephp/commit/3a85e5da2b02e5ec4db5e948f1f17ed752a887c2", "https://github.com/cakephp/cakephp/commit/adbeb92b7828e3be8489611008c7fbda46598384" ]
2024-03-04T16:07:46
0.0
PHP
cakephp/cakephp
18,788
cakephp__cakephp-18788
[ 18787 ]
4fd9c162529f355e576e72e0cb00be18c82a46fc
diff --git a/src/Validation/Validation.php b/src/Validation/Validation.php index cf22446e04d..c4bdba6bbac 100644 --- a/src/Validation/Validation.php +++ b/src/Validation/Validation.php @@ -569,6 +569,9 @@ public static function datetime(mixed $check, array|string $dateFormat = 'ymd', $check = static::_getD...
diff --git a/tests/TestCase/Validation/ValidationTest.php b/tests/TestCase/Validation/ValidationTest.php index dcc99d95bc5..43fe67d04ed 100644 --- a/tests/TestCase/Validation/ValidationTest.php +++ b/tests/TestCase/Validation/ValidationTest.php @@ -967,6 +967,18 @@ public function testDateTimeObject(): void $t...
Datetime validation rises an exception when a boolean is passed as value ### Description Hello! When I use the datetime validation, if a boolean is passed as value, an error is rised [here](https://github.com/cakephp/cakephp/blob/4fd9c162529f355e576e72e0cb00be18c82a46fc/src/Validation/Validation.php#L572) as the `pre...
[ "https://github.com/cakephp/cakephp/commit/324a09e5a69c40b62758e3809b146e5b1109f70c" ]
2025-07-16T18:04:32
0.0
PHP
shlinkio/shlink
2,268
shlinkio__shlink-2268
[ 2264 ]
a8f046dffff313f48b328b3bf531e99522ff1a17
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e9555e54..a810fdc17 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,7 +38,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this * *Nothing* ### Fixed -* *Nothing* +* [#2264](https://github.com/shlinkio/shlink/issues/2264) Fix visits ...
diff --git a/module/Core/test-db/Visit/Repository/VisitDeleterRepositoryTest.php b/module/Core/test-db/Visit/Repository/VisitDeleterRepositoryTest.php index eedd28974..58d52713c 100644 --- a/module/Core/test-db/Visit/Repository/VisitDeleterRepositoryTest.php +++ b/module/Core/test-db/Visit/Repository/VisitDeleterReposi...
click delete visits in short URLS - stats - option, the visits were clear to zero, but it still shows number of stats on the overview panel and visits on the list of short URLS ### Shlink version 4.2.5 ### PHP version 8.2.25 ### How do you serve Shlink Self-hosted nginx ### Database engine MariaDB ### Database ...
Yep, I can reproduce. I'll take a look. I think it's very likely related with the changes introduced here https://github.com/shlinkio/shlink/pull/2074 That PR introduced a way to track visits counts separately than the actual visits table, to improve performance when only checking how many visits exist. When deleting...
Yep, I can reproduce. I'll take a look. I think it's very likely related with the changes introduced here https://github.com/shlinkio/shlink/pull/2074 That PR introduced a way to track visits counts separately than the actual visits table, to improve performance when only checking how many visits exist. When deleting...
[ "https://github.com/shlinkio/shlink/commit/178a99b993b7f0e085cf623d59c6b204e461a32b" ]
2024-11-15T18:23:18
0.0
PHP
shlinkio/shlink
2,525
shlinkio__shlink-2525
[ 2521 ]
fdcc9933a3ca4ea2735b1e87cd2bc3d0c921d88a
diff --git a/CHANGELOG.md b/CHANGELOG.md index 61e3a31ad..a63660aac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this * [#2517](https://github.com/shlinkio/shlink/issues/2517) Remove `REDIRECT_APPEND_EXTRA_PATH` env var. Use `...
diff --git a/module/CLI/test/Command/ShortUrl/CreateShortUrlCommandTest.php b/module/CLI/test/Command/ShortUrl/CreateShortUrlCommandTest.php index 728f8f224..ff5e3ea67 100644 --- a/module/CLI/test/Command/ShortUrl/CreateShortUrlCommandTest.php +++ b/module/CLI/test/Command/ShortUrl/CreateShortUrlCommandTest.php @@ -95,...
Remove deprecated `--tags` option from console commands using it Some console commands used to support providing a comma-separated list of tags via `--tags`. This was then replaced with the ability to provide `--tag` multiple times, but `--tags` was kept for backwards compatibility. Let's remove that now and simplify ...
[ "https://github.com/shlinkio/shlink/commit/359129f5866d370a09c023fdc4d3e922d322712e" ]
2025-11-08T09:22:16
0.0
PHP
shlinkio/shlink
2,045
shlinkio__shlink-2045
[ 2043 ]
0bc741243042772b1522a791c6520ecc83e4e319
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c2caa10a..9e8232650 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this ## [Unreleased] ### Added -* [#2041](https://github.com/shlinkio/shlink/issues/2041) Document `color` and `...
diff --git a/module/Core/test-api/Action/RedirectTest.php b/module/Core/test-api/Action/RedirectTest.php index cb623edca..e8cf211a2 100644 --- a/module/Core/test-api/Action/RedirectTest.php +++ b/module/Core/test-api/Action/RedirectTest.php @@ -75,9 +75,15 @@ public static function provideUserAgents(): iterable ...
A dynamic rule based on 'en' language takes priority over all other languages ### Shlink version 4.0.0 ### PHP version 8.2.0 ### How do you serve Shlink Other (explain in summary) ### Database engine MariaDB ### Database version 10.6 ### Current behavior When I insert a dynamic rule with the 'en' language, t...
Have you tried putting that rule the last one on the list? Browsers usually send multiple accepted languages, as a fallback in case the requested page is not available in the default language. Every time Shlink verifies a language condition, it just checks if the language set in the condition is among the accepted la...
Have you tried putting that rule the last one on the list? Browsers usually send multiple accepted languages, as a fallback in case the requested page is not available in the default language. Every time Shlink verifies a language condition, it just checks if the language set in the condition is among the accepted la...
[ "https://github.com/shlinkio/shlink/commit/be8cf56240c6b9cc1d0400cf5a49df3aaf46cc6e" ]
2024-03-07T09:11:26
0.0
PHP
shlinkio/shlink
2,370
shlinkio__shlink-2370
[ 2368 ]
7bbc93874395c1e7aa225d43ed12d528bd6d6630
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2e6746343..81cb8ba0a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com), and this project adheres to [Semantic Versioning...
diff --git a/module/Core/test-db/Visit/Repository/VisitRepositoryTest.php b/module/Core/test-db/Visit/Repository/VisitRepositoryTest.php index 29227b8bd..fe53629fd 100644 --- a/module/Core/test-db/Visit/Repository/VisitRepositoryTest.php +++ b/module/Core/test-db/Visit/Repository/VisitRepositoryTest.php @@ -470,22 +470...
Error when calling API to get non-orphan visits ### Shlink version 4.4.3 ### PHP version 8 ### How do you serve Shlink Docker image ### Database engine PostgreSQL ### Database version 16.4 ### Current behavior When attempting to call the REST API via `/rest/v3/visits/non-orphan` using an API key with the rol...
I have just released Shlink v4.4.4 including a fix for this.
I have just released Shlink v4.4.4 including a fix for this.
[ "https://github.com/shlinkio/shlink/commit/449a58879660319dfb3ee6c5b5af72eaeb0fc436" ]
2025-02-19T18:34:39
0.0
PHP
shlinkio/shlink
1,665
shlinkio__shlink-1665
[ 1662 ]
d75be372cb0adb401195d10ac5da15df75bdac7d
diff --git a/CHANGELOG.md b/CHANGELOG.md index a7389d9d4..a7a45727d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this The status 308 is equivalent to 301, and 307 is equivalent to 302. The difference is that the spec requi...
diff --git a/module/Core/test/Config/NotFoundRedirectResolverTest.php b/module/Core/test/Config/NotFoundRedirectResolverTest.php index d2d038076..4ffa00242 100644 --- a/module/Core/test/Config/NotFoundRedirectResolverTest.php +++ b/module/Core/test/Config/NotFoundRedirectResolverTest.php @@ -135,7 +135,7 @@ private fun...
Allow customizing OpenSwoole configuration options #### Summary One of my use-cases for Shlink is for single-use URLs for uploading content / large files. This was recently supported since allowing for 307/308 redirect codes (via #1657) as the request method is now persisted. However, when attempting to perform a PU...
I have some thoughts about this: * This is too specific for openswoole. The way you have implemented it in #1661, would make it useless if you run Shlink with roadrunner or php-fpm, making it a bit confusing even if it's documented. At least it should work for roadrunner too. * This is a very specific requirement f...
I have some thoughts about this: * This is too specific for openswoole. The way you have implemented it in #1661, would make it useless if you run Shlink with roadrunner or php-fpm, making it a bit confusing even if it's documented. At least it should work for roadrunner too. * This is a very specific requirement f...
[ "https://github.com/shlinkio/shlink/commit/21863e8de6761d4a94dddfd44df98201232d2fd3" ]
2023-01-12T18:26:59
0.0
PHP
glpi-project/glpi
22,266
glpi-project__glpi-22266
[ 22231 ]
2501c16725407a0a61a4b16864a33b0968312058
diff --git a/src/SoftwareLicense_User.php b/src/SoftwareLicense_User.php index 0f8288a0cc5..013e2993f19 100644 --- a/src/SoftwareLicense_User.php +++ b/src/SoftwareLicense_User.php @@ -52,6 +52,47 @@ class SoftwareLicense_User extends CommonDBRelation public static $checkItem_2_Rights = self::HAVE_SAME_RIGHT_ON_...
diff --git a/tests/functional/SoftwareLicenseTest.php b/tests/functional/SoftwareLicenseTest.php index 190bae5558b..fd83fdbba8f 100644 --- a/tests/functional/SoftwareLicenseTest.php +++ b/tests/functional/SoftwareLicenseTest.php @@ -349,11 +349,12 @@ public function testConsistentInstallationCounting() 'en...
Allow over-quota "No" can be bypassed ### Code of Conduct - [x] I agree to follow this project's Code of Conduct ### Is there an existing issue for this? - [x] I have searched the existing issues ### Version 11.0.2 ### Bug description Hello If the setting for "Allow over-quota" for a licence is set to "No", we c...
Please try with latest release. I just updated to 11.0.4 (i use the docker version), and nothing changed.
Please try with latest release. I just updated to 11.0.4 (i use the docker version), and nothing changed.
[ "https://github.com/glpi-project/glpi/commit/65add1b87e2316ff3be54d6ca27edc41040120c5", "https://github.com/glpi-project/glpi/commit/01a8810263f2f596e5b7790c7160ea789b4c31fb", "https://github.com/glpi-project/glpi/commit/678b06f90acfaddd642942d920a6f4f6d0799cba", "https://github.com/glpi-project/glpi/commit/e...
2025-12-05T13:56:10
9.1
PHP
glpi-project/glpi
22,113
glpi-project__glpi-22113
[ 21873 ]
53a69629fcffdd801531ad403ec72663590c2982
diff --git a/src/CommonDBTM.php b/src/CommonDBTM.php index 3d4dd6e030d..a3dc641cfec 100644 --- a/src/CommonDBTM.php +++ b/src/CommonDBTM.php @@ -6331,6 +6331,10 @@ protected function update1NTableData( // Get input value $input_value = $this->input[$field] ?? null; + if ($input_value === '') ...
diff --git a/tests/functional/KnowbaseItemTest.php b/tests/functional/KnowbaseItemTest.php index 161da48a9e8..6c08c6b4f3f 100644 --- a/tests/functional/KnowbaseItemTest.php +++ b/tests/functional/KnowbaseItemTest.php @@ -1665,4 +1665,46 @@ public function testClone() ) ); } + + /** + *...
Crash when trying to save a knowledge article with no category ### Code of Conduct - [x] I agree to follow this project's Code of Conduct ### Is there an existing issue for this? - [x] I have searched the existing issues ### Version 11.0.2 ### Bug description When I try to save a knowledge base article with no c...
Indeed, if you leave the "Category" item empty, an error appears in the logs. I checked with an account with maximum rights in GLPI and the article in the knowledge base has been saved and is opening. The only difference for me is that if you leave the category empty, you will get an error in the log, and if you fill i...
Indeed, if you leave the "Category" item empty, an error appears in the logs. I checked with an account with maximum rights in GLPI and the article in the knowledge base has been saved and is opening. The only difference for me is that if you leave the category empty, you will get an error in the log, and if you fill i...
[ "https://github.com/glpi-project/glpi/commit/023af8cfffee74d3791234387ca03f3d3ecbe2ef", "https://github.com/glpi-project/glpi/commit/73b280d8fcf9bd00f00dd0e8fffccd5c50280c05" ]
2025-11-30T14:59:01
9.1
PHP
glpi-project/glpi
22,397
glpi-project__glpi-22397
[ 21840 ]
027ae013a818d3de954d333dfbc640f26ff6358f
diff --git a/src/Glpi/Form/Migration/FormMigration.php b/src/Glpi/Form/Migration/FormMigration.php index b1dd729fd7e..940bc8c2d23 100644 --- a/src/Glpi/Form/Migration/FormMigration.php +++ b/src/Glpi/Form/Migration/FormMigration.php @@ -35,6 +35,7 @@ namespace Glpi\Form\Migration; use AbstractRightsDropdown; +use C...
diff --git a/tests/functional/Glpi/Form/Migration/FormMigrationTest.php b/tests/functional/Glpi/Form/Migration/FormMigrationTest.php index fc5b89e094b..e496987c221 100644 --- a/tests/functional/Glpi/Form/Migration/FormMigrationTest.php +++ b/tests/functional/Glpi/Form/Migration/FormMigrationTest.php @@ -35,6 +35,7 @@ ...
access submitted forms generated with formcreators ### Code of Conduct - [x] I agree to follow this project's Code of Conduct ### Is there an existing issue for this? - [x] I have searched the existing issues ### Version 11.0.0 ### Bug description migrated forms from formcreators to native forms, but now i can't...
In fact, you can't see the answers to a test form either. Is there any way to see the answers? I would also like to help with the solution. GLPI is the best solution for tickets and inventory on the market. If you would like to run any tests, we would be happy to do so. Thank you! Many issues have been fixed in version...
In fact, you can't see the answers to a test form either. Is there any way to see the answers? I would also like to help with the solution. GLPI is the best solution for tickets and inventory on the market. If you would like to run any tests, we would be happy to do so. Thank you! Many issues have been fixed in version...
[ "https://github.com/glpi-project/glpi/commit/db8d790ca7e7ac1389c0e85bbdb0dca6eecd2c23" ]
2025-12-17T10:26:03
9.1
PHP
glpi-project/glpi
21,448
glpi-project__glpi-21448
[ 21433 ]
955078fcc97d673a78c64381191d343cf47e161a
diff --git a/src/Glpi/Api/API.php b/src/Glpi/Api/API.php index 6d551c7dd57..d9e570537b8 100644 --- a/src/Glpi/Api/API.php +++ b/src/Glpi/Api/API.php @@ -1503,10 +1503,9 @@ private function getSearchOptionUniqID($itemtype, $option = []) $sub_itemtype = getItemTypeForTable($option['table']); - if ( - ...
diff --git a/tests/web/APIRestTest.php b/tests/web/APIRestTest.php index 037b75542ad..64c449378ca 100644 --- a/tests/web/APIRestTest.php +++ b/tests/web/APIRestTest.php @@ -482,6 +482,24 @@ public function testListSearchEmpty() $this->checkEmptyContentRange($data, $data['headers']); } + public functi...
Legacy api search/AllAssets not working ### Code of Conduct - [x] I agree to follow this project's Code of Conduct ### Is there an existing issue for this? - [x] I have searched the existing issues ### Version 11.0.1 ### Bug description I have an app that still uses legacy api. (migrating to new api is still in ...
[ "https://github.com/glpi-project/glpi/commit/036f930289b69de3c5594a760549cf92b80c57b9", "https://github.com/glpi-project/glpi/commit/976789cd5102dbc2dbb0b1250782c9d9980148bf", "https://github.com/glpi-project/glpi/commit/1eb48a99ddf573788dff5a780afa72cec58b63b0", "https://github.com/glpi-project/glpi/commit/f...
2025-10-13T12:10:22
9.1
PHP
glpi-project/glpi
19,519
glpi-project__glpi-19519
[ 18299, 19506 ]
908cbe2cf18dd0f6fd8085b986bbdf41b122e4e1
diff --git a/install/empty_data.php b/install/empty_data.php index 04509bb2fa9..ef8651cced2 100644 --- a/install/empty_data.php +++ b/install/empty_data.php @@ -39,6 +39,8 @@ use Glpi\RichText\UserMention; use Glpi\Socket; +use function Safe\json_encode; + // Use anonymous class so we can have constants that defin...
diff --git a/tests/cypress/e2e/oauth_authcode.cy.js b/tests/cypress/e2e/oauth_authcode.cy.js new file mode 100644 index 00000000000..d4399c863a1 --- /dev/null +++ b/tests/cypress/e2e/oauth_authcode.cy.js @@ -0,0 +1,107 @@ +/** + * --------------------------------------------------------------------- + * + * GLPI - Gest...
API HL documentation authentication depends on the `remember_me` feature activation The authentication using the `authorizationCode` flow requires the `remember_me` feature to be enabled and the `Remember me` checkbox to be checked during the authentication. See https://github.com/glpi-project/glpi/blob/5067f3b55193d7b...
The diff to fix this seems pretty simple: ```diff --git a/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php b/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php index 46c18d8cdf6..1921fc756d1 100644 --- a/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php +++ b/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php @@...
The diff to fix this seems pretty simple: ```diff --git a/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php b/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php index 46c18d8cdf6..1921fc756d1 100644 --- a/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php +++ b/src/Glpi/Api/HL/Middleware/CookieAuthMiddleware.php @@...
[ "https://github.com/glpi-project/glpi/commit/12b745d714ad85c5a46e534137bb3772b5c13f7c", "https://github.com/glpi-project/glpi/commit/c26c360b297c879ea5dde3f9fcbd61d941bd03f3", "https://github.com/glpi-project/glpi/commit/aab5db7104e4816b1fb92fadb4fabd1856d8f2ec", "https://github.com/glpi-project/glpi/commit/2...
2025-04-22T16:58:17
9.1
PHP
flow-php/flow
1,119
flow-php__flow-1119
[ 1116 ]
de424138358c9eba3c0e75bc737f6e0b0acc4d68
diff --git a/src/core/etl/src/Flow/ETL/ExternalSort/RowsMinHeap.php b/src/core/etl/src/Flow/ETL/ExternalSort/RowsMinHeap.php index aa57b40ee..363077238 100644 --- a/src/core/etl/src/Flow/ETL/ExternalSort/RowsMinHeap.php +++ b/src/core/etl/src/Flow/ETL/ExternalSort/RowsMinHeap.php @@ -45,17 +45,22 @@ public function ins...
diff --git a/src/core/etl/tests/Flow/ETL/Tests/Integration/ExternalSort/CacheExternalSortTest.php b/src/core/etl/tests/Flow/ETL/Tests/Integration/ExternalSort/CacheExternalSortTest.php new file mode 100644 index 000000000..af5ba7ff8 --- /dev/null +++ b/src/core/etl/tests/Flow/ETL/Tests/Integration/ExternalSort/CacheExt...
Sorting by column works in opposite way when external sort exceeds allowed memory It looks that when whole dataset to sort is small enough to fit into allowed memory for external sort implementation then sorting works fine (sorry for overcomplicated example, I was testing multiple theories): ```php // putenv('FLOW_EX...
hey, from top of my head I can say that it's very possible that it might work differently since after reaching certain predicted memory consumption, different algorithm is being used which might cause discrapencies. I'm gonna take a look into this, thank you for the code samples and expected output, that will make it...
hey, from top of my head I can say that it's very possible that it might work differently since after reaching certain predicted memory consumption, different algorithm is being used which might cause discrapencies. I'm gonna take a look into this, thank you for the code samples and expected output, that will make it...
[ "https://github.com/flow-php/flow/commit/8ff023cfa27e61908cd086de06ca53766f3ca6ba" ]
2024-07-17T20:40:58
0.8
PHP
flow-php/flow
2,010
flow-php__flow-2010
[ 2009 ]
3c481537cc0ec3fa81628eff90d39850452332a3
diff --git a/src/core/etl/src/Flow/ETL/Row/Entry/HTMLEntry.php b/src/core/etl/src/Flow/ETL/Row/Entry/HTMLEntry.php index 9777bf089..d9f977dc1 100644 --- a/src/core/etl/src/Flow/ETL/Row/Entry/HTMLEntry.php +++ b/src/core/etl/src/Flow/ETL/Row/Entry/HTMLEntry.php @@ -32,7 +32,7 @@ public function __construct( ?Me...
diff --git a/src/core/etl/tests/Flow/ETL/Tests/Unit/Row/Entry/HTMLEntryTest.php b/src/core/etl/tests/Flow/ETL/Tests/Unit/Row/Entry/HTMLEntryTest.php index f2f81e1db..6ff7b5ce2 100644 --- a/src/core/etl/tests/Flow/ETL/Tests/Unit/Row/Entry/HTMLEntryTest.php +++ b/src/core/etl/tests/Flow/ETL/Tests/Unit/Row/Entry/HTMLEntry...
[Bug]: HTMLEntry/HTMLType cannot read not-strict HTML ### What happened? If parsed HTML is not strictly valid, right now `HTMLEntry` and/or `HTMLType` can produce a PHP warning: ```shell In HTMLEntry.php line 35: ...
[ "https://github.com/flow-php/flow/commit/771f8a2f649a33b486f89c2985b5472e0a15e03b" ]
2025-11-15T11:02:26
0.27
PHP
flow-php/flow
1,613
flow-php__flow-1613
[ 1612 ]
40c7eae20bc0dcb2bf1ff237ba58db1f4725dac0
diff --git a/src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine/DbalKeySetExtractor.php b/src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine/DbalKeySetExtractor.php index e6d44a263..a11601f7d 100644 --- a/src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine/DbalKeySetExtractor.php +++ ...
diff --git a/src/adapter/etl-adapter-doctrine/tests/Flow/ETL/Adapter/Doctrine/Tests/Integration/DbalKeySetExtractorTest.php b/src/adapter/etl-adapter-doctrine/tests/Flow/ETL/Adapter/Doctrine/Tests/Integration/DbalKeySetExtractorTest.php index 196c9e591..3296ea78c 100644 --- a/src/adapter/etl-adapter-doctrine/tests/Flow...
Add alias to KeySet pagination Key Currently when using keyset pagination we might get to the edge case where key might be ambiguous column. This might happen when we join tables, both have `id` column but in the select we expose only one of them: ```sql SELECT a.id as id FROM table_a a LEFT JOIN table_b b ON a.su...
[ "https://github.com/flow-php/flow/commit/5f4088a103b702a532aad52ffc4ea707261ff450", "https://github.com/flow-php/flow/commit/ecff945ca713ab8ed11447a0be039bb819121e48", "https://github.com/flow-php/flow/commit/fd7d913115eea57a2320df9a993af358e9df82e1" ]
2025-05-01T12:07:56
0.15
PHP
flow-php/flow
1,232
flow-php__flow-1232
[ 1231 ]
625366a56af9f2203c0d5890cc49e537f0d16050
diff --git a/src/core/etl/src/Flow/ETL/Pipeline/SynchronousPipeline.php b/src/core/etl/src/Flow/ETL/Pipeline/SynchronousPipeline.php index 0fcf5cf4b..d4534ab13 100644 --- a/src/core/etl/src/Flow/ETL/Pipeline/SynchronousPipeline.php +++ b/src/core/etl/src/Flow/ETL/Pipeline/SynchronousPipeline.php @@ -57,7 +57,13 @@ publ...
diff --git a/src/adapter/etl-adapter-doctrine/tests/Flow/ETL/Adapter/Doctrine/Tests/Integration/DbalLoaderTest.php b/src/adapter/etl-adapter-doctrine/tests/Flow/ETL/Adapter/Doctrine/Tests/Integration/DbalLoaderTest.php index f74689839..e2851bbd7 100644 --- a/src/adapter/etl-adapter-doctrine/tests/Flow/ETL/Adapter/Doctr...
Doctrine - empty input invokes runtime exception "Bulk data cannot be empty" Either when the input is empty or you filter out all the input data you leverage "to_dbal_table_insert" function it should probably just do nothing, but I received an Runtime exception "Bulk data cannot be empty" instead. ```php df() -...
[ "https://github.com/flow-php/flow/commit/828ddc4d4bcfa2523e6f21f5ef6d8c33e04e86d7", "https://github.com/flow-php/flow/commit/7732b4b9f845227d650bb76525e09730cdd229b0" ]
2024-09-24T09:35:18
0.10
PHP
flow-php/flow
1,765
flow-php__flow-1765
[ 1761 ]
c638cbfe0e312d4c96f35cf16225bb714ec0b6fa
diff --git a/documentation/components/libs/parquet.md b/documentation/components/libs/parquet.md index 61e994344..1589e4c41 100644 --- a/documentation/components/libs/parquet.md +++ b/documentation/components/libs/parquet.md @@ -307,3 +307,217 @@ If you want to achieve the best compression, you should use `GZIP` or `SN...
diff --git a/src/lib/parquet/tests/Flow/Parquet/Tests/Unit/Options/ColumnsEncodingsTest.php b/src/lib/parquet/tests/Flow/Parquet/Tests/Unit/Options/ColumnsEncodingsTest.php new file mode 100644 index 000000000..8884ea327 --- /dev/null +++ b/src/lib/parquet/tests/Flow/Parquet/Tests/Unit/Options/ColumnsEncodingsTest.php ...
[Proposal]: Allow to chose encoding for parquet columns ### Describe the Proposal Currently Parquet library support following encodings: - Plain - RLEDictionary - Delta (work in progress) But more will come. Right now Plain is used for everything, RLEDictionary is unused, and Delta is going to be used for Int32 ...
[ "https://github.com/flow-php/flow/commit/c2ef7a9cc5a1e40f140667d60d7421abfd7570c6", "https://github.com/flow-php/flow/commit/53b89a372e4058e14b9c760e56632d752be49c94" ]
2025-07-13T20:40:44
0.20
PHP
barryvdh/laravel-ide-helper
1,428
barryvdh__laravel-ide-helper-1428
[ 1402 ]
4dc20b028adaeadf603860f179f09da5aa21f5b5
diff --git a/src/Console/ModelsCommand.php b/src/Console/ModelsCommand.php index 9f9931f0c..2aecdf2c3 100644 --- a/src/Console/ModelsCommand.php +++ b/src/Console/ModelsCommand.php @@ -1055,9 +1055,11 @@ protected function createPhpDocs($class) } $classname = $this->write_mixin ? $mixinClassName : $...
diff --git a/tests/Console/ModelsCommand/GeneratePhpdocWithMixin/__snapshots__/Test__test__1.php b/tests/Console/ModelsCommand/GeneratePhpdocWithMixin/__snapshots__/Test__test__1.php index 88e7eb658..eb3020025 100644 --- a/tests/Console/ModelsCommand/GeneratePhpdocWithMixin/__snapshots__/Test__test__1.php +++ b/tests/C...
PHP 8.2 - Ide helper files seem not recognized ### Versions: - ide-helper Version: 2.12.13 - Laravel Version: 9.44 - PHP Version: 8.2 ### Description: After the update to PHP 8.2 all @Property annotations which include in `_ide_helper_models.php` are not recognized and an `Access to an undefined property` is...
This seems to just be an issue in general with using mixins in this way now. I initially thought this was a bug too and created an issue in phpstan/phpstan#8939 but after some discussion it makes sense. PHPStan is assuming that because the IdeHelper class has no `__get`/`__set` the properties attached to it are dynamic...
This seems to just be an issue in general with using mixins in this way now. I initially thought this was a bug too and created an issue in phpstan/phpstan#8939 but after some discussion it makes sense. PHPStan is assuming that because the IdeHelper class has no `__get`/`__set` the properties attached to it are dynamic...
[ "https://github.com/barryvdh/laravel-ide-helper/commit/19b6ebd58fe7c0e9aeeffb53691046f860955e87", "https://github.com/barryvdh/laravel-ide-helper/commit/6ac2a187c099b6e9c10b885cb097cb850bc78329" ]
2023-03-09T14:50:56
2.13
PHP
barryvdh/laravel-ide-helper
1,479
barryvdh__laravel-ide-helper-1479
[ 1474 ]
5c886fb653386ce057070258d99f7d850161ae1f
diff --git a/CHANGELOG.md b/CHANGELOG.md index d9dfde61e..0a918604f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file. ### Added - Add support for enum default arguments using enum cases. [#1464 / d8vjork](https://github.com/barryvdh/lar...
diff --git a/tests/Console/ModelsCommand/Relations/Models/CompositeBelongsToVariation.php b/tests/Console/ModelsCommand/Relations/Models/CompositeBelongsToVariation.php new file mode 100644 index 000000000..5fb041db0 --- /dev/null +++ b/tests/Console/ModelsCommand/Relations/Models/CompositeBelongsToVariation.php @@ -0,...
Incorrect PHPDoc being written to model for BelongsTo relation ### Versions: - ide-helper Version: 2.13.0 - Laravel Version: 10.x - PHP Version: 8.2.x ### Description: Hello! I'm currently writing the PHPDocs to a few models and I noticed the wrong doc was being generated for the `BelongsTo` relation (and po...
Turns out this was due to the following config: ```php 'additional_relation_return_types' => [ 'belongsTo' => 'many', ], ``` A developer added this to prevent the model helper file generator from failing when using the [Compoships](https://github.com/topclaudy/compoships) package...however, th...
Turns out this was due to the following config: ```php 'additional_relation_return_types' => [ 'belongsTo' => 'many', ], ``` A developer added this to prevent the model helper file generator from failing when using the [Compoships](https://github.com/topclaudy/compoships) package...however, th...
[ "https://github.com/barryvdh/laravel-ide-helper/commit/69b6eb766230f281b90b8476c20c6c413b7aa669", "https://github.com/barryvdh/laravel-ide-helper/commit/25ad98151511b0efcdffdc4c687a98d5bde64109" ]
2023-11-06T19:58:10
2.14
PHP
barryvdh/laravel-ide-helper
1,603
barryvdh__laravel-ide-helper-1603
[ 1598 ]
7740b80704ef5c35fe2d6d8a9cf87068d914b237
diff --git a/CHANGELOG.md b/CHANGELOG.md index f473a14fc..0d323e113 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,8 @@ All notable changes to this project will be documented in this file. -------------- ### Changed -Add support for multiple pivot types when using the same accessor. +- Add support for mult...
diff --git a/tests/Console/ModelsCommand/ResetAndSmartReset/Models/Simple.php b/tests/Console/ModelsCommand/ResetAndSmartReset/Models/Simple.php index 86646d355..86d86bfac 100644 --- a/tests/Console/ModelsCommand/ResetAndSmartReset/Models/Simple.php +++ b/tests/Console/ModelsCommand/ResetAndSmartReset/Models/Simple.php...
PHPStan annotations for models are dropped PHPStan annotations (or any other description) for models are dropped, for example: ```php /** * Some class. * * @implements \App\Contracts\Models\SomeContract<...> * * @property int $id * [...] ``` after: ```php /** * Some class. * * @property in...
Are you adding the reset flag? Hi, yes. I understand that reset resets everything :) but, the class name itself is preserved, so I would expect that the additional description (also phpstan annotations) should also be preserved. Maybe it would be a good idea to add some tag to which ide helper does not change the...
Are you adding the reset flag? Hi, yes. I understand that reset resets everything :) but, the class name itself is preserved, so I would expect that the additional description (also phpstan annotations) should also be preserved. Maybe it would be a good idea to add some tag to which ide helper does not change the...
[ "https://github.com/barryvdh/laravel-ide-helper/commit/29f874381ea8dcd1e905a96b609a7fe34aa8f951", "https://github.com/barryvdh/laravel-ide-helper/commit/4ca8db247f5a96ff55c421a30983048a1a8d5b3b", "https://github.com/barryvdh/laravel-ide-helper/commit/f98cbbd86c5ea4b2f2650780a540db6cd53d674f" ]
2024-10-28T11:13:00
3.2
PHP
barryvdh/laravel-ide-helper
1,714
barryvdh__laravel-ide-helper-1714
[ 1703 ]
ae0a06d406928a8ab7da34586a9c810e68ec1709
diff --git a/src/Console/ModelsCommand.php b/src/Console/ModelsCommand.php index 1c82e9340..1cd7544c1 100644 --- a/src/Console/ModelsCommand.php +++ b/src/Console/ModelsCommand.php @@ -475,7 +475,11 @@ public function castPropertiesType($model) } if (Str::startsWith($type, AsCollection::clas...
diff --git a/tests/Console/ModelsCommand/AdvancedCasts/Collections/AdvancedCastMap.php b/tests/Console/ModelsCommand/AdvancedCasts/Collections/AdvancedCastMap.php new file mode 100644 index 000000000..5dbd4e226 --- /dev/null +++ b/tests/Console/ModelsCommand/AdvancedCasts/Collections/AdvancedCastMap.php @@ -0,0 +1,21 @...
AsCollection::of cast not handled ### Versions: - ide-helper Version: 3.5.5 - Laravel Version: 12.13 - PHP Version: 8.4 ### Description: Laravel 12.10 [added](https://github.com/laravel/framework/pull/55383) a `AsCollection::of(CustomObject::class)` cast. It is not handled by the IDE Helper, which produce no type for...
[ "https://github.com/barryvdh/laravel-ide-helper/commit/df90b88b8797b2f068d9ea7b832e552f39732048", "https://github.com/barryvdh/laravel-ide-helper/commit/b0de33609b95bd4edc38fce0f276e7a95eac3df2" ]
2025-05-20T16:47:43
3.4
PHP
barryvdh/laravel-ide-helper
1,464
barryvdh__laravel-ide-helper-1464
[ 1463 ]
9d14b019f63d08f7a9742364d2b3c6f469c28785
diff --git a/.github/workflows/run-static-analysis.yml b/.github/workflows/run-static-analysis.yml index 1085dfefe..c8c29bb7a 100644 --- a/.github/workflows/run-static-analysis.yml +++ b/.github/workflows/run-static-analysis.yml @@ -17,7 +17,7 @@ jobs: - name: Setup PHP uses: shivammathur/se...
diff --git a/tests/Console/ModelsCommand/GenerateBasicPhpDocWithEnumDefaults/Enums/PostStatus.php b/tests/Console/ModelsCommand/GenerateBasicPhpDocWithEnumDefaults/Enums/PostStatus.php new file mode 100644 index 000000000..afe6b9b34 --- /dev/null +++ b/tests/Console/ModelsCommand/GenerateBasicPhpDocWithEnumDefaults/Enu...
Default values as enums cases ### Versions: - ide-helper Version: 2.12.3 - Laravel Version: 10.19.0 - PHP Version: 8.2.8 ### Description: In case we want to add a default value using an enum typed argument on a model query scope like so: ```php <?php class MyModel extends Model { public function s...
[ "https://github.com/barryvdh/laravel-ide-helper/commit/6802ebc35904b6b13bc533b3e9113839a1b3643f", "https://github.com/barryvdh/laravel-ide-helper/commit/5e5e03243550be64e0a409c53b2d170ec9cf0dce", "https://github.com/barryvdh/laravel-ide-helper/commit/bfe63b194281f45511f1c3049c34f346039073e9", "https://github....
2023-08-28T09:26:26
2.14
PHP
Automattic/jetpack
39,868
Automattic__jetpack-39868
[ 39773 ]
248684d3a70bc645f8a5b23a937efda9a33b1765
diff --git a/projects/packages/changelogger/changelog/fix-changelogger-amend-default-link b/projects/packages/changelogger/changelog/fix-changelogger-amend-default-link new file mode 100644 index 0000000000000..09dc0989a5b9c --- /dev/null +++ b/projects/packages/changelogger/changelog/fix-changelogger-amend-default-lin...
diff --git a/projects/packages/changelogger/tests/php/tests/src/WriteCommandTest.php b/projects/packages/changelogger/tests/php/tests/src/WriteCommandTest.php index ebb2e105351a6..1ea6e7d0c1f6d 100644 --- a/projects/packages/changelogger/tests/php/tests/src/WriteCommandTest.php +++ b/projects/packages/changelogger/test...
`jetpack release plugins/<plugin> amend -s` doesn't remove -beta from link ### Impacted plugin None / Other ### Quick summary Doing a release after running a beta period, should remove `-beta` from the latest github changelog link. ### Steps to reproduce 1. Checkout this branch `boost/branch-3.5.2`; 2. Run `git re...
[ "https://github.com/Automattic/jetpack/commit/27a6229236d9cb1b781f468fc12200b1b581a361", "https://github.com/Automattic/jetpack/commit/7fd4da7b78957aeeb57b75830a6ead6a99b6a665" ]
2024-10-22T19:02:01
3.4
PHP
Automattic/jetpack
41,159
Automattic__jetpack-41159
[ 9984 ]
b0985b72aeb17b0949acc101d7f8885283364e1a
diff --git a/projects/plugins/jetpack/changelog/fix-author-details-are-missing b/projects/plugins/jetpack/changelog/fix-author-details-are-missing new file mode 100644 index 0000000000000..42ee0ea85b33b --- /dev/null +++ b/projects/plugins/jetpack/changelog/fix-author-details-are-missing @@ -0,0 +1,3 @@ +Significance: ...
diff --git a/projects/plugins/jetpack/tests/php/json-api/test_class.json-api-jetpack-base-endpoint.php b/projects/plugins/jetpack/tests/php/json-api/test_class.json-api-jetpack-base-endpoint.php index 489b492df260a..73e7cbd451913 100644 --- a/projects/plugins/jetpack/tests/php/json-api/test_class.json-api-jetpack-base-...
REST API: Author Details are bare and missing extra data that can be gained from site users. In #7707 we removed a check on the `user_id` property of an `author` that we are providing details for when building API responses like `/sites/$site/posts/$post_ID/replies/​` the removal of this check means that we now rarely ...
Related: https://github.com/wordpress-mobile/WordPress-Android/issues/8109 <p>This issue has been marked as stale. This happened because:</p> <ul> <li>It has been inactive in the past 6 months.</li> <li>It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.</li> </ul> <p>No further action is needed. But it's worth c...
Related: https://github.com/wordpress-mobile/WordPress-Android/issues/8109 <p>This issue has been marked as stale. This happened because:</p> <ul> <li>It has been inactive in the past 6 months.</li> <li>It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.</li> </ul> <p>No further action is needed. But it's worth c...
[ "https://github.com/Automattic/jetpack/commit/34749d54d0c60a27b0a58e3491234f3d0180be58", "https://github.com/Automattic/jetpack/commit/6297a756a9c7c8d8cc5a54b0cc3f281fef097d92", "https://github.com/Automattic/jetpack/commit/b3b2384701aea33d062e4e0de1e42316b1359da8", "https://github.com/Automattic/jetpack/comm...
2025-01-17T14:44:47
3.4
PHP
Automattic/jetpack
30,045
Automattic__jetpack-30045
[ 29903 ]
b4c277198c591e58757659274eedc27783b4069d
diff --git a/projects/packages/my-jetpack/changelog/add-my-jetpack-endpoint-to-install-standalone-plugin b/projects/packages/my-jetpack/changelog/add-my-jetpack-endpoint-to-install-standalone-plugin new file mode 100644 index 0000000000000..44b64279111e2 --- /dev/null +++ b/projects/packages/my-jetpack/changelog/add-my...
diff --git a/projects/packages/my-jetpack/tests/php/test-hybrid-product.php b/projects/packages/my-jetpack/tests/php/test-hybrid-product.php index 4071b939c60a9..4a7217eea7dde 100644 --- a/projects/packages/my-jetpack/tests/php/test-hybrid-product.php +++ b/projects/packages/my-jetpack/tests/php/test-hybrid-product.php...
My Jetpack: Update product endpoint for standalone We have the [product endpoint ](https://github.com/Automattic/jetpack/blob/trunk/projects/packages/my-jetpack/src/class-rest-products.php#L53-L60) that activates (and installs if needed) the plugin. This endpoint calls the [`activate`](https://github.com/Automattic/je...
I was checking why both plugins are checked here, and seems like it's intended to fix a 'plugin_absent' status for Backup when only Jetpack is installed. Since we are fixing the status handling, seems safe to remove the check for Jetpack installation. Makes sense? > Since we are fixing the status handling, seems safe ...
I was checking why both plugins are checked here, and seems like it's intended to fix a 'plugin_absent' status for Backup when only Jetpack is installed. Since we are fixing the status handling, seems safe to remove the check for Jetpack installation. Makes sense? > Since we are fixing the status handling, seems safe ...
[ "https://github.com/Automattic/jetpack/commit/0b0840584ab271020a4dfdef679608a487f217cf", "https://github.com/Automattic/jetpack/commit/7f0e6302d175561a00dcd26ead5d919c31379f78", "https://github.com/Automattic/jetpack/commit/567f25c4a4011103e0a66e0003ffccca3f1af242", "https://github.com/Automattic/jetpack/comm...
2023-04-11T22:26:40
3.4
PHP
Automattic/jetpack
39,518
Automattic__jetpack-39518
[ 1258 ]
2b8fce1eb038c50375eb05f1fd6960addf81af7f
diff --git a/projects/plugins/jetpack/.phan/baseline.php b/projects/plugins/jetpack/.phan/baseline.php index 61acd515a45fc..9835c9f32cc96 100644 --- a/projects/plugins/jetpack/.phan/baseline.php +++ b/projects/plugins/jetpack/.phan/baseline.php @@ -88,7 +88,6 @@ // PhanPluginInvalidPregRegex : 1 occurrence //...
diff --git a/projects/plugins/jetpack/tests/php/general/test_class.jetpack.php b/projects/plugins/jetpack/tests/php/general/test_class.jetpack.php index 33844bdd51add..b394d28b1f2ad 100644 --- a/projects/plugins/jetpack/tests/php/general/test_class.jetpack.php +++ b/projects/plugins/jetpack/tests/php/general/test_class...
CSS Concatenating: jetpack.css loads all styles, even if they've been manually dequeued As of this weekend, I'm now seeing `jetpack.css` loading on the front-end, even though the only feature I'm using in Markdown. This file contains CSS for all Jetpack features. I'm currently overriding this behavior using this snipp...
Yes, that's a known issue with Jetpack 3.2. Jetpack now concatenates its CSS into a `jetpack.css` file, overwriting any custom changes you may have made by manually dequeuing one of Jetpack's CSS files. We'll get this fixed. You can follow our progress in #1235. I'll close this issue as it's a duplicate. @jeherve - T...
Yes, that's a known issue with Jetpack 3.2. Jetpack now concatenates its CSS into a `jetpack.css` file, overwriting any custom changes you may have made by manually dequeuing one of Jetpack's CSS files. We'll get this fixed. You can follow our progress in #1235. I'll close this issue as it's a duplicate. @jeherve - T...
[ "https://github.com/Automattic/jetpack/commit/4f1307b73330234726f27e9b24bd9724b368e620", "https://github.com/Automattic/jetpack/commit/c43167887e8b858ec1c3578590ea6cb5a8a6bfd0", "https://github.com/Automattic/jetpack/commit/9233a034091af87ebabdae0658c65e8ba18b96ee", "https://github.com/Automattic/jetpack/comm...
2024-09-24T22:09:16
3.4
PHP
Automattic/jetpack
41,988
Automattic__jetpack-41988
[ 42111 ]
6155b25eec6e119862ccdfdef7c3d52df955e0be
diff --git a/projects/plugins/boost/app/contracts/Has_Slug.php b/projects/plugins/boost/app/contracts/Has_Slug.php index 8fc5d53a1ef16..e9ee4c3ad930d 100644 --- a/projects/plugins/boost/app/contracts/Has_Slug.php +++ b/projects/plugins/boost/app/contracts/Has_Slug.php @@ -2,5 +2,10 @@ namespace Automattic\Jetpack_Boos...
diff --git a/projects/plugins/boost/tests/php/modules/optimizations/page-cache/Cache_Preload_Test.php b/projects/plugins/boost/tests/php/modules/optimizations/page-cache/Cache_Preload_Test.php new file mode 100644 index 0000000000000..b729d2d9808f4 --- /dev/null +++ b/projects/plugins/boost/tests/php/modules/optimizati...
Boost: Cache Preloading - Version One, Cornerstone Pages Implementing a Cache Preloading system for Cornerstone Pages in Jetpack Boost will enhance the performance optimization capabilities of our Page Cache feature. This implementation will automatically rebuild the cache for [Cornerstone Pages](https://jetpack.com/su...
**OpenAI suggested the following labels for this issue:** - [Feature Group] Content Management: The issue relates to managing crucial content through the implementation of cache preloading for cornerstone pages. - [Boost Feature] Page Cache: The issue discusses enhancing the Page Cache feature for cornerstone pages to ...
**OpenAI suggested the following labels for this issue:** - [Feature Group] Content Management: The issue relates to managing crucial content through the implementation of cache preloading for cornerstone pages. - [Boost Feature] Page Cache: The issue discusses enhancing the Page Cache feature for cornerstone pages to ...
[ "https://github.com/Automattic/jetpack/commit/a85b7a3ded8f62cb6d4be754b47c942d783f4f35", "https://github.com/Automattic/jetpack/commit/b4e84019826f27cbe750e7a85f66f84dbff23b57", "https://github.com/Automattic/jetpack/commit/b7ac76ff1d64d75b1865ca60d894387295dbc3d6", "https://github.com/Automattic/jetpack/comm...
2025-02-24T12:39:40
3.4
PHP